From nobody Thu Sep 04 18:16:21 2025 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4cHnjd4jcrz66Wq3; Thu, 04 Sep 2025 18:16:21 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R12" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4cHnjd3sBQz3JBT; Thu, 04 Sep 2025 18:16:21 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1757009781; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=S2Rib2cU/a2x7BVguqrZiAsr6N2m0yPD7YE/wmCRkBA=; b=SNTMF/3DTUVI7hpvs9jHGFnj35aqzvrQt2QN02dtBV44OfxFR31PdofRzoOkJ+xmqZAQzw As46/xF+Zag0aqNF/kH+WWxPWj4bMu+4Fd4HEujH3o9mic5H/0KfxHe8Z0x+nUoetKVKpM NlaxUdis5Pnvv2nThZCWeu51vGL2L/x3pUCB0MOA5+TcYQ1lqw5AomY/XrnMGV3q/TBmTp 4iEY1mP7Z9d1Yr+ecvhEzcGW0+OIzjzHe6d847dwidvEg31TN4eWyCPQmg6sg8bi7n4vdq COPkYxX3g+lRM7B34CniwOMzV+2r3BKedGI2I1OmSYcq6wtRvpYxMTfKBNlv4g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1757009781; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=S2Rib2cU/a2x7BVguqrZiAsr6N2m0yPD7YE/wmCRkBA=; b=goZ5tjqsFK+y8ZApbdB5NScci9Cn/zC28HsrNf3SCHP6JCNzljPf9WGCKkMuq5GmmQ+5pn qDsHZt+04lnMKBXRoOTXNmxiAjttwWPlClDUZcYZzcPWkUwWgfCN6/4lqRytPGs+xUPWBP ID/ud46BsfLktOHDnFNgskX5tQDhOfsypC0Az+i6gBoaKQiLEXbq4hOdswkiM9I54kSdev vWBblrn1LAHLr+rodSrwnmGfahHGeolHCp0NtI/jRUENka2jWQB5xkUq7aVT2lxrTXWMuC 9SF5pJMfn3ePSPYGVQY6kg8wHrNXwv+Cq3bLkHVPTchitwxmOoOvA7MswL3Sxw== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1757009781; a=rsa-sha256; cv=none; b=MkNXcFZhHoi00BNxu9FYxI6RCsToGFxmGBVWjN2F4cQ2G7OdpKt4Psrz2htjerldgjDnUM PWPn/l0d9ak8HlRfgMGVmh67XiXHBvPGDmSlrvBbD0E+3R9GoV/Fy74nbRNUjm8hSSwbul bltfoTsZLbYjh/RbCAV61XfQxfkUX7qiFb+6KHJpXNfCNhVNSAVZXrZhSPOSw1WTci1aYW urSXZtcKAzMSQN17slFzBXB3GK/vI2Nwd08vUw2mT0y119zqhbhoWfok0RiGZlSTqK0fTS LQWjVk0mvI14uHlo4Num0W4jWSgvjHYaEhgiRiSkj/iznUATzYg61KITmxF4kg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4cHnjd3RHGz1Chd; Thu, 04 Sep 2025 18:16:21 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 584IGLUh039748; Thu, 4 Sep 2025 18:16:21 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 584IGLmf039745; Thu, 4 Sep 2025 18:16:21 GMT (envelope-from git) Date: Thu, 4 Sep 2025 18:16:21 GMT Message-Id: <202509041816.584IGLmf039745@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Dag-Erling =?utf-8?Q?Sm=C3=B8rgrav?= Subject: git: 167991a1bfb4 - stable/14 - ipfw: Fix segfault in NPTv6 rule parser List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: des X-Git-Repository: src X-Git-Refname: refs/heads/stable/14 X-Git-Reftype: branch X-Git-Commit: 167991a1bfb4bc2d8767b274c8dac2a96450b215 Auto-Submitted: auto-generated The branch stable/14 has been updated by des: URL: https://cgit.FreeBSD.org/src/commit/?id=167991a1bfb4bc2d8767b274c8dac2a96450b215 commit 167991a1bfb4bc2d8767b274c8dac2a96450b215 Author: Seyed Pouria Mousavizadeh Tehrani AuthorDate: 2025-08-21 17:40:29 +0000 Commit: Dag-Erling Smørgrav CommitDate: 2025-09-04 18:15:43 +0000 ipfw: Fix segfault in NPTv6 rule parser If the user specified a prefix length with either the internal or external prefix, we'd jump to check_prefix where we'd dereference p which was most likely uninitialized. Instead, store the various prefix lengths separately and check them all after the loop. MFC after: 1 week Differential Revision: https://reviews.freebsd.org/D50597 (cherry picked from commit 64bc9ac8cd9a42259aeb1715d4e14902aa83fcac) --- sbin/ipfw/nptv6.c | 49 ++++++++++++++++++++++++++----------------------- 1 file changed, 26 insertions(+), 23 deletions(-) diff --git a/sbin/ipfw/nptv6.c b/sbin/ipfw/nptv6.c index fc9ce638b8af..f8c3693125b8 100644 --- a/sbin/ipfw/nptv6.c +++ b/sbin/ipfw/nptv6.c @@ -154,10 +154,10 @@ static struct _s_x nptv6newcmds[] = { { NULL, 0 } }; - static void nptv6_parse_prefix(const char *arg, struct in6_addr *prefix, int *len) { + long plen; char *p, *l; p = strdup(arg); @@ -168,13 +168,15 @@ nptv6_parse_prefix(const char *arg, struct in6_addr *prefix, int *len) if (inet_pton(AF_INET6, p, prefix) != 1) errx(EX_USAGE, "Bad prefix: %s", p); if (l != NULL) { - *len = (int)strtol(l, &l, 10); - if (*l != '\0' || *len <= 0 || *len > 64) + plen = strtol(l, &l, 10); + if (*l != '\0' || plen < 8 || plen > 64) errx(EX_USAGE, "Bad prefix length: %s", arg); + *len = plen; } else *len = 0; free(p); } + /* * Creates new nptv6 instance * ipfw nptv6 create int_prefix ext_prefix @@ -190,10 +192,10 @@ nptv6_create(const char *name, uint8_t set, int ac, char *av[]) struct in6_addr mask; ipfw_nptv6_cfg *cfg; ipfw_obj_lheader *olh; - int tcmd, flags, plen; + int tcmd, flags, iplen, eplen, pplen; char *p; - plen = 0; + iplen = eplen = pplen = 0; memset(buf, 0, sizeof(buf)); olh = (ipfw_obj_lheader *)buf; cfg = (ipfw_nptv6_cfg *)(olh + 1); @@ -206,10 +208,8 @@ nptv6_create(const char *name, uint8_t set, int ac, char *av[]) switch (tcmd) { case TOK_INTPREFIX: NEED1("IPv6 prefix required"); - nptv6_parse_prefix(*av, &cfg->internal, &plen); + nptv6_parse_prefix(*av, &cfg->internal, &iplen); flags |= NPTV6_HAS_INTPREFIX; - if (plen > 0) - goto check_prefix; ac--; av++; break; case TOK_EXTPREFIX: @@ -217,10 +217,8 @@ nptv6_create(const char *name, uint8_t set, int ac, char *av[]) errx(EX_USAGE, "Only one ext_prefix or ext_if allowed"); NEED1("IPv6 prefix required"); - nptv6_parse_prefix(*av, &cfg->external, &plen); + nptv6_parse_prefix(*av, &cfg->external, &eplen); flags |= NPTV6_HAS_EXTPREFIX; - if (plen > 0) - goto check_prefix; ac--; av++; break; case TOK_EXTIF: @@ -237,24 +235,29 @@ nptv6_create(const char *name, uint8_t set, int ac, char *av[]) break; case TOK_PREFIXLEN: NEED1("IPv6 prefix length required"); - plen = strtol(*av, &p, 10); -check_prefix: - if (*p != '\0' || plen < 8 || plen > 64) + pplen = strtol(*av, &p, 10); + if (*p != '\0' || pplen < 8 || pplen > 64) errx(EX_USAGE, "wrong prefix length: %s", *av); - /* RFC 6296 Sec. 3.1 */ - if (cfg->plen > 0 && cfg->plen != plen) { - warnx("Prefix length mismatch (%d vs %d). " - "It was extended up to %d", - cfg->plen, plen, MAX(plen, cfg->plen)); - plen = MAX(plen, cfg->plen); - } - cfg->plen = plen; - flags |= NPTV6_HAS_PREFIXLEN; ac--; av++; break; } } + /* RFC 6296 Sec. 3.1 */ + if (pplen != 0) { + if ((eplen != 0 && eplen != pplen) || + (iplen != 0 && iplen != pplen)) + errx(EX_USAGE, "prefix length mismatch"); + cfg->plen = pplen; + flags |= NPTV6_HAS_PREFIXLEN; + } else if (eplen != 0 || iplen != 0) { + if (eplen != 0 && iplen != 0 && eplen != iplen) + errx(EX_USAGE, "prefix length mismatch"); + warnx("use prefixlen instead"); + cfg->plen = eplen ? eplen : iplen; + flags |= NPTV6_HAS_PREFIXLEN; + } + /* Check validness */ if ((flags & NPTV6_HAS_INTPREFIX) != NPTV6_HAS_INTPREFIX) errx(EX_USAGE, "int_prefix required");