From nobody Mon Oct 27 16:19:16 2025 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4cwJcL6pmRz6F16c for ; Mon, 27 Oct 2025 16:19:30 +0000 (UTC) (envelope-from jlduran@gmail.com) Received: from mail-qk1-f170.google.com (mail-qk1-f170.google.com [209.85.222.170]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "WR4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4cwJcK5lSCz4MN9 for ; Mon, 27 Oct 2025 16:19:29 +0000 (UTC) (envelope-from jlduran@gmail.com) Authentication-Results: mx1.freebsd.org; none Received: by mail-qk1-f170.google.com with SMTP id af79cd13be357-88fbbec670aso81907285a.0 for ; Mon, 27 Oct 2025 09:19:29 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1761581969; x=1762186769; h=content-transfer-encoding:cc:to:subject:message-id:date:from :reply-to:in-reply-to:references:mime-version:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=rYL/wyGYcPvp4j/Z/tLdDYawtPQ1slIuvDM9Hk8mueU=; b=jDJmTeub3LEl7QU7dS/fxl6LPLq08szA/phSoXf9gJraWdAxWW0TJii9+eNigbZw5U LmmdGbIllOOKJzsKD1TN4WHZFx8YqabWBIwA2NDxV2TLCfC1zSwfkMTRwNLso2YW87hR QR2SLxgTbSg9IcikF8j54MHdFJ19HU6rpNPbJVuNGLztvce9Vwdyui17536fayLg/kCa Kf+v5USYUpMMzxf/hh8ngp5GngmiFxr4CVJYreBoZF1SuD/7l3AvngjVaXOXR/bJdXQa Bpad8H+9tC1NoNKXFAmvv70qiO/RNam/O3EKiGpvoER5rUECQg6NQFPDNdRIsT39h+Pe uKdA== X-Forwarded-Encrypted: i=1; AJvYcCWBb7OXioiAwckbgvuuPhshv+SIowJBeZtUVFqp3MGBl/nL9qTeUpqjdzbBTu7H/hEEg+tymfdm6YZJF8qTbM1w9UcF@freebsd.org X-Gm-Message-State: AOJu0YwoxQBokZccn7T0gzz1WsW3S/aHjhn6c7J6b6w4gjjVOX+oZ3MP JX8OtkxkrAoTHDoPN5faA+MK4sLx5GiCB5jhzSYebpInnwyK+0qyo057wWBS30KGJ7E= X-Gm-Gg: ASbGncvBMYj7AXwJC9z9DFrsEqxyEOUceVkckPCicagY+/Waz7uXKnemAHQdT9YWvKN lH0aeunztjwEFoCwg2nOHTmIgwrqdaga/ACi9+tLdx7L6JFg/XGeoQmLMIUZQKGtiU/2+QFLfye eBd0VoIuOYcLCwUr7OAX9yMJrch75uJmu0VXr+H92Ng04lSpX/fMjhxoTwKgIs5fnUNnIcmlIzI Swjo3Eo/ohTkvi+03qcBmjbi0aYKUZIo6x6s/uR7M0D9jm9dCNg+B6f2lWkUyyEE52qUZ5fqdy8 ERsXqZmTRJQBaEwTO7EbJflrgBXQ7i49FQmzDc8oO6qVYlZ98SnOVKOjrJyHhjJDH1NNZ+IWL9o Herc3qwDCAuJGgCXFOruN6P+pruIHcwtK9N4bk58whKFxM5e7Hh4Poz9poKjW1fB1qTLAr9T3RQ 2eJHVj0M7eGb+NKQjLkPBTexItlDAJ8CDFvsydudUy X-Google-Smtp-Source: AGHT+IGiFVGpC6XAMHgj0cxt4pwhejFFcxlcZF1XO5inUjVJLagbBsxaBNYW/xE4gwDI/bUiQZWoaQ== X-Received: by 2002:a05:6214:f2d:b0:801:2595:d05d with SMTP id 6a1803df08f44-87ffb0cf083mr1700206d6.3.1761581968504; Mon, 27 Oct 2025 09:19:28 -0700 (PDT) Received: from mail-qt1-f175.google.com (mail-qt1-f175.google.com. [209.85.160.175]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-87fc49ee9a0sm59364336d6.60.2025.10.27.09.19.28 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 27 Oct 2025 09:19:28 -0700 (PDT) Received: by mail-qt1-f175.google.com with SMTP id d75a77b69052e-4e8856210b3so3209341cf.0 for ; Mon, 27 Oct 2025 09:19:28 -0700 (PDT) X-Forwarded-Encrypted: i=1; AJvYcCWk+uZbyuTDqjiwilhBcPVWxFYS2iMsDj3VADL+lzCzmCLrOY7oYdo75/kat5k9eVRYTy/O/Hzr9qNnCiPaUcnoWrqv@freebsd.org X-Received: by 2002:ac8:7c43:0:b0:4e0:b24a:6577 with SMTP id d75a77b69052e-4ed0745ac40mr5912671cf.2.1761581968063; Mon, 27 Oct 2025 09:19:28 -0700 (PDT) List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 References: <202510271547.59RFlnxW096622@gitrepo.freebsd.org> <20251027155808.A4532201@slippy.cwsent.com> <20251027161755.0D67A40B@slippy.cwsent.com> In-Reply-To: <20251027161755.0D67A40B@slippy.cwsent.com> Reply-To: jlduran@freebsd.org From: Jose Luis Duran Date: Mon, 27 Oct 2025 13:19:16 -0300 X-Gmail-Original-Message-ID: X-Gm-Features: AWmQ_bndW8kFlEDVHbSfRyd3orHaIwTj9C7Ksp24nx6Uh7E4HTDC9I51RfTFdvI Message-ID: Subject: Re: git: 79e374217d69 - main - blocklist: Fix rcorder(8) To: Cy Schubert Cc: src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spamd-Bar: ---- X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:15169, ipnet:209.85.128.0/17, country:US] X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Rspamd-Queue-Id: 4cwJcK5lSCz4MN9 On Mon, Oct 27, 2025 at 1:18=E2=80=AFPM Cy Schubert wrote: > > In message om> > , Jose Luis Duran writes: > > On Mon, Oct 27, 2025 at 12:58=3DE2=3D80=3DAFPM Cy Schubert > .com> wrote: > > > > > > In message <202510271547.59RFlnxW096622@gitrepo.freebsd.org>, Jose Lu= is > > > Duran w > > > rites: > > > > The branch main has been updated by jlduran: > > > > > > > > URL: https://cgit.FreeBSD.org/src/commit/?id=3D3D79e374217d69a98161= fc91a2=3D > > 86dacf1f > > > > 78090894 > > > > > > > > commit 79e374217d69a98161fc91a286dacf1f78090894 > > > > Author: Jose Luis Duran > > > > AuthorDate: 2025-10-27 15:46:32 +0000 > > > > Commit: Jose Luis Duran > > > > CommitDate: 2025-10-27 15:46:32 +0000 > > > > > > > > blocklist: Fix rcorder(8) > > > > > > > > The blocklist daemon depends on a packet filter in order to blo= ck. > > > > > > > > Add all supported packet filters to the REQUIRE line, not just = pf, =3D > > to > > > > indicate rcorder(8) that it should start after the packet filte= r se=3D > > rvice > > > > has started. > > > > > > > > While here, change the mode of the rc file to include the execu= tabl=3D > > e > > > > bit, just like the rest of the files in the rc.d source directo= ry. > > > > > > > > Reviewed by: 0mp > > > > MFC after: 2 days > > > > Differential Revision: https://reviews.freebsd.org/D53364 > > > > --- > > > > libexec/rc/rc.d/blacklistd | 2 +- > > > > libexec/rc/rc.d/blocklistd | 2 +- > > > > 2 files changed, 2 insertions(+), 2 deletions(-) > > > > > > > > diff --git a/libexec/rc/rc.d/blacklistd b/libexec/rc/rc.d/blacklist= d > > > > index 9157e258f43f..175e3e8c56b3 100755 > > > > --- a/libexec/rc/rc.d/blacklistd > > > > +++ b/libexec/rc/rc.d/blacklistd > > > > @@ -29,7 +29,7 @@ > > > > # > > > > > > > > # PROVIDE: blacklistd > > > > -# REQUIRE: netif pf > > > > +# REQUIRE: netif ipfilter ipfw pf > > > > > > This means all three, ipfilter AND ipfw AND pf, must be enabled and > > > started. What if one uses only one of the three? > > > > No, per rcorder(8) BUGS section: > > > > The REQUIRE keyword is misleading: > > It does not describe which daemons have to be running before a script > > will be started. > > It describes which scripts must be placed before it in the dependency o= rder=3D > > ing. > > > > 0mp@ even suggests creating a FIREWALL(S) script to represent that an > > rc script should start after the firewall (any one or many) has > > started. I agree, but I cannot immediately submit a patch for it. > > I stand corrected. Thanks. No problem! It is indeed misleading. > > > > > > > > > > > . /etc/rc.subr > > > > > > > > diff --git a/libexec/rc/rc.d/blocklistd b/libexec/rc/rc.d/blocklist= d > > > > old mode 100644 > > > > new mode 100755 > > > > index 24cbae77fd40..f979162ec3e0 > > > > --- a/libexec/rc/rc.d/blocklistd > > > > +++ b/libexec/rc/rc.d/blocklistd > > > > @@ -29,7 +29,7 @@ > > > > # > > > > > > > > # PROVIDE: blocklistd > > > > -# REQUIRE: netif pf > > > > +# REQUIRE: netif ipfilter ipfw pf > > > > > > Ditto. > > > > > > > > > > > . /etc/rc.subr > > > > > > > > > > > > > > > > > -- > > > Cheers, > > > Cy Schubert > > > FreeBSD UNIX: Web: https://FreeBSD.org > > > NTP: Web: https://nwtime.org > > > > > > e**(i*pi)+1=3D3D0 > > > > > > > > > > > > --=3D20 > > Jose Luis Duran > > > > -- > Cheers, > Cy Schubert > FreeBSD UNIX: Web: https://FreeBSD.org > NTP: Web: https://nwtime.org > > e**(i*pi)+1=3D0 > > --=20 Jose Luis Duran