From nobody Wed Oct 22 13:01:13 2025 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4cs8Rt34x1z6FFwr; Wed, 22 Oct 2025 13:01:14 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R12" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4cs8Rt0Nqdz3pnp; Wed, 22 Oct 2025 13:01:14 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1761138074; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=eUzY5O6PL74p8npIh2p3xKAdm9RPiwMbsUssAJUW/Wk=; b=Mk6ZRTfbyElOdZI/eH8Le0zZtBvEdC9MNxrR/m6f+ElzzFFNNJhuhb5DQuam6tTplpDLGd wY6KHf/nLtu6oMxkAy3VykAKzT8lsXemsBtv4H/FNwuS2qYZNNkMIDjsF8ApBXNkxL/V4z 7WJRHeXMqEYkGsOsRrEHKN165q1lNZkPvXf8sCsf+FB06/65GVCU3khRfQGB0Ccpc/9Cl5 UiEl5i97EkYw6jXj64Hwu9ioNqHQyFY8PypWQ3gOz2dfKmZLer9V28b50XczVJU3V8zWKx uV+qOYzUq+chTB5SEeq2N6i9Gn+VZn+iMDdRGTCvM9lbmLFiaIUylljpesN+Rg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1761138074; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=eUzY5O6PL74p8npIh2p3xKAdm9RPiwMbsUssAJUW/Wk=; b=chBp1m4a4VCgvGB1OdyyViQSXabiOj3sTAdd5uKNJMNIJanMtlZIKNm9xuSqlOH5uMDEBz JHkVudzTwOolKCc+S593+kVbe56EI1AW1uDnOQ15xNjKJU8Ci2nzizMxuqwn7jiAI0mSF1 /Cvinh4moX6VfQA5b1tBgt+FVhl410zUAa6EdNdGaSQfV1JPX0ZsxviCYoBItAZr6rfZfn 9Is59ICdjS056DfR62xdyf2hANQ9v1wAwcBR6ZNwdz7R/Pgq1BHZ4L8dOut1JvzEEmQWf8 vciccGJ7jwLUDKjkUA8SK2tEjcq9qUhA+jgudepvlTMxuYnGLM1Nu/MBntbWNw== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1761138074; a=rsa-sha256; cv=none; b=A4BEgLKRbnE7NA0P6Ys40v9OapO7GEvFbwuiPdGfma58TZAGZQGiiRs5YsWxLFYEYzQajI eafZJZ6qJxgpPODzFFLAb47azDP22E7mzRudaPaP2Pno7S4w+V7uSfgNjfk8NkB+Srait/ xHxh6SiG9n7xXiuF52aRR+D1RCgW5mMJnN+ITYkhOrXXW0NmAq+nm5FS7ctMs9Gxwdt6Di n4mMaybmWIdZJHCoqoSy09KnrAT+e7Nu8VTeN4rw6rPAh7BMfN+0H3Fywl0S9D0Mw6sVIr en9JwTZmuCneKIkg9pUOp4HU5bnUX91u8raHHn+mBrDEIZK2nVr7XxO2iY0Hxg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4cs8Rs6wC1zTbK; Wed, 22 Oct 2025 13:01:13 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 59MD1DsA009729; Wed, 22 Oct 2025 13:01:13 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 59MD1D0A009726; Wed, 22 Oct 2025 13:01:13 GMT (envelope-from git) Date: Wed, 22 Oct 2025 13:01:13 GMT Message-Id: <202510221301.59MD1D0A009726@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Mark Johnston Subject: git: 2078f67215e9 - stable/14 - exec: Check for errors when mapping the shared object List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: markj X-Git-Repository: src X-Git-Refname: refs/heads/stable/14 X-Git-Reftype: branch X-Git-Commit: 2078f67215e934cb9c43b93586ba79fd6fbcee8e Auto-Submitted: auto-generated The branch stable/14 has been updated by markj: URL: https://cgit.FreeBSD.org/src/commit/?id=2078f67215e934cb9c43b93586ba79fd6fbcee8e commit 2078f67215e934cb9c43b93586ba79fd6fbcee8e Author: Mark Johnston AuthorDate: 2025-10-14 13:33:33 +0000 Commit: Mark Johnston CommitDate: 2025-10-21 13:12:16 +0000 exec: Check for errors when mapping the shared object In the non-ASLR case, there is no check for an error from vm_map_fixed(). Restore it, it was dropped in commit 939f0b6323e0a. This bug could result in a refcount leak of the object used to map the VDSO page. Reviewed by: kib Reported by: Ilja Van Sprundel MFC after: 1 week Fixes: 939f0b6323e0 ("Implement shared page address randomization") Differential Revision: https://reviews.freebsd.org/D53065 (cherry picked from commit 7117c86fcb7ebee4483097cefa9b143de8d78ee0) --- sys/kern/kern_exec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sys/kern/kern_exec.c b/sys/kern/kern_exec.c index f4197609a700..7f6d9a85c6bc 100644 --- a/sys/kern/kern_exec.c +++ b/sys/kern/kern_exec.c @@ -1284,7 +1284,7 @@ exec_map_stack(struct image_params *imgp) MAP_INHERIT_SHARE | MAP_ACC_NO_CHARGE); } else { sharedpage_addr = sv->sv_shared_page_base; - vm_map_fixed(map, obj, 0, + error = vm_map_fixed(map, obj, 0, sharedpage_addr, sv->sv_shared_page_len, VM_PROT_READ | VM_PROT_EXECUTE, VM_PROT_READ | VM_PROT_EXECUTE,