From nobody Wed Oct 22 12:28:13 2025 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4cs7jn5fsjz6FCkx; Wed, 22 Oct 2025 12:28:13 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R12" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4cs7jn53RSz3k3m; Wed, 22 Oct 2025 12:28:13 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1761136093; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=d7JAMISd9piME7nwpMyNBZRnsuIWfK7ZyVNBMkB4m+U=; b=iuaECCeMLv7kzVX//0B06MlV4BG+ocUkYjs/BBPfzvylFBHqW3OTLvAlqFzca0GauukPiW 0EXmdiI2gyoLTNrFn4fK5PJ1pjml9QeU3QEKln9yXlsGSboflbfj/dsyBwe/gVi7I5W0yB alWS4p8w0HSuaj7AgGRHstcLMgaFRwbmocnWVeqha5GblsUYS3NWPVtFO++ftqDbBwBSCP qJ7Udiwqlgp5JYNeA/E2tbXuEdOWl/rOjgHMLCH831J8C1XdiCHjMszu8FFKvmabgoZR51 SNH+gCeiAdU5BBRHalfy+vwvp41ECJFMYATxBzfQ/kBbFcs4P7KSszPzUimU6g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1761136093; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=d7JAMISd9piME7nwpMyNBZRnsuIWfK7ZyVNBMkB4m+U=; b=L06X7vV3bfn/Es3eZ+gY3WN8NBf9scKEyhQYfESy+0ZM2VLkwkjbyLqoNxSmr/YE0vDhvQ WxGTJRjczOBrJenjfBDhmlpCnUN5pxGONJ8TqI5v6ABExp0c3Wi0Epl+4JJHHaZGY+1dQM vb/S0IBrozW03gCo59b2ud7GR1QZxWXgx4IbPbjyLrVdUYc3u3+X3SFIs8qE4shXRMH0pt 7iZfOtEvUdg3i2CPPYbQPEWfc9xWt/m57gf0CmwIrKMcHLPI1j0ekJJwI0eK+IJlCJtLfJ lxocPOpnCPMluZ7gW+zLhfilZ64Hg1Fb3d+7bgVp8JBTVOiDY44vqSEGwL/B2Q== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1761136093; a=rsa-sha256; cv=none; b=qbGvkcqijeS7ZKJIQQbzxoTxc92GPBrc+JOscayadoJVsWsBBEvNoGU2uySfHgAHKZq8+u tJmDI7gnWu1NPBkvMRaqGRCrmeVJGpuM30XlUPwA4fmfQ96fvbFnWc27Z2WbNyD0c6Nj5P UQ2fKrhDzhFriaGdERd2NE/+qZHyboN4VN187c0h7j3Wfh/VZQOuDnoOoUz8p5nlalSiEF ESLj22+9/oyiW5NlH/hsSH1ZMIgcaTZv05nou5eBKTHWowmSMCD2MR0zDAsXCYqmX7rlye BqZPr+iM1OTh3CkurvO00r4lfLaSenNddtSc8ageIqr4WVAQQQN3501njmcCrQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4cs7jn4WBDzD8d; Wed, 22 Oct 2025 12:28:13 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 59MCSDAr041264; Wed, 22 Oct 2025 12:28:13 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 59MCSDIs041261; Wed, 22 Oct 2025 12:28:13 GMT (envelope-from git) Date: Wed, 22 Oct 2025 12:28:13 GMT Message-Id: <202510221228.59MCSDIs041261@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Robert Clausecker Subject: git: 1ca09538d942 - main - sys/arm64: fix COMPAT_FREEBSD32 __syscall() List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: fuz X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 1ca09538d94273601dac08204c1d0b3ca9115864 Auto-Submitted: auto-generated The branch main has been updated by fuz: URL: https://cgit.FreeBSD.org/src/commit/?id=1ca09538d94273601dac08204c1d0b3ca9115864 commit 1ca09538d94273601dac08204c1d0b3ca9115864 Author: Robert Clausecker AuthorDate: 2025-10-21 21:35:24 +0000 Commit: Robert Clausecker CommitDate: 2025-10-22 12:24:41 +0000 sys/arm64: fix COMPAT_FREEBSD32 __syscall() It seems like _QUAD_LOWWORD was incorrectly expanded into 1, which is correct for big endian but not little endian. This means we always grab the padding word for the syscall number, which is usually 0, causing SIGSYS to be delivered to the caller. Reintroduce _QUAD_LOWWORD to fix the syscall. PR: 290411 MFC after: 1 week Discussed with: jrtc27 Reviewed by: cognet, emaste Approved by: markj (mentor) Fixes: 8c9c3144ccfa3061879b8cec015ee7d1010e4766 Differential Revision: https://reviews.freebsd.org/D53250 --- sys/arm64/arm64/elf32_machdep.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sys/arm64/arm64/elf32_machdep.c b/sys/arm64/arm64/elf32_machdep.c index 8f8a934ad520..4cb8ee5f57ef 100644 --- a/sys/arm64/arm64/elf32_machdep.c +++ b/sys/arm64/arm64/elf32_machdep.c @@ -210,7 +210,7 @@ freebsd32_fetch_syscall_args(struct thread *td) sa->code = *ap++; nap--; } else if (sa->code == SYS___syscall) { - sa->code = ap[1]; + sa->code = ap[_QUAD_LOWWORD]; nap -= 2; ap += 2; }