From nobody Tue Oct 21 19:46:53 2025 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4crjVQ1TtDz6CsGl; Tue, 21 Oct 2025 19:46:54 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R12" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4crjVQ0z42z3qKS; Tue, 21 Oct 2025 19:46:54 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1761076014; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=yVCFDYPVWiIHEaJRa3gWbUv6m3LlAbxCs6U7BWOPOX0=; b=dS9wsmBBwGhpSZd2aW0s/ZQf5V10clfcf2TjV+bqFpsnBpBYXH92gSWPoEcJlwrroeiN6k fJfngCk2Qh61W49BAC5gWNbXhUuvCHPeRuyFoPRnBiczbFGXfRLjbmVi/ZqvxFJan1LICr GLuzkeutASNw+Jx29tR5BjWFxjs8zTCE0JS20Whyh6xHGLqCaqdYXYX2CsBv8n65B+etLD sniy3CgUVf0/7ne3M3acvfgUhjWIS2SYcqRIvagM5YdozEt0oDUFoMyHMcLfa3m3J7Ep9o LNW523MRsjhJPSeIw4KgU7KOm8BMj3RNb6zrM5AF5NEyRwas5w3EMsvJ5A1gvg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1761076014; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=yVCFDYPVWiIHEaJRa3gWbUv6m3LlAbxCs6U7BWOPOX0=; b=J6GmUqwAniZJis15KWcssb0Bvr3/wRuQB/+eHjKUw1Ruz5AxtEkUQOTj2WJ0sdA0FQ7Csp OWi9fPUlinIUIimRcWVCUCaiEfh0IRF3Fwqh0pw5WriPUt2jDPvV/RfsVDA4Hk5xH5n2eY WEo876UtWzJJduO0iPKM6Fyj2UmygLnByEDxvxj1S/KI9gKhYWbMy9C6AzLLoIidGd4fLc St7iRWOcnn/1bwh01H9qhtc2aPX5bTqVcHNHx8Y5Jkcw0TllLZKwGB2cErQcevQxNn756N zOf2jRxe/XcbHK+yXXUGI9pBSNrBPZikjeZyEo1SRA9YHqyEeeobe11lvlPtgA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1761076014; a=rsa-sha256; cv=none; b=xjrAAeunfxAPALByVQw1IvHBjxzupdRpVVPR8bGw/md+v9hiVUJySsx4z9l++zjOec3lIB gWGZE0nQobOxxuPxohx5g2SlooB+ZQx8KdH8Sm6q6cvy1sdI0eA29otnhFypvstymuowHP nC0r62S6ZYD78MBaQ+6DSR51QX7GIimxIBof+qmRwtatP1NMlsoXiM8dvjzu/wN+fUKa9k 6xKZq9QR4JZmeWGaExEaUOPleRdq067ojHMzgmwbNAL5VkUAnyFn32HLBUawwh9XRNUynx LJ94W2na2EsPsj8zjJZe68R+BCzSsQjSuPYggCgBUHWXu+WUWWw6vYKIg/gEtw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4crjVQ0J7kz1C5s; Tue, 21 Oct 2025 19:46:54 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 59LJkr27055617; Tue, 21 Oct 2025 19:46:53 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 59LJkrNa055614; Tue, 21 Oct 2025 19:46:53 GMT (envelope-from git) Date: Tue, 21 Oct 2025 19:46:53 GMT Message-Id: <202510211946.59LJkrNa055614@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Alan Somers Subject: git: 7648d2ebda22 - main - tests/sys/netpfil/pf/sctp: make use of required.kmods List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: asomers X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 7648d2ebda22fe21ed385cc7d76813a1a9c17c99 Auto-Submitted: auto-generated The branch main has been updated by asomers: URL: https://cgit.FreeBSD.org/src/commit/?id=7648d2ebda22fe21ed385cc7d76813a1a9c17c99 commit 7648d2ebda22fe21ed385cc7d76813a1a9c17c99 Author: Alan Somers AuthorDate: 2025-10-20 13:52:41 +0000 Commit: Alan Somers CommitDate: 2025-10-21 19:46:26 +0000 tests/sys/netpfil/pf/sctp: make use of required.kmods This greatly speeds up skipping a test that can't be run. MFC after: 2 weeks Sponsored by: ConnectWise Reviewed by: kp Differential Revision: https://reviews.freebsd.org/D53215 --- tests/sys/netpfil/pf/sctp.sh | 18 +++++++++++------- 1 file changed, 11 insertions(+), 7 deletions(-) diff --git a/tests/sys/netpfil/pf/sctp.sh b/tests/sys/netpfil/pf/sctp.sh index 78055f5a9dd2..47bf40181b1b 100644 --- a/tests/sys/netpfil/pf/sctp.sh +++ b/tests/sys/netpfil/pf/sctp.sh @@ -29,9 +29,6 @@ sctp_init() { pft_init - if ! kldstat -q -m sctp; then - atf_skip "This test requires SCTP" - fi } atf_test_case "basic_v4" "cleanup" @@ -39,6 +36,7 @@ basic_v4_head() { atf_set descr 'Basic SCTP connection over IPv4 passthrough' atf_set require.user root + atf_set require.kmods sctp } basic_v4_body() @@ -112,6 +110,7 @@ basic_v6_head() { atf_set descr 'Basic SCTP connection over IPv6' atf_set require.user root + atf_set require.kmods sctp } basic_v6_body() @@ -186,6 +185,7 @@ reuse_head() { atf_set descr 'Test handling dumb clients that reuse source ports' atf_set require.user root + atf_set require.kmods sctp } reuse_body() @@ -244,6 +244,7 @@ abort_v4_head() { atf_set descr 'Test sending ABORT messages' atf_set require.user root + atf_set require.kmods sctp } abort_v4_body() @@ -302,6 +303,7 @@ abort_v6_head() { atf_set descr 'Test sending ABORT messages over IPv6' atf_set require.user root + atf_set require.kmods sctp } abort_v6_body() @@ -360,6 +362,7 @@ nat_v4_head() { atf_set descr 'Test NAT-ing SCTP over IPv4' atf_set require.user root + atf_set require.kmods sctp } nat_v4_body() @@ -412,6 +415,7 @@ nat_v6_head() { atf_set descr 'Test NAT-ing SCTP over IPv6' atf_set require.user root + atf_set require.kmods sctp } nat_v6_body() @@ -464,6 +468,7 @@ rdr_v4_head() { atf_set descr 'Test rdr SCTP over IPv4' atf_set require.user root + atf_set require.kmods sctp } rdr_v4_body() @@ -531,6 +536,7 @@ pfsync_head() { atf_set descr 'Test pfsync-ing SCTP connections' atf_set require.user root + atf_set require.kmods carp sctp } pfsync_body() @@ -563,10 +569,6 @@ pfsync_body() sctp_init pfsynct_init vnet_init_bridge - if ! kldstat -q -m carp - then - atf_skip "This test requires carp" - fi j="sctp:pfsync" @@ -722,6 +724,7 @@ timeout_head() { atf_set descr 'Test setting and retrieving timeout values' atf_set require.user root + atf_set require.kmods sctp } timeout_body() @@ -753,6 +756,7 @@ related_icmp_head() { atf_set descr 'Verify that ICMP messages related to an SCTP connection are allowed' atf_set require.user root + atf_set require.kmods sctp } related_icmp_body()