From nobody Sat Oct 18 12:05:33 2025 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4cpgPT4Cp4z6D390; Sat, 18 Oct 2025 12:05:33 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R12" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4cpgPT3WlFz3CZc; Sat, 18 Oct 2025 12:05:33 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1760789133; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=DHjZsCHBHIqiY2+w14F7jTK+0OTjS7hBfw/wPI+v58g=; b=ROunG9pWDK13u6uvM9eUdWoQA+5bOyciiVFRX523OMAN78aX72ppeY3QowniS7jLpB33sp AtBYO8bo8vtB6ynClRtdavf5TqDVp+M6++LQAGSv9QLbUE9nZ1J61QGgnEzlV9i39Fhl2z Lq/wTPIeTFDhjF0CsDzgvPhUKYrtzOaDefPgRemXVsk/JAlFrA7I/erlo17Lwfb/ETyUDa gVsJ7lE51754Z1u5CRjc92B5Ate6Cdux7lNb4Bve2bb9dIP140xBy8msUzenUcuuu+neKb 4QjOqg7vfKvrED/XhtZKieMdWXEsYfLPIpoz/+GQcB6J5B1wEdieeg2u2kHi9w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1760789133; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=DHjZsCHBHIqiY2+w14F7jTK+0OTjS7hBfw/wPI+v58g=; b=brxXIS1iDsu6tt60dR7cGounKYwMc3aN66BXGnb5zOeBQKoIt/ipP7314WlWlNeoqI+ueq n9+drnpfFwWX00eO1fnUYtOA+69XxpPmklt4wIJe8Bpko6GLIJaC2vqmca/jrC4BdEQLA+ IVzr+Rf/R2x5ZE0YcrgmiwfcuLrOU3QVZ+KYMzw1HQ9Tgu5tey5k+leTF+OeXK5PH/nzHC Ov5nBqbbTXHQS/XkKrFaoZ8YdBFphX/4eMo3C1ihYlIsEb+yEhgXQ4CdBuoAZ9kEt8Ine4 XK2GKsa263kbID2jrMGZivzcfEos1T2d4Yj6cEwskuM/Ras5LGCGSitoHlggMw== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1760789133; a=rsa-sha256; cv=none; b=lHLHiGyjGwaRLU1DL8KUGHQKM5XP8KmwP/xcGHXSSoG3uDGRq86aezClaLMoWRNpOapZ7q fy4WxmrxL5iOf/CrYqYq8ODTsLyvaOmENCWqWktIdkkHsgVj8pG14i/Y8tkGdyMjrlBysU iSiI7A9wQhfza0bfCSl/eQp1KV0O+OhnZDMvb5zkNQFFml+oGZ5+wA9t5m/60LooTJxGcm Behq0DY+g728D+At14JnmsUv4kE7YkKlyO5kucGd6om2Sdab5G4oL0zf+VZIS0HejC+oLH Ovbs/zrAeowWO4BvgM4ff/FQE+7f10yr6bf8WCLddgOdg6/beU0+6/JNA4HpyQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4cpgPT2c3zzgwR; Sat, 18 Oct 2025 12:05:33 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 59IC5XGl032986; Sat, 18 Oct 2025 12:05:33 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 59IC5X4q032983; Sat, 18 Oct 2025 12:05:33 GMT (envelope-from git) Date: Sat, 18 Oct 2025 12:05:33 GMT Message-Id: <202510181205.59IC5X4q032983@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: "Andrey V. Elsukov" Subject: git: 317a5dd0288e - stable/15 - ipfw: do not use errno value for error reporting List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: ae X-Git-Repository: src X-Git-Refname: refs/heads/stable/15 X-Git-Reftype: branch X-Git-Commit: 317a5dd0288e0382fc94ab44cc7b0a7918e7fe62 Auto-Submitted: auto-generated The branch stable/15 has been updated by ae: URL: https://cgit.FreeBSD.org/src/commit/?id=317a5dd0288e0382fc94ab44cc7b0a7918e7fe62 commit 317a5dd0288e0382fc94ab44cc7b0a7918e7fe62 Author: Boris Lytochkin AuthorDate: 2025-10-14 08:02:20 +0000 Commit: Andrey V. Elsukov CommitDate: 2025-10-18 12:04:42 +0000 ipfw: do not use errno value for error reporting table_do_modify_record() already uses errno value on error. Also this fixes problem when `ipfw table add` returns ENOTTY that is unrelated to operation. Tested by: dhw Fixes: 09025a714708 Differential Revision: https://reviews.freebsd.org/D53050 (cherry picked from commit dfd822b1f0846bdaa9a14457346f7431a86d3a64) --- sbin/ipfw/tables.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/sbin/ipfw/tables.c b/sbin/ipfw/tables.c index 7c3b1bb35a01..245c0c9e0399 100644 --- a/sbin/ipfw/tables.c +++ b/sbin/ipfw/tables.c @@ -1037,9 +1037,6 @@ table_modify_record(ipfw_obj_header *oh, int ac, char *av[], int add, } } - /* Get real OS error */ - error = errno; - /* Report results back */ ptent = tent_buf; for (i = 0; i < count; ptent++, i++) {