From nobody Tue Oct 14 13:51:26 2025 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4cmFxV5QHgz6CTPf; Tue, 14 Oct 2025 13:51:26 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R12" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4cmFxV2d0Fz3Sxb; Tue, 14 Oct 2025 13:51:26 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1760449886; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=PBB1XLxcamJTqq3G7B8gP6fO015DLACkRhZH/8G6USc=; b=Ga4QrLhALJgz1164ePxSkdgmnbEX2AyFBd4TnlND4cUEdCgsSVbY8sjLC39I0AimFqMU8V ifrj/Dxbp1tt/TwfV74AiEUbrOo/Vs8iwfYDzvwsP1g3FZ4BGWmK434R7uGlPM1hpiw2qT edkGrS9qwasT64rZfCqUaLcuqsmVIrqvoU7DfU4OLg2DUxN9QJHO4XtJyX+B5q+TuxgeUw FVtavObOcs4Tr9TcgeOOMKCv1ta2EHgNyouGbkLg9OHaOEOdmdSqDxw6u6yWB47FTZqr6S Ds4acPwqxd6wBGl3vsaKuhSHcfzSt3yp0wkxfwacaAkfmCpBjnGwEiA9qu06ow== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1760449886; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=PBB1XLxcamJTqq3G7B8gP6fO015DLACkRhZH/8G6USc=; b=ECi7/dla2nsGGnID2M2erE7aUXi/Qh9aBXcw6DaQy6JusLUJhKk7gyVHmiFLFJZNrEQr9C P1hLWQkk8j/BqzCOfIQDTmNGY8SeZUz2vzTLqwdyi9TOFoaEsy19wayZ3DeG8zZ8tiF2oC MyMS1IYtM8l3vvra5OEAuOXV6U5fwsyFexAzyPTbE0sBdneSMSh6lLkobPMLjlFyVWZJWU DNlJvj6VdZ0CRJ/XfEz8W+70jIiTzY9BpqLjV65+CDrNcxwk5nR35Iej93DHBSMQ4IRvlB c7PGYPNA1t+b6Nmuk3Bf2/nausaGnxgcyBVL2PscM1CiVhZ+ojpQ+fbI0CEu1A== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1760449886; a=rsa-sha256; cv=none; b=Vq9shLeX1LAislZ7F3OuFoTdLCF0be5z3CZhJedtrSEAv9e7ZWQaEZ9E62lPcoxzbCdDsN blNHHeqCkc2maF/jI2n4JwluKx0foEGpfqHCC0NzVpL1lvkj+pnHZ47hiFPxjvt6eUcZDE nc/qZcAk7fM57Mt7tZ0w4cIc1KajhdPtv0J9up4DEFXTMDcU/0ta/HpwJ6QmKBSrFvicfE sHtLL/3ihgebxnRakln26iMFKgSzyX+kmsobNdD5n+By2/MnSOJfRLUVwfcPHdQvxoKa6C 6eNuiVsZWkQsUu9CsNKVs6M3FwPnbsKQaS7gyzkZSd3WZmcy07iE9f9j66JhQg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4cmFxV1m7xzvdk; Tue, 14 Oct 2025 13:51:26 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 59EDpQFl083235; Tue, 14 Oct 2025 13:51:26 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 59EDpQ4P083232; Tue, 14 Oct 2025 13:51:26 GMT (envelope-from git) Date: Tue, 14 Oct 2025 13:51:26 GMT Message-Id: <202510141351.59EDpQ4P083232@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Mark Johnston Subject: git: 7117c86fcb7e - main - exec: Check for errors when mapping the shared object List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: markj X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 7117c86fcb7ebee4483097cefa9b143de8d78ee0 Auto-Submitted: auto-generated The branch main has been updated by markj: URL: https://cgit.FreeBSD.org/src/commit/?id=7117c86fcb7ebee4483097cefa9b143de8d78ee0 commit 7117c86fcb7ebee4483097cefa9b143de8d78ee0 Author: Mark Johnston AuthorDate: 2025-10-14 13:33:33 +0000 Commit: Mark Johnston CommitDate: 2025-10-14 13:41:20 +0000 exec: Check for errors when mapping the shared object In the non-ASLR case, there is no check for an error from vm_map_fixed(). Restore it, it was dropped in commit 939f0b6323e0a. This bug could result in a refcount leak of the object used to map the VDSO page. Reviewed by: kib Reported by: Ilja Van Sprundel MFC after: 1 week Fixes: 939f0b6323e0 ("Implement shared page address randomization") Differential Revision: https://reviews.freebsd.org/D53065 --- sys/kern/kern_exec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sys/kern/kern_exec.c b/sys/kern/kern_exec.c index 70a9a419a674..2bdd6faa025a 100644 --- a/sys/kern/kern_exec.c +++ b/sys/kern/kern_exec.c @@ -1314,7 +1314,7 @@ exec_map_stack(struct image_params *imgp) MAP_INHERIT_SHARE | MAP_ACC_NO_CHARGE); } else { sharedpage_addr = sv->sv_shared_page_base; - vm_map_fixed(map, obj, 0, + error = vm_map_fixed(map, obj, 0, sharedpage_addr, sv->sv_shared_page_len, VM_PROT_READ | VM_PROT_EXECUTE, VM_PROT_READ | VM_PROT_EXECUTE,