From nobody Tue Oct 14 08:14:55 2025 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4cm6TC3l31z6C0p1; Tue, 14 Oct 2025 08:14:55 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R12" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4cm6TC3DlXz3k02; Tue, 14 Oct 2025 08:14:55 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1760429695; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=PnkIOttKsq2/ewUkygNMQKeC8DoIKZCH6IbzDwkxo8g=; b=FlZ+KCMH0lplwQiksZk59KuOBlT12H+EvNRbZpkPzsfzCi2XkT1jwQjrc824YTUdBOs2P7 Me4L4XTvMrpZDJrCdJK/B56NAqtDXVtR3kXTK3kWsrBymHo0yqwPUCvd4VCTz9cflPTj2u f0LVXC4Hi3o9bRtLorEsOWc3jSpOdXRFaFuN0Q1SRUVLjdtEWxblOSiASFSzhtvgx05N01 x8rXTUhDlR6fSrED8EL20s3byweF2cOILYmmfUtIcB4WJ4MsESzHXzZYVVdtTO14aHRVfZ RLzFD3mwoYU9tkh7zsqUeKyRTF5sXjQjyv+ou7F88uYsE6AfWgoQsTx+SYU3Hw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1760429695; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=PnkIOttKsq2/ewUkygNMQKeC8DoIKZCH6IbzDwkxo8g=; b=w3OqrLeG71MaZUGOSHadAJI2OcK0H52kDL4TzFctMJ9SEiy5Cp6Xy5U5eFQ7I5hXDoZlpi WigGDcwxE9RVV+UeCj2WRhOdtIMptQ0w2iQshDtrLcLGgHBhEYTzP3I3sQfvNfdRdxcK9X rjlAruKt2PWm1rTom66JlBOwSTbrT/SJ2YbjtxnTVXoh2Hk8DxTSrCX7iDmtTw/GyGmfOa PEb+wLn27d+HPldV2HZx/kXUpRm/Q/1uDJ8piYrbP5o+UjJ5Eqb9tDjWpH2S+w+hbdjjIH VsOY0zfNTK1Nth0G91v11AAJxoJivAphVZibl9v38q4si7WILaKtNCfsW+bXAA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1760429695; a=rsa-sha256; cv=none; b=qnmqPoWlZkje/OVlDyEarY+xbBV+39Mpwu/GsYouvrq2qOJOkDt2Q9F1SVqh+JJgHpmgtT FxbL2cuCoyBcaep4EqcpId+yVjUpKBsGgIaAMhBj+uVEo8XcC3UykYg86pwrCSFK7pEwLA 0kQjIuu9qjlfsbekg6Hs+Jjy15M3cVRxWlXYTWVzCItgrwugZDKRbiHZaedFL/mPbDZPjI roxlS5RUryWrzH3LoVZEbJGuME+GX1PAC93807YTBhXpeVoFUHM50/yrYOH/RiFDMIgwfV +c6aioL7gWNz3mWCXTbrziq4V+IFF9Lowa/LyRaKLDD5UNOwKDNLjk0/xgfDnw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4cm6TC2qvLzlPd; Tue, 14 Oct 2025 08:14:55 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 59E8Et8g050401; Tue, 14 Oct 2025 08:14:55 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 59E8EtEl050398; Tue, 14 Oct 2025 08:14:55 GMT (envelope-from git) Date: Tue, 14 Oct 2025 08:14:55 GMT Message-Id: <202510140814.59E8EtEl050398@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: "Andrey V. Elsukov" Subject: git: dfd822b1f084 - main - ipfw: do not use errno value for error reporting List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: ae X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: dfd822b1f0846bdaa9a14457346f7431a86d3a64 Auto-Submitted: auto-generated The branch main has been updated by ae: URL: https://cgit.FreeBSD.org/src/commit/?id=dfd822b1f0846bdaa9a14457346f7431a86d3a64 commit dfd822b1f0846bdaa9a14457346f7431a86d3a64 Author: Boris Lytochkin AuthorDate: 2025-10-14 08:02:20 +0000 Commit: Andrey V. Elsukov CommitDate: 2025-10-14 08:02:20 +0000 ipfw: do not use errno value for error reporting table_do_modify_record() already uses errno value on error. Also this fixes problem when `ipfw table add` returns ENOTTY that is unrelated to operation. Tested by: dhw Fixes: 09025a714708 MFC after: 3 days Differential Revision: https://reviews.freebsd.org/D53050 --- sbin/ipfw/tables.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/sbin/ipfw/tables.c b/sbin/ipfw/tables.c index 7c3b1bb35a01..245c0c9e0399 100644 --- a/sbin/ipfw/tables.c +++ b/sbin/ipfw/tables.c @@ -1037,9 +1037,6 @@ table_modify_record(ipfw_obj_header *oh, int ac, char *av[], int add, } } - /* Get real OS error */ - error = errno; - /* Report results back */ ptent = tent_buf; for (i = 0; i < count; ptent++, i++) {