git: 488718ff4234 - main - netlink: in snl_init_writer() don't overwrite error in case of failure
- Go to: [ bottom of page ] [ top of archives ] [ this month ]
Date: Tue, 07 Oct 2025 05:49:02 UTC
The branch main has been updated by glebius:
URL: https://cgit.FreeBSD.org/src/commit/?id=488718ff42346888243496c00cbeb42ba004171e
commit 488718ff42346888243496c00cbeb42ba004171e
Author: Bruno Silvestre <bruno.silvestre@gmail.com>
AuthorDate: 2025-10-07 05:48:28 +0000
Commit: Gleb Smirnoff <glebius@FreeBSD.org>
CommitDate: 2025-10-07 05:48:28 +0000
netlink: in snl_init_writer() don't overwrite error in case of failure
PR: 290050
---
sys/netlink/netlink_snl.h | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/sys/netlink/netlink_snl.h b/sys/netlink/netlink_snl.h
index 6dd8a9cbdb35..57f7e1e29d08 100644
--- a/sys/netlink/netlink_snl.h
+++ b/sys/netlink/netlink_snl.h
@@ -1068,14 +1068,14 @@ snl_init_writer(struct snl_state *ss, struct snl_writer *nw)
{
nw->size = SNL_WRITER_BUFFER_SIZE;
nw->base = (char *)snl_allocz(ss, nw->size);
- if (nw->base == NULL) {
+ if (__predict_false(nw->base == NULL)) {
nw->error = true;
nw->size = 0;
- }
+ } else
+ nw->error = false;
nw->offset = 0;
nw->hdr = NULL;
- nw->error = false;
nw->ss = ss;
}