From nobody Sat Nov 22 14:53:33 2025 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4dDFT93yGhz6HGBq for ; Sat, 22 Nov 2025 14:53:33 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R12" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4dDFT92hQcz472D for ; Sat, 22 Nov 2025 14:53:33 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1763823213; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=yq2jv7olUlfoWA01tDHUs4afH2sjXa5K8Snmw9xhs3k=; b=rqw6SGFsYXKWmiIM9H/bZNUC8en46by2NzXIcwJrX9ObZ7ootYi2Ghhta8PKMtV+6ldqbr Vv8x/onwDCF4bNYVqcTv8Tx78IiyEZFW4dGYdYCnjHSlhblFFwX040AAfKUeX85WIoqQOC G8Ky2xUh2rmFSf3LaQWomffXWDaebeOqDaX8E19Re0cmP+38/utCr8iUFZ5Ovy+PvAIRoD CzYkjmfVkCnWd2oh8IFZWaj5a9kFmYCwGPo89l9qvxjsrbW0GvuXJ2ozKvR2tsTM/uIk3R kkaNu2yv4ERryr6mKBg9hPjCpe24mxfxcYk/69ejJ5m2kCqqZtKkRdNGJGqkvw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1763823213; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=yq2jv7olUlfoWA01tDHUs4afH2sjXa5K8Snmw9xhs3k=; b=cLhuEnR8BHw2kE0NI5PXiWbZr87MxMddx2n/DHcUA7VB+LQ4sg5KLwf5p/fdYliF+28dKo JxKUr6k6ALQhwYOySykBnC8OuZz1knOt+aOucrpiKJPzh0vCJmUElMo5EtuSqvenegbN+7 TMPKGy8FBvGsL3wN7lXghVqZElz9sn99LESP2JitndP0BkgzYNrueEewe7CasCfiXlrVCH iQsXrevJHl8evbfWSGzp1VDtwl60osKO1RoUwtHKJFJ94ifY/Pc4sAfD4McCq73UWIum2q O7Wd5PVRuYeuxbfVfi5Scc2rBeEKa/ff2g2a6+p/ZPwg4C3MKv6SyOkHsz/DyA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1763823213; a=rsa-sha256; cv=none; b=OYgeT7feDr6KZclgfor6rDMCfHsivl4CZnUw0QhPBZ97b6FKdoxbT1km7IweLht7qrmnlG qKtxFP00VzBDEVatSvqANnos6P3+SaQ33w3AlR6qebgS4P61tWaD/u98Ie40kuiZ/MrmJE laKEzyqRPgZT8dtCjTPc3EglTRXHdjfzI7EOmA0DyC2j2aqbA9J4DDcE1PQItfPmfFe/6v o+CkpRqUbRA8XgGyFaRkWf3/ws16pjQjhnKUw1EknYdzH0bQUxRhxXANcnyHIlg7sdbTEx MlL+5jTCdipeK9D0QvcaxhLc3ONvzUI8BejH828MfMmRZdrIBAW3yqMO3S4nHA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4dDFT924WZz12WH for ; Sat, 22 Nov 2025 14:53:33 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 31444 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Sat, 22 Nov 2025 14:53:33 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Alan Somers Subject: git: e53590238a3d - stable/14 - fusefs: fix intermittency in the BadServer.ShortWrite test List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: asomers X-Git-Repository: src X-Git-Refname: refs/heads/stable/14 X-Git-Reftype: branch X-Git-Commit: e53590238a3dd39c9620100276c4633feb43de01 Auto-Submitted: auto-generated Date: Sat, 22 Nov 2025 14:53:33 +0000 Message-Id: <6921ce6d.31444.534743f1@gitrepo.freebsd.org> The branch stable/14 has been updated by asomers: URL: https://cgit.FreeBSD.org/src/commit/?id=e53590238a3dd39c9620100276c4633feb43de01 commit e53590238a3dd39c9620100276c4633feb43de01 Author: Alan Somers AuthorDate: 2025-10-14 02:18:48 +0000 Commit: Alan Somers CommitDate: 2025-11-22 14:52:54 +0000 fusefs: fix intermittency in the BadServer.ShortWrite test This test implicitly depended on the order in which two threads completed. If the test thread finished first, the test would pass. But if the mock file system thread did, it would attempt to read from an unmounted file system, and fail. As a result, the test would randomly fail once out of every several thousand executions. Fix it by telling the mock file system's event loop to exit without attempting to read any more events. Reported by: Siva Mahadevan Reviewed by: Siva Mahadevan Differential Revision: https://reviews.freebsd.org/D53080 (cherry picked from commit d1bd541b385d49d2ae3a8bad9df72779b606e208) --- tests/sys/fs/fusefs/bad_server.cc | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/tests/sys/fs/fusefs/bad_server.cc b/tests/sys/fs/fusefs/bad_server.cc index af2ca146e431..c3d195735446 100644 --- a/tests/sys/fs/fusefs/bad_server.cc +++ b/tests/sys/fs/fusefs/bad_server.cc @@ -65,6 +65,11 @@ TEST_F(BadServer, ShortWrite) out.header.unique = 0; // Asynchronous notification out.expected_errno = EINVAL; m_mock->write_response(out); + /* + * Tell the event loop to quit. The kernel has already disconnected us + * because of the short write. + */ + m_mock->m_quit = true; } /*