From nobody Sat Nov 22 14:30:58 2025 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4dDDz63FG4z6HDSC for ; Sat, 22 Nov 2025 14:30:58 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R12" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4dDDz612f6z40xg for ; Sat, 22 Nov 2025 14:30:58 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1763821858; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=wswTZR3n95kjN86pDJhpecvqfkF6pLo6KvVdFCKdS/M=; b=CxF7QgOLaVvS89P6UdVcy+8qKLBXsF5XBZDsL+S7jkR0ntlWy+VGJl0WKoZt61GGNjuk3O r4uj45Uy428P4IAEc/FP1KgDBElV+MToTRqvBrUu9sw7a4HU6Crwh5Hmk6FY/lOTknTIWA 13vm8h26QkNO6yBUnRJpXWy8h0V4SL7+YVED4c/k1KCfu/mJe405zkThcCEWfunINH9tuN sMrlZfZJDXAjlUlcB6LFJZIWYHPypZHFmWaTG8i3gW4eD4at2IdV2/jrWTNuEkmISfgglp /8pO5FFMoBW1yWDMnpbJm+NlixH65qIOvvTkP9xna8LQMtPpgPX4+NCXfajjrg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1763821858; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=wswTZR3n95kjN86pDJhpecvqfkF6pLo6KvVdFCKdS/M=; b=PMwU90aDR5mZuzMkAbX2NedPcznMxb5EPEDqurbCVLNgYe8YdqLzM0M/hxf7a4IDz0vKP1 /rcLPI77mfackp7gFZGdZUJSozoSazSVAptQUgpDLW8YZJ5Isj33gAPRsg3jh+Vp0wr0tn zU1jPDizgee4QqCtVs99mP6hiLXX2mM0oh9elF9rXpkv4kYwk4epHsNzSOX6+TPITg3ynr 0jLvXHu0at0s4AFk1d93FryXGz5ES5k3xkR1W1nG20XjIcCcqL0WvfW09v0PaNvd81mKc+ H6rv6tKc39NITwx89wcFJ2/FWjOTivPxQWVwQ+e2c8UMLP3pw/Nq1LigXrhEtw== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1763821858; a=rsa-sha256; cv=none; b=CfK7qZ4ViB4g4dDoGvSzM7N+/WRzCt9/q8SKfPcaQ/ux748lbNwBU8Qjahr4u7zeYi3sTE 2PLhY+C9X6/JZ2xHu3BRuwgbxxMXMcKs0JaLAqbmaYoq1DYnP/MMB+KjRXrELs+EGUWFOh ICN3BaCcDXLp0RPPTKmaM3jTEJQnQ/B9srZ/iH2Jw4kbYLzqJxln+rQpT7s1mZKeaHQxaD DduQfCno5qXWoqzDO3xWeRQWG9fWn+yqhGi9xi1OgRlKbLDbHIHcrbJVaaf2B0aEV0kDvt +QU9+qJ3vhRjNzuzjSghqANxPvdWvfjZScZC866peHJfS1l8dx8b0+6Ed6JJMg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4dDDz60F98z128T for ; Sat, 22 Nov 2025 14:30:58 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 30a74 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Sat, 22 Nov 2025 14:30:58 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Andrew Gallatin Subject: git: e07b4a2e9bc4 - main - e1000: use newly exposed RSS hash key API rather than ad-hoc hashing List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: gallatin X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: e07b4a2e9bc4f6b2e129f3a101dfce2027694bd3 Auto-Submitted: auto-generated Date: Sat, 22 Nov 2025 14:30:58 +0000 Message-Id: <6921c922.30a74.4faaae18@gitrepo.freebsd.org> The branch main has been updated by gallatin: URL: https://cgit.FreeBSD.org/src/commit/?id=e07b4a2e9bc4f6b2e129f3a101dfce2027694bd3 commit e07b4a2e9bc4f6b2e129f3a101dfce2027694bd3 Author: Andrew Gallatin AuthorDate: 2025-11-22 14:29:33 +0000 Commit: Andrew Gallatin CommitDate: 2025-11-22 14:29:33 +0000 e1000: use newly exposed RSS hash key API rather than ad-hoc hashing Differential Revision: https://reviews.freebsd.org/D53097 Reviewed by: kbowling Sponsored by: Netflix --- sys/dev/e1000/em_txrx.c | 2 -- sys/dev/e1000/if_em.c | 4 ---- sys/dev/e1000/if_em.h | 2 -- sys/dev/e1000/igb_txrx.c | 2 -- 4 files changed, 10 deletions(-) diff --git a/sys/dev/e1000/em_txrx.c b/sys/dev/e1000/em_txrx.c index ced8d0f41d14..647255417b3e 100644 --- a/sys/dev/e1000/em_txrx.c +++ b/sys/dev/e1000/em_txrx.c @@ -29,10 +29,8 @@ #include "if_em.h" -#ifdef RSS #include #include -#endif #ifdef VERBOSE_DEBUG #define DPRINTF device_printf diff --git a/sys/dev/e1000/if_em.c b/sys/dev/e1000/if_em.c index 02f4c431badd..bc841ba87ceb 100644 --- a/sys/dev/e1000/if_em.c +++ b/sys/dev/e1000/if_em.c @@ -3415,12 +3415,8 @@ igb_initialize_rss_mapping(struct e1000_softc *sc) */ mrqc = E1000_MRQC_ENABLE_RSS_MQ; -#ifdef RSS /* XXX ew typecasting */ rss_getkey((uint8_t *) &rss_key); -#else - arc4rand(&rss_key, sizeof(rss_key), 0); -#endif for (i = 0; i < 10; i++) E1000_WRITE_REG_ARRAY(hw, E1000_RSSRK(0), i, rss_key[i]); diff --git a/sys/dev/e1000/if_em.h b/sys/dev/e1000/if_em.h index 582e8d9c6327..4c80c7696952 100644 --- a/sys/dev/e1000/if_em.h +++ b/sys/dev/e1000/if_em.h @@ -72,10 +72,8 @@ #include #include #include -#ifdef RSS #include #include -#endif #include #include diff --git a/sys/dev/e1000/igb_txrx.c b/sys/dev/e1000/igb_txrx.c index 568d84807173..46fe5c741055 100644 --- a/sys/dev/e1000/igb_txrx.c +++ b/sys/dev/e1000/igb_txrx.c @@ -28,10 +28,8 @@ #include "if_em.h" -#ifdef RSS #include #include -#endif #ifdef VERBOSE_DEBUG #define DPRINTF device_printf