From nobody Sat Nov 22 09:29:06 2025 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4dD6Jf2VGKz6GlFD; Sat, 22 Nov 2025 09:30:42 +0000 (UTC) (envelope-from herbert@gojira.at) Received: from mout-p-201.mailbox.org (mout-p-201.mailbox.org [IPv6:2001:67c:2050:0:465::201]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4dD6Jd12rRz3C4J; Sat, 22 Nov 2025 09:30:41 +0000 (UTC) (envelope-from herbert@gojira.at) Authentication-Results: mx1.freebsd.org; dkim=pass header.d=gojira.at header.s=MBO0001 header.b=MjKm9H47; dmarc=none; spf=pass (mx1.freebsd.org: domain of herbert@gojira.at designates 2001:67c:2050:0:465::201 as permitted sender) smtp.mailfrom=herbert@gojira.at Received: from smtp2.mailbox.org (smtp2.mailbox.org [IPv6:2001:67c:2050:b231:465::2]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-p-201.mailbox.org (Postfix) with ESMTPS id 4dD6JM2RhWz9t5Y; Sat, 22 Nov 2025 10:30:27 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gojira.at; s=MBO0001; t=1763803827; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=71KtD0mlLT0B9UwLqKCPefXBdnmrB1SS1DBJ7p8GTtQ=; b=MjKm9H47e1SY0sxeoaKCmbm4viK/WX3pvUJWVfkAqayEscaHVSHJ5NUMHUth73IMrslIWp 8c1Eo3jQAPKSgN6M3QayiS6cFTlT9oePXu318fu87q+zQDaAhOJ5dRN0r1QGKagfOSNyhj mmW2/De2VRUfSf1/AQLjp03F3CIPbC4WzFPknhIRdHjM9OUUcmYWcxuFRNWoRXDZRVjWt1 2KtIRVMRQyeq53fCyBpay/bUSjTbH5bELUZjylV8K9imiRIQds1RC8YiWnUeCzqksogNnx xI5W3f+deaksizoul1vDMvPJkMYRsc5zBTU/OzidYiteMJSTCLpZWhi8I99Bxw== Date: Sat, 22 Nov 2025 10:29:06 +0100 Message-ID: <87see62z6l.wl-herbert@gojira.at> From: "Herbert J. Skuhra" To: Andrew Turner Cc: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org Subject: Re: git: a695ac2ce8bc - main - arm64: Move intr_pic_init_secondary earlier In-Reply-To: <691cb4c1.220bb.22f9ecf6@gitrepo.freebsd.org> References: <691cb4c1.220bb.22f9ecf6@gitrepo.freebsd.org> List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-Spamd-Bar: -- X-Spamd-Result: default: False [-2.70 / 15.00]; MID_CONTAINS_FROM(1.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_SHORT(-1.00)[-0.998]; R_SPF_ALLOW(-0.20)[+ip6:2001:67c:2050::/48]; R_DKIM_ALLOW(-0.20)[gojira.at:s=MBO0001]; RCVD_IN_DNSWL_LOW(-0.20)[2001:67c:2050:0:465::201:from,2001:67c:2050:b231:465::2:received]; MIME_GOOD(-0.10)[text/plain]; MISSING_XM_UA(0.00)[]; RCVD_COUNT_ONE(0.00)[1]; RCVD_TLS_ALL(0.00)[]; TO_DN_SOME(0.00)[]; MIME_TRACE(0.00)[0:+]; ARC_NA(0.00)[]; DMARC_NA(0.00)[gojira.at]; MLMMJ_DEST(0.00)[dev-commits-src-all@FreeBSD.org,dev-commits-src-main@FreeBSD.org]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[4]; FROM_EQ_ENVFROM(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; DKIM_TRACE(0.00)[gojira.at:+] X-Rspamd-Queue-Id: 4dD6Jd12rRz3C4J Hi, On Tue, 18 Nov 2025 19:02:41 +0100, Andrew Turner wrote: > > The branch main has been updated by andrew: > > URL: https://cgit.FreeBSD.org/src/commit/?id=a695ac2ce8bc8e8b989359002659063f2e056dcf > > commit a695ac2ce8bc8e8b989359002659063f2e056dcf > Author: Andrew Turner > AuthorDate: 2025-11-18 18:00:32 +0000 > Commit: Andrew Turner > CommitDate: 2025-11-18 18:00:32 +0000 > > arm64: Move intr_pic_init_secondary earlier > > This may have been called after intr_irq_shuffle. For most interrupt > controllers this appears to be safe, however for the GICv5 we need to > read a per-CPU ID register before we can assign interrupts to a given > CPU. > > Fix the race by moving intr_pic_init_secondary earlier in the boot, > after devices have been enumerated and before the interrupts are moved > to their assigned CPUs. > > Sponsored by: Arm Ltd > Differential Revision: https://reviews.freebsd.org/D53685 > --- > sys/arm64/arm64/mp_machdep.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/sys/arm64/arm64/mp_machdep.c b/sys/arm64/arm64/mp_machdep.c > index 0bdd2ecfd8a7..ba673ce9d6ee 100644 > --- a/sys/arm64/arm64/mp_machdep.c > +++ b/sys/arm64/arm64/mp_machdep.c > @@ -270,6 +270,8 @@ init_secondary(uint64_t cpu) > install_cpu_errata(); > enable_cpu_feat(CPU_FEAT_AFTER_DEV); > > + intr_pic_init_secondary(); > + > /* Signal we are done */ > atomic_add_int(&aps_started, 1); > > @@ -288,8 +290,6 @@ init_secondary(uint64_t cpu) > ("pmap0 doesn't match cpu %ld's ttbr0", cpu)); > pcpup->pc_curpmap = pmap0; > > - intr_pic_init_secondary(); > - > /* Start per-CPU event timers. */ > cpu_initclocks_ap(); My ARM64 VPS (KVM/QEMU) only boots if I revert this change.