From nobody Fri Nov 21 20:45:27 2025 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4dCnKm1Ndrz6HkMx for ; Fri, 21 Nov 2025 20:45:32 +0000 (UTC) (envelope-from shawn.webb@hardenedbsd.org) Received: from mail-io1-xd2c.google.com (mail-io1-xd2c.google.com [IPv6:2607:f8b0:4864:20::d2c]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "WR4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4dCnKl5sjgz3sBp for ; Fri, 21 Nov 2025 20:45:31 +0000 (UTC) (envelope-from shawn.webb@hardenedbsd.org) Authentication-Results: mx1.freebsd.org; none Received: by mail-io1-xd2c.google.com with SMTP id ca18e2360f4ac-94861514a5cso92306539f.1 for ; Fri, 21 Nov 2025 12:45:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hardenedbsd.org; s=google; t=1763757929; x=1764362729; darn=freebsd.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=7JgDoej/tCxpYVslowomV5KKfP4jyd+dgZqrE2L1vZ8=; b=WTDBsIEFBsl4Ip/HYAPE7e/Pmb0iYJGD/39RK6UQ66H10sedR4BG8ykJ1RrNDAyFeM K9pEH4K7ZwtGnCzShDlWovueHr/+plzpmHgBS6bLsDHcO8izbAaNy6B5gUjH3iIysw2O 0jdMEafKOG+6nt5tTEWTOk9AU+7xIZi6NIdlRdnAeGpg9WvvzV/YWfTgJTSiCpUAdJHC EvKxaor5Nb9v0ve2tnHDUKcca2BZFpJbOlYmzVde070QPNw8UqRjKWJ2G1tPC5+3eXoC /21gP93Z4ToT6PdmQ94WtkuHFIW232Ug21HNPBXBN7wRYeIq5l6bliCwjrsmj/WCpark PzYA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763757929; x=1764362729; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=7JgDoej/tCxpYVslowomV5KKfP4jyd+dgZqrE2L1vZ8=; b=wCK58llxMs8IjUTI5uWBWQyL0r+31cNh/XPB9p9pXQvtZcvXLgbackm1fyvwRvZF6l MhnknrIB28M4XwfKuYkK730rvIorcnlJRkKbcbIXupell/3OPOWkclcLn8ph6amYmNs5 enJ1C5RUxGytkIzDCaCpQrEcYRF+89l/HJmyYJVDmHvmEuKzHn1MJ71SOlOpvlu5J1j5 M45i3XCCuDaht5NXmKZCzO2PvOUlDdhjZnNDmLVTYIWYPSDEZpfEpq6ZQhUYF83NY0Yh c+5hTJXt5dR6bT+LPIPCmME3HtPnrPCqZrPCYE0uZI1uHoYcVadP6GzWCIdA6Qrdk5vy Av0g== X-Forwarded-Encrypted: i=1; AJvYcCUXvc63P4eB9NBiFTBon9DseS1ZGQc9XgNq/UDj+olwKq00TJtJocAab1pLdMNBI4l7JLgHUh/23s5KTIirNqGmDSuC@freebsd.org X-Gm-Message-State: AOJu0YyDaeCkBL/PLS1BvcJnHePtrhhUMgw1dss3BGwuguttY1eJwu6Z afaD1PKqxJc7ByM39TFm7kbrzluzeeOlbz1BCqpHgZtWR2xqpuedpCh9zM4uNJqxbhk= X-Gm-Gg: ASbGnctLRheTZq+QSZ4y0mEQsNwcYK84n5K8FOmM9aTlNkosv5IFZ5RCQWIXCOSNaLB 1iHjLqO/hSGzQpi2u0Bql/6ItgUi2s6fLSx1lLVJz5wfBeBVnfIwC4gI0IcncEWoCRBj1cerC0E fo/M+elWgHOZOjLf+E9nAaLjaf4WLTqXQyITQSWfLbVJ7zR7B4biNLULYs9ErB2GhfnYq/xl2dN 395KdK24vEB7z8hBjM8e7F6mz0NKhu9MHSvPq0ZSjJnXxrYJGXn9uM0IzrlrshGyrkV/nV81qSV 39cS11lY3cu2wENnoiiAL6wmX2L2vyBPPO/kciaO3UkF1cfm5h/zSxvMVJ2JnLOglNXHHxoKEvU ZM4nWSP1Mz24VpGichyS67PKXVLA1pJzJNyYTLM/c5Qqh5fd3SAKBZ+EjJnMsOUWhP2qU X-Google-Smtp-Source: AGHT+IEaHmezyCRSayPAYNbrn2X95W9ksCTLcJlO/RBe5Y0bfrQW8YVTyAXE1fg4DD0/NTiv1Lc+hQ== X-Received: by 2002:a02:c995:0:b0:5b7:be8e:154f with SMTP id 8926c6da1cb9f-5b967acfc61mr2356926173.19.1763757929215; Fri, 21 Nov 2025 12:45:29 -0800 (PST) Received: from mutt-hbsd ([2001:470:4001:1::95]) by smtp.gmail.com with ESMTPSA id 8926c6da1cb9f-5b954b2122bsm2511397173.29.2025.11.21.12.45.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 21 Nov 2025 12:45:28 -0800 (PST) Date: Fri, 21 Nov 2025 20:45:27 +0000 From: Shawn Webb To: Christos Margiolis Cc: src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: 9d18115ca0ab - main - sound: Retire snd_mtx* wrappers Message-ID: X-Operating-System: FreeBSD mutt-hbsd 14.3-STABLE-HBSD FreeBSD 14.3-STABLE-HBSD HARDENEDBSD-14-STABLE amd64 X-PGP-Key: https://git.hardenedbsd.org/hardenedbsd/pubkeys/-/blob/master/Shawn_Webb/03A4CBEBB82EA5A67D9F3853FF2E67A277F8E1FA.pub.asc References: <69209007.369f8.65e30118@gitrepo.freebsd.org> List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="yomcxtfjbtluxwi5" Content-Disposition: inline In-Reply-To: <69209007.369f8.65e30118@gitrepo.freebsd.org> X-Spamd-Bar: ---- X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US] X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Rspamd-Queue-Id: 4dCnKl5sjgz3sBp --yomcxtfjbtluxwi5 Content-Type: text/plain; protected-headers=v1; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Subject: Re: git: 9d18115ca0ab - main - sound: Retire snd_mtx* wrappers MIME-Version: 1.0 On Fri, Nov 21, 2025 at 04:15:03PM +0000, Christos Margiolis wrote: > The branch main has been updated by christos: >=20 > URL: https://cgit.FreeBSD.org/src/commit/?id=3D9d18115ca0ab0ef3f34173d4e2= bdabec916d0b60 >=20 > commit 9d18115ca0ab0ef3f34173d4e2bdabec916d0b60 > Author: Christos Margiolis > AuthorDate: 2025-11-21 16:14:33 +0000 > Commit: Christos Margiolis > CommitDate: 2025-11-21 16:14:47 +0000 >=20 > sound: Retire snd_mtx* wrappers > =20 > Do not create mutexes with snd_mtxcreate(). It doesn't provide any > value, plus it first allocates the mutex with malloc(9). Allocate > mutexes in the stack and use mtx_* functions directly instead of the > snd_mtx* wrappers. > =20 > Sponsored by: The FreeBSD Foundation > MFC after: 1 week > Reviewed by: kib, markj > Differential Revision: https://reviews.freebsd.org/D53855 Hey Christos, I'm getting the following error on buildkernel: =3D=3D=3D=3D BEGIN LOG =3D=3D=3D=3D /usr/src/sys/dev/sound/pci/hdspe-pcm.c:726:3: error: call to undeclared fun= ction 'snd_mtxunlock'; ISO C99 and later do not support implicit function d= eclarations [-Werror,-Wimplicit-function-declaration] 726 | snd_mtxunlock(sc->lock); | ^ 1 error generated. --- hdspe-pcm.o --- =3D=3D=3D=3D END LOG =3D=3D=3D=3D Thanks, --=20 Shawn Webb Cofounder / Security Engineer HardenedBSD Signal Username: shawn_webb.74 Tor-ified Signal: +1 303-901-1600 / shawn_webb_opsec.50 https://git.hardenedbsd.org/hardenedbsd/pubkeys/-/raw/master/Shawn_Webb/03A= 4CBEBB82EA5A67D9F3853FF2E67A277F8E1FA.pub.asc --yomcxtfjbtluxwi5 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEA6TL67gupaZ9nzhT/y5nonf44foFAmkgz2AACgkQ/y5nonf4 4frpgg/9ENCUZj7tDCOqelOZK49s9gLmU4fOCEuj2eLLZDgCmoTNp41RfixXAd/I M57SI2ZmwGM7R5x45N4rMfhwtV906DQwsQHNh3Ezb5jlhvNPiqTHYmKMnXCcDBuI +z44RZKbjJeZGzcRp72Mo+1w3AF+JOxY7bb7ui7n9TDVScrYlN5BKU8rsX/77BO5 WV8IeNapDHTg1368hEipwptlIST1a9eaH+QSP4VR90qqlEC0+cxMx1xpbRpYKzF/ zgc7w5MbFgpO6y/iAm6kiwgszuD3UjslvRiDfL2HUzJtwM30Tm++poMi45/52qLE 4k0ew9R67XPLfGXFYl1st5hSobTpn9WDjrEc4CuU4TKT5iFeA55PP2RQzXnlvb0k kXiuOx2h35c5/QOVQ01mLo0ywaLFw4fH+DELq0rgrLBBmjc2sgczmljYyoBjo9UB YY6xcEWhQxoTP0o8iTDNHZXrbh3WO20Q5/LeInL64yOPVIujktz/nyCeu8x6wQaK nk4vZnZa1GOGWKWe4oViVK1+ezqTCtBMdALcVvMnv/NRfT1SrI4h2x7OE0y+fIru dJLQGGkBCb05ati6VA58s/dBBP4baZIFosZfRTagnB9FWjlbnMYAT5HnRffL7taA BlBE7FFratiwAxiD9SOHjj1T4Mug4UtHQw4YTXvrJuVI70rqlj8= =OViC -----END PGP SIGNATURE----- --yomcxtfjbtluxwi5--