From nobody Thu Nov 20 15:24:59 2025 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4dC2GN2bYyz6HXfB for ; Thu, 20 Nov 2025 15:25:00 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R12" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4dC2GN0Gx4z3Pjp for ; Thu, 20 Nov 2025 15:25:00 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1763652300; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=DOysRr41rRse9qbL1SFYXHuCivMa7JNAfeIb3SsKREs=; b=cbLVQ7njXdB/iezTuBh4XxEOQtiPxlVve8l5jhYJoFRCj6jDXUqOsgLOi3McWvGtcZQ5DZ mD38PfH2GZbu+7JwjOM7TgUcZtWBrH9MEy1kgazJ++JM8HQ8ngYPjxlZPCfIVh8U/YFaif h4mUTdZnvBGiRo8X7RJFg+7ZXnamlBGBJVJJoGebcpNDMKUgbQGNPWS7HTCIRvspePdsG6 zBQxkymlsJ71DYzSho85m8ZczJWK8RmVviepzbpsCOS1HoMDdlk7mIHyusXInpda9oKPqg aFOBbg+oLp8QI2Fq+GpOWhxSlHxJzMNfHZ/0UYrNHKpNzhUNq5zYpPt9N67qtw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1763652300; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=DOysRr41rRse9qbL1SFYXHuCivMa7JNAfeIb3SsKREs=; b=RAcRsl6GQl4Kb+N9IJFAfjIIMOtozDmtfQTllHeo2i4TGh5acxflWpmgocn3TlXCUjz419 0i0zq5bEb07aGff4ci12pSvf3mxoz9mRRWZEL3xNtOSdqnosJPEHcdqPa+Bhj5vYW86xk2 gUYyJL5i60fTzRSs1XWDhe675ljt1evoeL+cwnLDMGRYE4PdRJ3bzADG5OezsGiNfZUqB+ /p+9XOJrM2ay/FTpd7bR8bnA07Lzm57t5ie4wGuADaZU3KW8pjI19DCpI5SdJQPoQ/xqU7 0RtyisobKFsQ2xzWubGOL5A/evEI0cefHqgh2t8frYeSX+6OmM6+IwFFpPCnuw== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1763652300; a=rsa-sha256; cv=none; b=sA8OxvzG2qEE2vz7w9uOxLVrZwEHwCDKA6Sm1kCvDl0E4jhOopAhaoB0Ol1bSY5vXQg2nl QxDzwmH8gTzsJPJvqGob4xBqCidnyWXA9ZJu/+44zcxzfOt0rgQfrOVMa1YNEkPHmiJFsw V2KcIEoyaPng8StwHzYSUUaCQbXJz1K0uO+kuEuuDdgxl9SP04S+2tPJPYEdFSmoGbjxtH iwS3oQGssxnB8UCv5SripACLSOfcy3xlnIOjNfi2p8+6gG0PWmu3ydbsz542CczOEzAiQr 8i3FkwXbcjl2CLRKymPhcBfllC3R4TjNJQRY7yRqtAnOXgSlVgdaHq9LLyanRQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4dC2GM6vfbzY58 for ; Thu, 20 Nov 2025 15:24:59 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 3693f by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Thu, 20 Nov 2025 15:24:59 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Christos Margiolis Subject: git: 3612ef642f51 - main - sound: Remove vchan_passthrough() and hw.snd.passthrough_verbose List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: christos X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 3612ef642f511a1bd9f759da87abeafe7d6ff110 Auto-Submitted: auto-generated Date: Thu, 20 Nov 2025 15:24:59 +0000 Message-Id: <691f32cb.3693f.405f7cdc@gitrepo.freebsd.org> The branch main has been updated by christos: URL: https://cgit.FreeBSD.org/src/commit/?id=3612ef642f511a1bd9f759da87abeafe7d6ff110 commit 3612ef642f511a1bd9f759da87abeafe7d6ff110 Author: Christos Margiolis AuthorDate: 2025-11-20 15:24:49 +0000 Commit: Christos Margiolis CommitDate: 2025-11-20 15:24:49 +0000 sound: Remove vchan_passthrough() and hw.snd.passthrough_verbose Unused and confusing. Sponsored by: The FreeBSD Foundation MFC after: 1 week --- sys/dev/sound/pcm/vchan.c | 18 ------------------ sys/dev/sound/pcm/vchan.h | 5 ----- 2 files changed, 23 deletions(-) diff --git a/sys/dev/sound/pcm/vchan.c b/sys/dev/sound/pcm/vchan.c index b31e28d51453..dcb49e3003d0 100644 --- a/sys/dev/sound/pcm/vchan.c +++ b/sys/dev/sound/pcm/vchan.c @@ -47,13 +47,6 @@ #define FMTLIST_OFFSET 4 #define DIGFMTS_MAX 2 -#ifdef SND_DEBUG -static int snd_passthrough_verbose = 0; -SYSCTL_INT(_hw_snd, OID_AUTO, passthrough_verbose, CTLFLAG_RWTUN, - &snd_passthrough_verbose, 0, "passthrough verbosity"); - -#endif - struct vchan_info { struct pcm_channel *channel; struct pcmchan_caps caps; @@ -723,11 +716,7 @@ vchan_destroy(struct pcm_channel *c) } int -#ifdef SND_DEBUG -vchan_passthrough(struct pcm_channel *c, const char *caller) -#else vchan_sync(struct pcm_channel *c) -#endif { int ret; @@ -744,13 +733,6 @@ vchan_sync(struct pcm_channel *c) if (ret != 0) c->flags |= CHN_F_DIRTY; -#ifdef SND_DEBUG - if (snd_passthrough_verbose) { - device_printf(c->dev, "%s(%s/%s) %s() -> re-sync err=%d\n", - __func__, c->name, c->comm, caller, ret); - } -#endif - return (ret); } diff --git a/sys/dev/sound/pcm/vchan.h b/sys/dev/sound/pcm/vchan.h index 65b0218781fb..5d8057cd4b7f 100644 --- a/sys/dev/sound/pcm/vchan.h +++ b/sys/dev/sound/pcm/vchan.h @@ -39,12 +39,7 @@ extern bool snd_vchans_enable; int vchan_create(struct pcm_channel *, struct pcm_channel **); int vchan_destroy(struct pcm_channel *); -#ifdef SND_DEBUG -int vchan_passthrough(struct pcm_channel *, const char *); -#define vchan_sync(c) vchan_passthrough(c, __func__) -#else int vchan_sync(struct pcm_channel *); -#endif #define VCHAN_SYNC_REQUIRED(c) \ (((c)->flags & CHN_F_VIRTUAL) && (((c)->flags & CHN_F_DIRTY) || \