Re: git: 20e94950c54e - main - nvme: Notify namespace changes better

On Wed, 19 Nov 2025, Warner Losh wrote:

> On Wed, Nov 19, 2025, 11:01 AM Bjoern A. Zeeb <
> bzeeb-lists@lists.zabbadoz.net> wrote:
>
>> On Tue, 18 Nov 2025, Warner Losh wrote:
>>
>>> The branch main has been updated by imp:
>>>
>>> URL:
>> https://cgit.FreeBSD.org/src/commit/?id=20e94950c54e398049396647da36b9e2c3b639c1
>>>
>>> commit 20e94950c54e398049396647da36b9e2c3b639c1
>>> Author:     Wanpeng Qian <wanpengqian@gmail.com>
>>> AuthorDate: 2025-11-18 15:24:23 +0000
>>> Commit:     Warner Losh <imp@FreeBSD.org>
>>> CommitDate: 2025-11-18 20:32:22 +0000
>>>
>>>    nvme: Notify namespace changes better
>>>
>>>    When we get a namespace notification, we have to reconstrut the
>>>    namespace to get the new identification data from the namespace. For
>>>    each namespace in the AEN, we will reconstrict it before we call the
>>>    notification. We also flag it as changed for the duration of the
>> change
>>>    callback (prior versions of the patch needed to keep track, but we no
>>>    longer do, so this bit may be removed). Note when we've seen the
>>>    namespace so we can notify when it goes away.
>>>
>>>    Co-authored-by: imp
>>>    Differential Revision: https://reviews.freebsd.org/D33032
>>> ---
>>> sys/dev/nvme/nvme.h       |  7 +++++--
>>> sys/dev/nvme/nvme_ctrlr.c | 12 +++++++++++-
>>> sys/dev/nvme/nvme_ns.c    |  9 ++++++---
>>> 3 files changed, 22 insertions(+), 6 deletions(-)
>>
>> Just replying to one of the multiple commits:
>>
>> It seems from somewhere a VIMAGE enabled kernel is pulling
>> in systm.h for memmove; LINT-NOVIMAGE fails without the below:
>>
>> % git diff
>> diff --git sys/dev/nvme/nvme.h sys/dev/nvme/nvme.h
>> index 8f7a7fbda14c..e17c2bf41a5a 100644
>> --- sys/dev/nvme/nvme.h
>> +++ sys/dev/nvme/nvme.h
>> @@ -31,6 +31,7 @@
>>
>>   #ifdef _KERNEL
>>   #include <sys/types.h>
>> +#include <sys/systm.h>
>>   #endif
>>
>>   #include <sys/param.h>
>>
>
> I'll take a look, but i didn’t think i added a memmove.

It's in the header file.

Oh I missed jhb's changes.  It was him in 8d2a50bb38051.  Sorry.


-- 
Bjoern A. Zeeb                                                     r15:7