From nobody Fri Nov 14 21:41:55 2025 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4d7Vw705JXz6GR4J; Fri, 14 Nov 2025 21:41:59 +0000 (UTC) (envelope-from glebius@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R13" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4d7Vw66Zlhz3Wg5; Fri, 14 Nov 2025 21:41:58 +0000 (UTC) (envelope-from glebius@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1763156518; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=9Tzuyx7cForOkAr9RXODUi1VYhD19PF9N5evclqtv60=; b=rIgnjpcrW6uI9e2YPs6bbo4wzdMuT60HsfF7VzQovmg0/E90CxjTWdBTUZZI+gtqRzu/SL IwwHnnyeFv5Hwuan0h7wAOyqXAkXYs5cYABsf2EKR5CPUpKUW/pJmB/zk7ETZQuJya7ywe nortxJracmTTbMxtdbdmRYpXSOhTDfQCv9ECplJwhFjWdPS0EYxIiBupuN5vXRcTG6t/Ye 9rs6b8MkX3dGfz09z6Ly2p9KzlGu05SL4Zd8l/8UHNU8LL2mQvCZHKnELEStc6nyESKphg OYnSeFWcldpY62vEJDps3rP0VDxHqthVUqwTTQsdYUBbg7GxewTILu0Twb6zRg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1763156518; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=9Tzuyx7cForOkAr9RXODUi1VYhD19PF9N5evclqtv60=; b=Wb6h3p3tRLpw9/LkuOrvvMaVYxz9vWGvI1xiWAnpX+SRTRo0jJLba117cvJKuwxKm1Nvmr Pc7kNyRZ9t9eY5zr18XWlo1LUp3n3TIURhDB+zdaVkmkeasFLNVXjYMg8y+T8x3YRLjhTZ bfhNRwGoRNv6KvpngpYNBy5/aj5DtSZAjyx3h+GLQWFkX5b1kcdzMfWTaV5Md0bG8hWbVb 8VezPpol67G7Ept72QgyS2v50RUbkvGf2bctaxh+Pw9F672oDLaN5Iu/JHxcaAmbrvPQbC azMUxbHrWgyfcN6NA5u4wsZF65EZyC+0YB/i+NPBKh4pL36lg4eDHTdGUTs+1g== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1763156518; a=rsa-sha256; cv=none; b=D4j3DAaDg2xtaSwXrCjCYD7BXtQZItw5605dv4PxkPhqqOhOdkhdOH+b2CHfXWohAsT+sU n+PE+UnPkLy0hPcBAxnkA4ugCRTMRcIUvXQHRecVG324K9Bh4WBu1g1XURalvPr0cH7DMk Xt0RbeAis6KbHGd1mr3ByiSyAWoxltL3Nifo3PSTqAttN1ZN9lOsAzyitgQ7r/ZSPCYrZD 6qSefX++EjMXgidzavzJov0LXXthKpyIVnprXvkQp0DuqwGWWZ8orA5er+5V624TLlWHI3 SzGX0XBuFrPCvTrUU7ms7stPBZr6D71RYqAGAHl2xa71w+XiVj0j5aXnT85AQQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from cell.glebi.us (glebi.us [162.251.186.162]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: glebius) by smtp.freebsd.org (Postfix) with ESMTPSA id 4d7Vw62Chnzvx5; Fri, 14 Nov 2025 21:41:58 +0000 (UTC) (envelope-from glebius@freebsd.org) Date: Fri, 14 Nov 2025 13:41:55 -0800 From: Gleb Smirnoff To: Renato Botelho Cc: "David E. O'Brien" , src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: f1b9c1aafd84 - main - random: git'o in RANDOM_ENABLE_TPM Message-ID: References: <202511110246.5AB2kdQc077401__35176.4420907543$1762829211$gmane$org@gitrepo.freebsd.org> List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Fri, Nov 14, 2025 at 06:03:15PM -0300, Renato Botelho wrote: R> After upgrading my laptop this morning I noticed it was freezing after R> suspend/resume. I've bisected and ended up on this commit. R> R> I confirmed reverting d6f10a5d013f (only to prevent conflicts) followed by R> f1b9c1aafd84 and 3deb21f1afd5 have fixed the issue. R> R> My system is running today's CURRENT at 82d8a5029a80. Looks like the commit you point at can't be a culprit. Looking closer to your description "reverting d6f10a5d013f followed by f1b9c1aafd84 and 3deb21f1afd5" it seems that the only functional change is addition of device tpm and rdrand_rng and option RANDOM_ENABLE_TPM to the GENERIC. Can you please try unmodified main sources at 82d8a5029a80, but modify GENERIC to remove these two lines: +# random(4) +device rdrand_rng # Intel Bull Mountain RNG +device tpm # Trusted Platform Module +options RANDOM_ENABLE_TPM # enable entropy from TPM 2.0 If that helps, can you please find which particular line makes the regression. -- Gleb Smirnoff