Re: git: f1b9c1aafd84 - main - random: git'o in RANDOM_ENABLE_TPM

On 10/11/25 23:46, David E. O'Brien wrote:
> The branch main has been updated by obrien:
> 
> URL: https://cgit.FreeBSD.org/src/commit/?id=f1b9c1aafd8496c5bfdbc2be57bcfecfe58f12a8
> 
> commit f1b9c1aafd8496c5bfdbc2be57bcfecfe58f12a8
> Author:     David E. O'Brien <obrien@FreeBSD.org>
> AuthorDate: 2025-11-11 02:37:28 +0000
> Commit:     David E. O'Brien <obrien@FreeBSD.org>
> CommitDate: 2025-11-11 02:46:31 +0000
> 
>      random: git'o in RANDOM_ENABLE_TPM
>      
>      Fixes:  3deb21f1a
> ---
>   sys/dev/tpm/tpm20.h | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/sys/dev/tpm/tpm20.h b/sys/dev/tpm/tpm20.h
> index 7c2ccd30143a..b2cfcd4f25bd 100644
> --- a/sys/dev/tpm/tpm20.h
> +++ b/sys/dev/tpm/tpm20.h
> @@ -128,7 +128,7 @@ struct tpm_sc {
>   	lwpid_t		owner_tid;
>   
>   	struct callout 	discard_buffer_callout;
> -#ifdef TPM_HARVEST
> +#if defined TPM_HARVEST || defined RANDOM_ENABLE_TPM
>   	struct timeout_task 	harvest_task;
>   #endif
Hello David!

After upgrading my laptop this morning I noticed it was freezing after 
suspend/resume.  I've bisected and ended up on this commit.

I confirmed reverting d6f10a5d013f (only to prevent conflicts) followed 
by f1b9c1aafd84 and 3deb21f1afd5 have fixed the issue.

My system is running today's CURRENT at 82d8a5029a80.

Let me know if you need me to collect any other data.
-- 
Renato Botelho