From nobody Fri Nov 14 16:51:05 2025 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4d7NTL5gcfz6GkHR; Fri, 14 Nov 2025 16:51:50 +0000 (UTC) (envelope-from garga@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R13" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4d7NTL4xQMz3qSl; Fri, 14 Nov 2025 16:51:50 +0000 (UTC) (envelope-from garga@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1763139110; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=O62puo5fv5daH5dw0P6D0lkvS7Gzv7g6i7fCG0jqXZ8=; b=wCZxc78zeZdBkjatiHPPvHypKKvYg3/UYz7X1wCygjSbJo89ktqAW8c5J8o9di7SmMFkpM YJdwwSvV/8xJWkN5jX81LPjoIiMixXoqc2Kk621/iqkaNkwUuOxCetgjrhnSnMkRtgMENA MhKp6Ymulxg+RbasieHw4l6jjsb+/dK7kxmX09bIV/MjPTqChe1crsZgNWatprZ4hu/57b 4RyniLh8mFgSSsYoz6yOriI0b+qA11x0zwI4Qe3CMeJl64LRqHlLEmPmVs1Eezy72Hn96W QsxxO1ZYsGUf7UPXDBd2ALPCZK6Wu581NfwG4exvOeTkPQ3JFMHuQ8VZHT0KnA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1763139110; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=O62puo5fv5daH5dw0P6D0lkvS7Gzv7g6i7fCG0jqXZ8=; b=Jxt2a9jxkKsgz66vjC+NSLm7pv/fBmO7zeLdsiJUw0LKUYg+18+ynCvGzPMoxHNCvBHQV5 h8VBt2UR6BQtwObvKdA4vTCk1eIQKu9Ax2GRCqNjmdk1QW4Ll68ZURyhdEbUhQQiOOTwU7 aJU+vejP9H5eGMfwSSVdSLpGA+QmaQrhvDNO4iT3r1tcGqUVeHOE0u8vovGzxMnq5qopWX 7cm+2jv6GutYmTM0TSsWmoYdDT5l/MpEEY9naXC+hMKBzFJT5SYXeIigDmkSCnBLhGxx6p huq+uiFuuLeeJGLHCqZ+fmGgYhZCWANDTX5tgZhV4aVhrxEpmc5FYnm812e2Aw== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1763139110; a=rsa-sha256; cv=none; b=M2pr0lCaRJuL2QA5GJihHlkX/uwKlWOAzRS41/UBq8O4mnequCGq5C1qon51KkxRGV2pBr mU1vFQLxnxuh5Z8pwh1jt/oWZeqXZ8BTogCKAEG4jBsDYQSEFZBOQROB90upOvHMdEoLct cBC8jTfSRbQwF0pfJAa3thKk7dw0qP36wwnim0ORZsaeVTU7fEytW0aIJP+5Y5YEosVJD0 wxpQG1TBnUaj+x3dznuQoIMlhPBGgPdaTcXKrsGeLiDp0KG1JQeG1u7GahYtocwD4NdbqH 523wvCCvVP/KhEtRyvqLYnesnzpV1viW8PBV+yfxyvHNChg4SX6dP/t8Y+Yy5g== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from [IPV6:2804:f1c:34:1001:ec2a:ec6:cee9:f831] (unknown [IPv6:2804:f1c:34:1001:ec2a:ec6:cee9:f831]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: garga) by smtp.freebsd.org (Postfix) with ESMTPSA id 4d7NTK6Rcyzqgt; Fri, 14 Nov 2025 16:51:49 +0000 (UTC) (envelope-from garga@FreeBSD.org) Message-ID: <76f53310-ac59-44cf-a991-077defee502d@FreeBSD.org> Date: Fri, 14 Nov 2025 13:51:05 -0300 List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: git: 82d8a5029a80 - main - unix/stream: fix instant panic w/o INVARIANTS To: Gleb Smirnoff , src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org References: <202511141604.5AEG4mNt027362@gitrepo.freebsd.org> Content-Language: en-US From: Renato Botelho Autocrypt: addr=garga@FreeBSD.org; keydata= xsBNBGStavwBCACjNlp/9+Y+VFe9ieR2h/WWbdvjz4Mb2z/f22bGoaskzCfvVNbo/v3i34I9 H6OdgZkGqheQEAD2jNfRbmPr4z40xDMUpYGLds+1Mvg7G3Hms3j5Ef8KaLSWUNWIfwKdfSVR Qs35ccSJxAdRW5YdI6J3xZgika+3Bc4eJ05YE/nWW+PNTYevt5rqD50N3zybVYIcLoqVPpBi AZE/sf5SLiLACIJb1t/s4x+pi8vgWevxVVT9u8V1f8zYErmHSLSqjxii0B3eRZphX9NCJOv9 +tfFZhnENInhn9gT7H4e2YumUltEy3jacONHJF3CC1pvvWEa6lEyypclMOkHQwNON7DLABEB AAHNLFJlbmF0byBCb3RlbGhvIChGcmVlQlNEKSA8Z2FyZ2FARnJlZUJTRC5vcmc+wsCXBBMB CgBBAhsDBQkFo5qABQsJCAcDBRUKCQgLBRYDAgEAAh4FAheAFiEERL7Dxegbnh7xTiQ5Ob6P xxJcZXoFAmSta78CGQEACgkQOb6PxxJcZXrYlggAgaZmr6c1yIWzN8VksHrHpwt/uxONEP+h ljy3yfrMsgfS5wx5Uzgfih1xYZUFC6jiI63CetqBqJpp3g1klRS1UWYKx2NeXphDMYZEdPm/ a6sXh4bKZbk6IE8Yn0/YiRT57d9DtbvswC7Gn7Igj/MSbhl49TvTGyvuB6juaffVoYZViomx 5zMoee8Ml2o2qj3MrCJ+/K8GU54RlpOGqGRsqdwVdr9XEWub6fF2YFwR46cjmbiU3P5urFHH nkJlBGPIwKxHimTW0lZsdx9aCKRDd/D80/WOEzXmk3k8B9lv/GsvOluHmveLhJG1R1tIJ31I f2q8dfTvqsQXnu8CcWRcgc7ATQRkrWr8AQgA1DufoxScA+CWQbUR6zExIu8wXQKrhuRt4DG2 BgynT7EMUvEBadcbQRZXsBpemNfncc9Axyut/+rWiyKJf9BLQuo/9QYmSRvW1U6+0LJUYmdg kMyBeYaPk+vnssv/u9jLuvV7FVgyE0yk1iaWIKOVDD+XrQCOvGw9uSceBrQyCyo3A/eRM/+p vnDCaywR63PKE+3axk6lfNdGK3TnaWmS30/ZDCZlNsXuqprqR4JdT5wXids5o36dsuJ5EZ20 s5hNMD34s4Yr1Y1R9elH6qBsFCpozs0+jwrArxq+UJJCR6hH5W8ZEwJtRC8tzR8mRE1WywzX BXYj0YhfGztQIxZckQARAQABwsB8BBgBCgAmFiEERL7Dxegbnh7xTiQ5Ob6PxxJcZXoFAmSt avwCGwwFCQWjmoAACgkQOb6PxxJcZXr1vgf/SKXhoZcUU5I7TqcbHg0lJz9tICTupCGHWr/s SQgjh9oEM5j1wqW7FlCGP90Tl9K0g3ow9YdbhU7VK470o6pymX9V9eLHzGgkZO/KMEtGBeK1 u+5ePjCJ/MK5B21KODLSU7WrIL1VN5ceXfQPLYt02LMLtPri+oduHD6RNBeA7US1DUzleq5F 9NHGbvV2U7BdDUezpiO8NaFjFZVB11I5d99FxUM5XGVstI3VhsRKZxjY0KnqJzaQgTFsPGmv AUfZVIN1pXgXiedhPXpr8+Y64jP+pHVwpVmh1zYWL6+q3kqFOUVP6c5iiMeoEXZvgJz7x/AC ek3X5gvu8Hpcv+MZIg== In-Reply-To: <202511141604.5AEG4mNt027362@gitrepo.freebsd.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 14/11/25 13:04, Gleb Smirnoff wrote: > The branch main has been updated by glebius: > > URL: https://cgit.FreeBSD.org/src/commit/?id=82d8a5029a80a77166dca098b8fedb10d84e4e38 > > commit 82d8a5029a80a77166dca098b8fedb10d84e4e38 > Author: Gleb Smirnoff > AuthorDate: 2025-11-14 16:01:47 +0000 > Commit: Gleb Smirnoff > CommitDate: 2025-11-14 16:01:47 +0000 > > unix/stream: fix instant panic w/o INVARIANTS > > A stupid microoptimization I made leaving empty STAILQ inconsistent > is a brainfart that is related to much earlier version of this code, > where it was safe to do so. > > Pointy hat to: glebius > Fixes: 69f61cee2efb1eec0640ca7de9b2d51599569a5d > --- > sys/kern/uipc_usrreq.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/sys/kern/uipc_usrreq.c b/sys/kern/uipc_usrreq.c > index b1cb6de98b5b..6996f3d447bd 100644 > --- a/sys/kern/uipc_usrreq.c > +++ b/sys/kern/uipc_usrreq.c > @@ -1492,11 +1492,10 @@ restart: > } > > if (!peek) { > - STAILQ_FIRST(&sb->uxst_mbq) = next; > -#ifdef INVARIANTS > if (next == NULL) > STAILQ_INIT(&sb->uxst_mbq); > -#endif > + else > + STAILQ_FIRST(&sb->uxst_mbq) = next; > MPASS(sb->sb_acc >= datalen); > sb->sb_acc -= datalen; > sb->sb_ccc -= datalen; It fixed the crash I reported earlier. Thanks! -- Renato Botelho