From nobody Thu Nov 06 00:38:37 2025 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4d23G53FlYz6FBDV; Thu, 06 Nov 2025 00:38:37 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R12" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4d23G52pyvz3dKN; Thu, 06 Nov 2025 00:38:37 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1762389517; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=M17EUw7zyZz2WdHovyv33ah9H/IBLU8am7rc/Yqcc5A=; b=SVBTMluSfL6d08NCH8nFWQI+l4b975/mvSnLSb6YEnZJhwo13yw4YshpgKCTWwtOzFnklr IHGcQVJLsHGQlzSbLz458u61jiBcvv0PgavNFRuWgTXyyNzOaiw5p/UASQ49CnFJyi6OxL uaotf4ZsWswiMBQslGursqH+qXJH5TzFhZGAq2ayG9C1cbAW7XmeQT8ZRXmXfr6OJd216b 465jW6A9hgb0fvCUJf58mMsIKdpxP60GfGegf6gkqEPAou8OfwGfjxbxzwhc1kEBxCPYhh 8fL1huuquYtVQNhrJ2PJeTJMGLcSCgCckrvVRkvADDAHjBLNYERsP8zBbjxBWg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1762389517; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=M17EUw7zyZz2WdHovyv33ah9H/IBLU8am7rc/Yqcc5A=; b=YrlZKoLWjoc6pAkKu8ztZZYtYz/LG/26u0EsJEQrig6thvc7ju2/EttoSVFtC5tvMV0D26 j93GLSHCMrVD9Bw9/veGP+2MP1j4je0V6hvvyKUeLal02+lI19Mp/qYYV4IvXrTySuD9Zu SXHmekG0Vrt2TM7A3lKMUXRGYAaa1CRndWPgmVlpHEVKrZIGCzwnXSzMMosevC8zH6Hjcj DglRE+oWkxENyyYQZIWSIh6ZH6CHbjgMaYX9ZxILgN5zFWsxULqjv6cll+cW05reTNynil yJIMjPNGuRB0AwhDKmo4UyFR7j8O00rNQVpCkEY2F3Qr5G6BVIc5p3tMrIECww== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1762389517; a=rsa-sha256; cv=none; b=qELAH3sOpsSj4Ukb6Ed0a4fMWQYtVhqj6YuyJC/p2r6eA5sK/6ZEn0aoyQJpGWQpDmBHwz qpdT/zBtE3Dy6v/07w9+e5bbKSWU2CKptQa1leSfmq7bDFamkooGQ9PyUDpi2+112YFdnZ fN4SRsY1+kLrj1TExCN/xk8kxer/OuEbgdRH5+pke3JOTozN7haVA+rDyAVdmiDV/Qoz9V IqxKNZJW7BzzA/NZZUL9m74nfuFYA1Fm3nRAeT4zhvzFt8dFk1kp9CoMjmGxyayxDk9mYm UqiqGbatqxmwfWw4uETJYpmAR0cx3AjbZyzWBckX5ZI29g+u/89kXMdyqQEpUQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4d23G52QgKz15Mt; Thu, 06 Nov 2025 00:38:37 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 5A60cbX1052176; Thu, 6 Nov 2025 00:38:37 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 5A60cbwv052171; Thu, 6 Nov 2025 00:38:37 GMT (envelope-from git) Date: Thu, 6 Nov 2025 00:38:37 GMT Message-Id: <202511060038.5A60cbwv052171@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Alan Somers Subject: git: a1c3537148a5 - stable/15 - fusefs: fix intermittency in the BadServer.ShortWrite test List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: asomers X-Git-Repository: src X-Git-Refname: refs/heads/stable/15 X-Git-Reftype: branch X-Git-Commit: a1c3537148a59f6a1c86ebcb686b2e2c8e404b5f Auto-Submitted: auto-generated The branch stable/15 has been updated by asomers: URL: https://cgit.FreeBSD.org/src/commit/?id=a1c3537148a59f6a1c86ebcb686b2e2c8e404b5f commit a1c3537148a59f6a1c86ebcb686b2e2c8e404b5f Author: Alan Somers AuthorDate: 2025-10-14 02:18:48 +0000 Commit: Alan Somers CommitDate: 2025-11-06 00:25:19 +0000 fusefs: fix intermittency in the BadServer.ShortWrite test This test implicitly depended on the order in which two threads completed. If the test thread finished first, the test would pass. But if the mock file system thread did, it would attempt to read from an unmounted file system, and fail. As a result, the test would randomly fail once out of every several thousand executions. Fix it by telling the mock file system's event loop to exit without attempting to read any more events. Reported by: Siva Mahadevan MFC after: 1 week Reviewed by: Siva Mahadevan Differential Revision: https://reviews.freebsd.org/D53080 (cherry picked from commit d1bd541b385d49d2ae3a8bad9df72779b606e208) --- tests/sys/fs/fusefs/bad_server.cc | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/tests/sys/fs/fusefs/bad_server.cc b/tests/sys/fs/fusefs/bad_server.cc index af2ca146e431..c3d195735446 100644 --- a/tests/sys/fs/fusefs/bad_server.cc +++ b/tests/sys/fs/fusefs/bad_server.cc @@ -65,6 +65,11 @@ TEST_F(BadServer, ShortWrite) out.header.unique = 0; // Asynchronous notification out.expected_errno = EINVAL; m_mock->write_response(out); + /* + * Tell the event loop to quit. The kernel has already disconnected us + * because of the short write. + */ + m_mock->m_quit = true; } /*