From nobody Wed Nov 05 14:00:35 2025 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4d1n5v4lq5z6GM45; Wed, 05 Nov 2025 14:00:35 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R12" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4d1n5v4Hr5z49xP; Wed, 05 Nov 2025 14:00:35 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1762351235; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=5asVQO/EqfVYyUnv2fITYHTGj3H4sb01R4xUAEC9wPM=; b=SRltDmFcQ8PV896lvJqQiBfX35uR5YGAhBoyBfT9emzsjS4TaoAyrKZUdDYG/MYaMOcF5i x4BGDYNOFelHtBjK1IHtVeRVkEGVXdgMrguPLvwAjYIIJic1lDuuK1Y6TXeyk+HjdPlq58 wecVCaNlrrjkNBdyEDBNbwhBnTSu81U7qV+lOaWyInVO51+Tv/xodYBEc7H39mY0stP1yW YXliea1z8B3mJBz1tWqbaNQFyihG5jbfuSQknMUN4T+dERmfiRBVzkfzZg9nAbqXWB5hc9 SXfD9Z1cacKbupNtZ2kuCZ1VEKb8s40SZEFDw/TCvojr2nc2Qf7LJQlmlxs4NA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1762351235; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=5asVQO/EqfVYyUnv2fITYHTGj3H4sb01R4xUAEC9wPM=; b=hSlOeqxICETQbDs2XwxmOq70YHhjSOMFJUhKI5jGmLIv9zkxOlYu7UnLhKc9mM39OgqjsR JlpwHcOcnEl2SoctwE1SwU3NilI+wX4Fpr+B3SUgfgVGcm8fHUtOPlRsAIrARkMPVLl7xa fqSPrcEX5YACA5W6nTJ0ctQdlLiR/DJXeRibF7PM11C7V/0D/mmf4g5uZyDkdjQg//o64h cZKu7mGQ2ZY7g2LCFoE92FdM4tW8IAzvEeTx57rEr/v6gTilzOkDia7dKLBGI2TmgpAX3j /xZokvn7ryciflcasys5xETN1AmdrBPzT98OqoFqvgfUJ0lOW+NUKRdL50iwww== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1762351235; a=rsa-sha256; cv=none; b=D0ZsAzQeXijSJxg54IkLJTqtKUxFiHIAycZoAD4xZ1mrYY7LJD3uA1fyPcyBexcJ66HgaA v1IcvbXc12Mlt2IzrBNopWMf9PnItFXerxnQnr70HCmjpPlwtj9vosaIX06Ef45Zot/RuB pKXmdgCOeQeM2MNRG0ind9KyfPnrxHbbMcOtUPRJb5KlDLPx4tkn1axqXLGvgxiiLHgI/j YXlykRl5fFnGcA5j8K3alb9geTswZUiPsXlyswvYttao7kzzgvGCMtzv2bX6hIMLdoAhYK 5oOZoX/KiPheA26DqolhkuTnvd5V+kdlPrnGLd4sk2s76ZwNWNE9i4qPsZIVYA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4d1n5v3ghqzmH2; Wed, 05 Nov 2025 14:00:35 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 5A5E0ZEj053879; Wed, 5 Nov 2025 14:00:35 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 5A5E0ZiX053876; Wed, 5 Nov 2025 14:00:35 GMT (envelope-from git) Date: Wed, 5 Nov 2025 14:00:35 GMT Message-Id: <202511051400.5A5E0ZiX053876@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Kristof Provost Subject: git: 9bb1c46b4c38 - main - libpfctl: fix error handling List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: kp X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 9bb1c46b4c38c44565fc24f13acdc19b0cb5a1c4 Auto-Submitted: auto-generated The branch main has been updated by kp: URL: https://cgit.FreeBSD.org/src/commit/?id=9bb1c46b4c38c44565fc24f13acdc19b0cb5a1c4 commit 9bb1c46b4c38c44565fc24f13acdc19b0cb5a1c4 Author: Kristof Provost AuthorDate: 2025-11-03 13:55:44 +0000 Commit: Kristof Provost CommitDate: 2025-11-05 13:59:29 +0000 libpfctl: fix error handling In two cases we returned E2BIG where it should have been a boolean ('false'). MFC after: 1 week Sponsored by: Rubicon Communications, LLC ("Netgate") --- lib/libpfctl/libpfctl.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/libpfctl/libpfctl.c b/lib/libpfctl/libpfctl.c index e739e55033e2..511478de6cac 100644 --- a/lib/libpfctl/libpfctl.c +++ b/lib/libpfctl/libpfctl.c @@ -1491,7 +1491,7 @@ snl_attr_get_pf_rule_labels(struct snl_state *ss, struct nlattr *nla, bool ret; if (l->i >= PF_RULE_MAX_LABEL_COUNT) - return (E2BIG); + return (false); ret = snl_attr_copy_string(ss, nla, (void *)PF_RULE_LABEL_SIZE, l->labels[l->i]); @@ -1561,7 +1561,7 @@ snl_attr_get_pf_timeout(struct snl_state *ss, struct nlattr *nla, bool ret; if (t->i >= PFTM_MAX) - return (E2BIG); + return (false); ret = snl_attr_get_uint32(ss, nla, NULL, &t->timeouts[t->i]); if (ret)