From nobody Wed Nov 05 07:15:48 2025 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4d1c6r37dbz6FkGj; Wed, 05 Nov 2025 07:15:48 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R12" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4d1c6r1MPdz3K5x; Wed, 05 Nov 2025 07:15:48 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1762326948; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=HO6NC7g94MVVmCz1D0QXLkq+vbhXsPGBl64hOdNgDN4=; b=dPoUlhWe/SRmqXaFuprWCX1tfuT80W7dtvVnnjj4B//xKTvWwMvUw7L42tma4nQlgkmqXp 9x6h0wvgJJpk8E7VnKpNf/28RHus3vlEk+1JR/ffwJ6HwmmS5pkiE57BEg4Ucq/jxfNeD1 aala7akkXG+4fdfF7nUqwiTwHK1U7LU5rR8Cd8OdzECRxV/9yC/bfKhWYQ2AHBH7DN/wpH RdE9lodBpZX3aIR9dBptCnpuY4SBshxy1Zh0EvLAwFV1aNlEAF5DRGWl6XECnlef4S6krf qCiV3b2vet3xqcHpdI6TDwUpRh+zKgGHtg/dU1H2XODebHh+0ze2/ZLOXiAHAw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1762326948; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=HO6NC7g94MVVmCz1D0QXLkq+vbhXsPGBl64hOdNgDN4=; b=YvU6yXSdMawJOnzs5uQJzQI24Mxc3hGWPO2Hb7UVZZ7TFdwEX3n5jXe1wJ/iMPRIJait0Q qQXQepFF9xEt+1cA0+xR1r0FNYuenTNDw3zEdTRS3tf5tI3lJSpkC2pKvKBMMozt4+Uele y0l34EzeUE0oOShRQBVsT4f/n7LSXSsuLVkYTpzMWE+wKjMLHOAKBw+Qb7amtR+FomS9bt ATYqnyExWz9UJKBxqs7KpThRPyxKnSzqsTEINbJi9rkFoOtt8wlZ8XUiG5FDRpFyAaD7wb gdEN+begw3CGfB4p9jSpq9BXdx2/6xH26/cSBGGunNLMAS8+0Aj1MKsnJqTgww== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1762326948; a=rsa-sha256; cv=none; b=WbYQxTGncD5b3+9lp31uEZ98Q10pdp0hjKvd4lQZHD2BXbbzdDjZHjOFlk8DeDSwjRoHIi eXfoudEgMBj1kjbtnsni3HZqVkH8ezbwpQUhgZzxzXUQhX8E2LPSf+yO6BBimdSSlHZYWF 2t8s/tevyYWAT72/2saJKnnDS76qibPtt+2M1VuNJEuT1qUXwRb1eYZkgjRIWqr5bJ78m9 AQowHYfkx3WPM31eXXdioiXVw4HjvuFe1O3xhcvi/vc9W+TKjQXAlW7LGD54Szw89pbR7n CXdSixKkj24mwzMBxPhpFZhxAFy3Vq6eDWZxnK8vbFr+xgGuwvYLNHyVRe2q2Q== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4d1c6r0q9HzYtY; Wed, 05 Nov 2025 07:15:48 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 5A57FmJI088894; Wed, 5 Nov 2025 07:15:48 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 5A57FmeJ088891; Wed, 5 Nov 2025 07:15:48 GMT (envelope-from git) Date: Wed, 5 Nov 2025 07:15:48 GMT Message-Id: <202511050715.5A57FmeJ088891@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Maxim Sobolev Subject: git: 0bd5fb421a1e - stable/14 - mksnap_ffs: fix running unded chroot List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: sobomax X-Git-Repository: src X-Git-Refname: refs/heads/stable/14 X-Git-Reftype: branch X-Git-Commit: 0bd5fb421a1e85e75deb461660d8cfe6d139f1c4 Auto-Submitted: auto-generated The branch stable/14 has been updated by sobomax: URL: https://cgit.FreeBSD.org/src/commit/?id=0bd5fb421a1e85e75deb461660d8cfe6d139f1c4 commit 0bd5fb421a1e85e75deb461660d8cfe6d139f1c4 Author: Maxim Sobolev AuthorDate: 2025-09-23 16:24:44 +0000 Commit: Maxim Sobolev CommitDate: 2025-11-05 07:14:04 +0000 mksnap_ffs: fix running unded chroot Fix "run-under-chroot" workaround by replacing strlcpy(2) with memmove(2) since strings overlap. Reviewed by: arrowd Differential Revision: https://reviews.freebsd.org/D52670 (cherry picked from commit 60be0d71daab4247dc61c323777b0c593eb76975) --- sbin/mksnap_ffs/mksnap_ffs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sbin/mksnap_ffs/mksnap_ffs.c b/sbin/mksnap_ffs/mksnap_ffs.c index 0d8e32a15ab3..58939cc69029 100644 --- a/sbin/mksnap_ffs/mksnap_ffs.c +++ b/sbin/mksnap_ffs/mksnap_ffs.c @@ -150,7 +150,7 @@ main(int argc, char **argv) errx(1, "%s: Not a mount point", stfsbuf.f_mntonname); } if (cp != stfsbuf.f_mntonname) - strlcpy(stfsbuf.f_mntonname, cp, sizeof(stfsbuf.f_mntonname)); + memmove(stfsbuf.f_mntonname, cp, strlen(cp) + 1); /* * Having verified access to the directory in which the