From nobody Wed Nov 05 00:31:16 2025 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4d1R850cvYz6FsLr; Wed, 05 Nov 2025 00:31:17 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R12" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4d1R845rfRz3fPX; Wed, 05 Nov 2025 00:31:16 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1762302676; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=3M0DrckAAclWSuO+SGaX/OJMO/2n3EuD45piJK8/ujI=; b=Nein3lsOIhe2cih455qBGnrsxCDjJn4FotjJLe3/KGN2VUuC2eW01KHytjdcRlmjCUKyC6 5TwDP5KLSDqCIvg1CRGhNfzKTU1QFMYpJscO84LeW2TJeJH7qfKcwoY8d6WzTNzIlPtfTV 0JYQCEHJX8xh+e6StIaPbWHCwtvXkiRXrGFFJ8q1Whp7hDoxuooydbvKA+AAHcfQ1ltni1 OcdpOyD1rnm5zWZF1rMdElXtUoov76nVUYYysFjrM2HmbaE3WV26IQAKyEi6IFi/OSSW9N MvmAKfsnAnuVId2i9cZLo2FZ9M1er2twXlnqsg02WMwCyvL6DXI9biCysDWvlA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1762302676; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=3M0DrckAAclWSuO+SGaX/OJMO/2n3EuD45piJK8/ujI=; b=HaMu6AI2DjwjKgr39ESw7V5LzCuQvekneaGTFprWhh7lKwZWYlE5zA5Zgbycot6E+QmCZG Ohz21u/BY5ssPMwdZh4cw9BjHev0AXeerYuN78qwUdmqQ4AuHEXkV/vRUbXjecS8z2ablZ CP5z3DKzA9MKSu0J6BolpLhFHINMGlzWoCDvxq9DUkXAEYQetzf5oZGI43GQV+m/Jifim4 spnPxeAhCpLtLOcIrkKkcqz0p/qi3fFwCPjgFUMEpXN3jFZlY6fbgdWpxjeMdW8a0xvvn4 JUY8w7CbtD/Osan4RdgWRWYXFdWafZSiZrve4KxCNW+tY33i0Xb4+DbEpIzMsg== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1762302676; a=rsa-sha256; cv=none; b=DrhbwpmYgwH0W9YUhQVisJJBnTOmTel2kf/EmvKkCr8zLgJJta8SqRDZNFvjwnJUX6v2J/ 5MQR31edb3cvIzk3LJOejEy1GOE/xrCRWAFHwRW+v4v+cdI5I3cEFyCYaqPRcL6bqpkCff pzbBvuaWI4MgbC8N+N36mlChV94coAfHaVKOYqVfjKW/U9q6olEq76dCe3R/Fx/hD2IoM7 21XqlSF/4/NF6Yvw5+Gx/Ydc1oalx9UGx6OPM+LA10HTfkiSb3r++z26J+xcv0Pi8yTg2t qhyOxgl8Of64+lFTAxSOucvTnUUWDtAesH6lpHw+DUmFRiEvqBwEePiwCIrfmg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4d1R845RWkz4py; Wed, 05 Nov 2025 00:31:16 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 5A50VGSa028328; Wed, 5 Nov 2025 00:31:16 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 5A50VGMf028325; Wed, 5 Nov 2025 00:31:16 GMT (envelope-from git) Date: Wed, 5 Nov 2025 00:31:16 GMT Message-Id: <202511050031.5A50VGMf028325@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Kyle Evans Subject: git: b87436d8be8e - main - nfs_clvnops: standardize on EOPNOTSUPP for posix_fallocate(2) List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: kevans X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: b87436d8be8ea3f6d56c16d32933c138fed3fb12 Auto-Submitted: auto-generated The branch main has been updated by kevans: URL: https://cgit.FreeBSD.org/src/commit/?id=b87436d8be8ea3f6d56c16d32933c138fed3fb12 commit b87436d8be8ea3f6d56c16d32933c138fed3fb12 Author: Kyle Evans AuthorDate: 2025-11-05 00:30:58 +0000 Commit: Kyle Evans CommitDate: 2025-11-05 00:30:58 +0000 nfs_clvnops: standardize on EOPNOTSUPP for posix_fallocate(2) POSIX Issue 7 had allowed EINVAL for this case, but issue 8 moves it to ENOTSUP instead. ZFS uses the latter and we have some software in ports already that's wanting to use that to detect the filesystem not supporting it, so let's standardize on it. Reviewed by: imp, kib, rmacklem Differential Revision: https://reviews.freebsd.org/D53536 --- sys/fs/nfsclient/nfs_clvnops.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/sys/fs/nfsclient/nfs_clvnops.c b/sys/fs/nfsclient/nfs_clvnops.c index 795a8d106051..193d8b6cd5eb 100644 --- a/sys/fs/nfsclient/nfs_clvnops.c +++ b/sys/fs/nfsclient/nfs_clvnops.c @@ -3896,11 +3896,15 @@ nfs_allocate(struct vop_allocate_args *ap) mtx_lock(&nmp->nm_mtx); nmp->nm_privflag |= NFSMNTP_NOALLOCATE; mtx_unlock(&nmp->nm_mtx); - error = EINVAL; + error = EOPNOTSUPP; } } else { + /* + * Pre-v4.2 NFS server that doesn't support it, or a newer + * NFS server that has indicated that it doesn't support it. + */ mtx_unlock(&nmp->nm_mtx); - error = EINVAL; + error = EOPNOTSUPP; } if (attrflag != 0) { ret = nfscl_loadattrcache(&vp, &nfsva, NULL, 0, 1);