From nobody Sun Nov 02 13:53:47 2025 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4czx5R58QSz6FnXR; Sun, 02 Nov 2025 13:53:47 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R12" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4czx5R4Lwlz3mkW; Sun, 02 Nov 2025 13:53:47 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1762091627; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=sGS0lPdO84F38UiO76mQZ3M0v6ADx2aozRpTl4Bl4BY=; b=OZ1ZqdtqnLbb4Al4mE1IsKAjKPMv3BdeD4KUtcchkQXvfBxlJC3hRN1xJMGFsPVt8lPxV/ JOX4s4bJMdwr3RpQHAEATvOTsN+KPjXpr9vl2nkNgbLxWAkXT3R6VFe5JQ5TJ+I0cJFKnI 6flA6LUMNnv19QC2FGNHymWrGaCXIvvTQS85+/vcudW7MEsDE/9wwesx9xNZ6HcySOlQXQ xbMdOFgblp002Hy/yHJegseZ5KBafHzEAtgbWNR97TLNXzfxX4/Ac7OIK2j/aAvnw25Mv0 LdWmsfPOTBYqo/p1azQHYEdkzucF00xuGc4s+NH2O8UV8x9B6nwoC9hpjOibGA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1762091627; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=sGS0lPdO84F38UiO76mQZ3M0v6ADx2aozRpTl4Bl4BY=; b=I9HA0V9LfFnJK3b0O89rS2EuYdKNj+j2euMVihhXntMs1rrjOqa45OnByASgQgoMKIiVCW NRW0VqnmoG1MfIblIyxFazzpeyvH3YIuUrxNCS8Ui1dBrHsXxUKAHLS4AP8+oS7WYIoCeW HJmxTJ7afnRPpkN8rAjTV94cKiTU6T/ef31JrrgCnGODje5y+b0KOJ1JXLNrtxJAXvttZ8 16VdcE31vTm4CBMjT/zebXsVEu/2wWM7sgRLbU6Cqg2u29yAN4pHDwW3ELk2+Fj5gLgeL4 WiQg0CY2gdu0O4M2eQo4S8nPM3XThSdBoVG3a6ioaVlWKUs8DoAqNn9KgTWYfA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1762091627; a=rsa-sha256; cv=none; b=sJ2DDgjyrl12jhDzvkivz0lkZh36mjTq6O1IniCWyaf1o8V3pec1xYTERiDqKtU6Y0aTLz ta2HwBtScB0X3bRcXgtHm7CAg+O/dgoQqEuHKvM9Rgwd5EApZgYUzX8A9SXLSGZtMKaBeA jJnELRLMFmh7ubxmqZyGlKr+rz7NUb285GJIqX1GRfswD2srpFu3WxxOZiM2OrLT9Cbqtu Z9vztWY8kGEAu0WCO8mQ2jnYuu64ajK5YANr2ebwFiJeq3E7WTXtpHDURPencMwn7QFqc2 vTsHDImnz2Dat6K7dNXpqjpXo1M96uJJpBimJP71j/I+T/NCPZzra6XoeaKuHQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4czx5R3yDhzChj; Sun, 02 Nov 2025 13:53:47 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 5A2DrlLT003015; Sun, 2 Nov 2025 13:53:47 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 5A2Drl8X003012; Sun, 2 Nov 2025 13:53:47 GMT (envelope-from git) Date: Sun, 2 Nov 2025 13:53:47 GMT Message-Id: <202511021353.5A2Drl8X003012@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Dag-Erling =?utf-8?Q?Sm=C3=B8rgrav?= Subject: git: a38c2f99f81c - main - tzcode: Fix early tz change detection List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: des X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: a38c2f99f81c2fc35c8ca209931c1c46e3e81023 Auto-Submitted: auto-generated The branch main has been updated by des: URL: https://cgit.FreeBSD.org/src/commit/?id=a38c2f99f81c2fc35c8ca209931c1c46e3e81023 commit a38c2f99f81c2fc35c8ca209931c1c46e3e81023 Author: Dag-Erling Smørgrav AuthorDate: 2025-11-02 13:51:42 +0000 Commit: Dag-Erling Smørgrav CommitDate: 2025-11-02 13:51:42 +0000 tzcode: Fix early tz change detection Assume tzdata is not fresh if last_checked is zero, as comparing the current time to last_checked less than __tz_change_interval after boot may produce a false negative. While here, invert the return value from tzdata_is_fresh() to better match its new name (it was previously called recheck_tzdata(), so zero for fresh and non-zero for stale made sense, but it doesn't now). PR: 269207 MFC after: 3 days Reviewed by: imp Differential Revision: https://reviews.freebsd.org/D53502 --- contrib/tzcode/localtime.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/contrib/tzcode/localtime.c b/contrib/tzcode/localtime.c index 1668475ea646..58099d234e2b 100644 --- a/contrib/tzcode/localtime.c +++ b/contrib/tzcode/localtime.c @@ -1583,15 +1583,15 @@ tzdata_is_fresh(void) struct timespec now; if (clock_gettime(CLOCK_MONOTONIC, &now) < 0) - return 0; + return 1; - if ((now.tv_sec - last_checked >= __tz_change_interval) || - (last_checked > now.tv_sec)) { + if (last_checked == 0 || last_checked > now.tv_sec || + now.tv_sec - last_checked >= __tz_change_interval) { last_checked = now.tv_sec; - return 1; + return 0; } - return 0; + return 1; } #endif /* DETECT_TZ_CHANGES */ @@ -1642,7 +1642,7 @@ tzset_unlocked_name(char const *name) ? lcl_is_set < 0 : 0 < lcl_is_set && strcmp(lcl_TZname, name) == 0) #ifdef DETECT_TZ_CHANGES - if (tzdata_is_fresh() == 0) + if (tzdata_is_fresh()) #endif /* DETECT_TZ_CHANGES */ return; # ifdef ALL_STATE