git: aeb446be4ea2 - main - style: Use static consistently

From: Warner Losh <imp_at_FreeBSD.org>
Date: Fri, 30 May 2025 15:57:25 UTC
The branch main has been updated by imp:

URL: https://cgit.FreeBSD.org/src/commit/?id=aeb446be4ea2d214ee48b82bcefd1828c7c256c5

commit aeb446be4ea2d214ee48b82bcefd1828c7c256c5
Author:     Warner Losh <imp@FreeBSD.org>
AuthorDate: 2025-05-30 14:14:50 +0000
Commit:     Warner Losh <imp@FreeBSD.org>
CommitDate: 2025-05-30 15:56:50 +0000

    style: Use static consistently
    
    C doesn't require that we have static on both the declaration and
    definition of a function. But stylistically, FreeBSD does. Make that
    so. Also make a function static that wasn't because, it seems, that
    static and struct look a lot alike in a column of text.
    
    Sponsored by:           Netflix
    Reviewed by:            tsoome, jhibbits
    Differential Revision:  https://reviews.freebsd.org/D50588
---
 stand/common/module.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/stand/common/module.c b/stand/common/module.c
index ed57ebf0caf8..bc06ba01fa06 100644
--- a/stand/common/module.c
+++ b/stand/common/module.c
@@ -66,7 +66,7 @@ static char *			mod_searchmodule_pnpinfo(const char *bus, const char *pnpinfo);
 static void			file_insert_tail(struct preloaded_file *mp);
 static void			file_remove(struct preloaded_file *fp);
 static void			file_remove_tail(struct preloaded_file *fp);
-struct file_metadata*		metadata_next(struct file_metadata *base_mp, int type);
+static struct file_metadata *	metadata_next(struct file_metadata *base_mp, int type);
 static void			moduledir_readhints(struct moduledir *mdp);
 static void			moduledir_rebuild(void);
 
@@ -554,7 +554,7 @@ command_pnpautoload(int argc, char *argv[])
 /*
  * File level interface, functions file_*
  */
-int
+static int
 file_load(char *filename, vm_offset_t dest, struct preloaded_file **result)
 {
 	static int last_file_format = 0;
@@ -915,7 +915,7 @@ file_findfile(const char *name, const char *type)
  * Find a module matching (name) inside of given file.
  * NULL may be passed as a wildcard.
  */
-struct kernel_module *
+static struct kernel_module *
 file_findmodule(struct preloaded_file *fp, char *modname,
 	struct mod_depend *verinfo)
 {
@@ -1047,7 +1047,7 @@ file_addbuf(const char *name, const char *type, size_t len, void *buf)
 	return(0);
 }
 
-struct file_metadata *
+static struct file_metadata *
 metadata_next(struct file_metadata *md, int type)
 {