From nobody Wed May 21 17:10:30 2025 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4b2dGb1fQmz5wD9Z; Wed, 21 May 2025 17:10:31 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4b2dGb12fZz3kC3; Wed, 21 May 2025 17:10:31 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1747847431; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=ZPN/LaaM06r8VapgKuque+mEYaz+481MIA0HeJRx6V0=; b=InQxjljTrpPJ5d4Cpzb4Mes8ecrftlkHLNz4hhkTxKr7MlnygxU8t5muICjmI/ZfqNgepl 5SkDDoKYsNyNIBVBNd7ERXJKPqssUtqeROwc4BJZQF+eVklqJu5VTMOiN2u4vIw81Q5qvs 8jqBMlVb7p/VgSAhYnlavn7JDlN41JB1S/o6xxu8pBMPBpC9CPJTCnLi5EXzhOfOh1pmKj mUIY0WeLy1bv3Os4XtBknn2ovpXdJyd9Vd1bJGvWtaMBTpdPfPxPIJNqV/Yo60kTdiuEWF qPzQrjgtqrVwZaZLpK+lKAIpp+piGYxkoXfuCoIXi1F7tkPRFm4mimK62hfTtg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1747847431; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=ZPN/LaaM06r8VapgKuque+mEYaz+481MIA0HeJRx6V0=; b=Z6qMuvQgoEjzS2SaXP6iA+gBtN5/qr69KMNJxrtK1pjaUkCOd6B6PEexJoK5qB0U6U+glj klwnXQGoCHsu9oN2J7XBfLOQEdQriN0Mpa3kjBAvl4auTOXa/GKkEBFWZcJzsBs/mJ9a9L n770PE0ahLvVYrmCvch+bHqboUyPiAp5SzD/JiGhlxz+FSgfm2C0j9qRVHm0aIbeCwrksp 5Zkp1pU13laqeOX7De4oHTmLYriB59pHM0ILzRXaXcEm1aQoEElsA6LkrDZEmahAMbfT7D K516QiGHOylZwYxLEiFlLUzjItvmvc5BvYDe0rsk4nkLY+wwUQXOKglF3nMLQw== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1747847431; a=rsa-sha256; cv=none; b=gbmLHEPn+alkbxwxI3moBixAwhfX58FlDODoqYoknG+jyJoXm+Rsgz28mIeNSXv8E+EyOn 34xz5Row3BhOlw0q03EhXJqOHbbyAovEa01T+41uGpH0VDeGysTxKAcg24isUeXMHxw3mJ l1IDzJVJHOVY/fPCjtTVKTb8lVzj/5AGZpMQttZhAm1uOcNuCFDiaK2kANV/K0lxH0kJDh V0a+Yns6M2tmwuwlu7wpuKSfs+TCdzrM5DTB3B+wEy5DytFpDV/KHKoki7ZeRckhTeKDLr 8lBpWGy65/dUeGRXsU8R/sf4WVa+ttugqJr2NWL/W8+RQgFeqGaPulhmv62HcQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4b2dGb0d72zkgW; Wed, 21 May 2025 17:10:31 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 54LHAUY3009599; Wed, 21 May 2025 17:10:30 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 54LHAUpN009596; Wed, 21 May 2025 17:10:30 GMT (envelope-from git) Date: Wed, 21 May 2025 17:10:30 GMT Message-Id: <202505211710.54LHAUpN009596@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Michael Tuexen Subject: git: e6cb445098b1 - stable/14 - sctp: initilize local address flags correctly List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: tuexen X-Git-Repository: src X-Git-Refname: refs/heads/stable/14 X-Git-Reftype: branch X-Git-Commit: e6cb445098b156157f5b1926642ae6f86bf57f34 Auto-Submitted: auto-generated The branch stable/14 has been updated by tuexen: URL: https://cgit.FreeBSD.org/src/commit/?id=e6cb445098b156157f5b1926642ae6f86bf57f34 commit e6cb445098b156157f5b1926642ae6f86bf57f34 Author: Michael Tuexen AuthorDate: 2025-05-04 22:41:49 +0000 Commit: Michael Tuexen CommitDate: 2025-05-21 17:10:09 +0000 sctp: initilize local address flags correctly Use the same routine for initilizing as for updating. (cherry picked from commit 6ab4b0c0df57775fd6c288a0b7d0f5d2cad73481) --- sys/netinet/sctp_pcb.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/sys/netinet/sctp_pcb.c b/sys/netinet/sctp_pcb.c index b0686180a7af..7b155eed896a 100644 --- a/sys/netinet/sctp_pcb.c +++ b/sys/netinet/sctp_pcb.c @@ -453,6 +453,7 @@ sctp_add_addr_to_vrf(uint32_t vrf_id, void *ifn, uint32_t ifn_index, SCTPDBG(SCTP_DEBUG_PCB4, "Clearing deleted ifa flag\n"); sctp_ifap->localifa_flags = SCTP_ADDR_VALID; + sctp_gather_internal_ifa_flags(sctp_ifap); sctp_ifap->ifn_p = sctp_ifnp; atomic_add_int(&sctp_ifap->ifn_p->refcount, 1); } @@ -475,6 +476,7 @@ sctp_add_addr_to_vrf(uint32_t vrf_id, void *ifn, uint32_t ifn_index, } else { /* Repair ifn_p, which was NULL... */ sctp_ifap->localifa_flags = SCTP_ADDR_VALID; + sctp_gather_internal_ifa_flags(sctp_ifap); SCTPDBG(SCTP_DEBUG_PCB4, "Repairing ifn %p for ifa %p\n", (void *)sctp_ifnp, (void *)sctp_ifap); @@ -499,7 +501,7 @@ sctp_add_addr_to_vrf(uint32_t vrf_id, void *ifn, uint32_t ifn_index, sctp_ifap->ifa = ifa; memcpy(&sctp_ifap->address, addr, addr->sa_len); sctp_ifap->localifa_flags = SCTP_ADDR_VALID | SCTP_ADDR_DEFER_USE; - sctp_ifap->flags = ifa_flags; + sctp_gather_internal_ifa_flags(sctp_ifap); /* Set scope */ switch (sctp_ifap->address.sa.sa_family) { #ifdef INET