From nobody Thu May 15 18:17:51 2025 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Zyz341Vgcz5wj43; Thu, 15 May 2025 18:17:52 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Zyz335rk5z3Fby; Thu, 15 May 2025 18:17:51 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1747333071; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=EWFexlDfkdbCGQWUxobCzOAaYsEnSCHxamz5RvwNKsc=; b=UmZw4j01joGk8xeYEJ7L65XPyTXLVXIBoyC2VlDrsPpMcXO8zJY6EQWSqd2OhCvj+2SU8J VtbhsHpSzHDbu47v/DwcxshiBMQXOe6zVoD2g7nl46wpROj/xL9DLSwRzHFV69LN8BWiZ4 p/WD9hpkPoBwAwdrCNXoUKlJ+AHxECHiPdOBqSajH8MWkD0C8MwwB7w8V2kYW9TNzyoOSs BaIAcD//ITHaO4EDRhFbgL/A4XGXNR5v8959+5FE0gwzVetdH6oQDTmC7kCnX5yGLQlcCQ B5G9kUk+jPglr63sitxXoTngpJUf6ukHI3JwInd6NB63qafz7CLIVMyZcq/Ctw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1747333071; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=EWFexlDfkdbCGQWUxobCzOAaYsEnSCHxamz5RvwNKsc=; b=gCxbpjg/mS3s5R63z8LFd4SFN+PwCujyWsFy3a7leWAlxWe6Nl4N9/2GpPvI7Z0ZtuX2RI Hk8mrQTM6+uh6ludUB5X14TWFeP+zRqCqCLKg5qgrGoPvGw/cxDOqjQaPfmIbq/TwDCfOJ uFrCNiD2tp2CWAAmxkAUWmH2juy+k6/V9I3tzrLplqAaORobCTPtcpTFcSfJfsh80mFEfd TklLHkKxLmIbJ1aqOm/+K5z9C3CP/eKd+Jp7qJx75XtQfTl9mA8d+hL4CNjUHSJQYXS4vi DCgXWiGyrb2wl0XbqKVqkU1V4IvBDvmauiRvOQOiuNws9oy4htAQuythtTS2HQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1747333071; a=rsa-sha256; cv=none; b=cetBQez5PAjHkW5ByQvqSFAMDqctZPLMlOeiz8QP/BVetFNkDUGj/ZGc/W5I7aV8IszfK0 3a9yVANmCk+dvOIH3Sl8K1cLbMtk4rS2BiETnR81RfieFfa8RrzpFUCSa9GaGh9vGKN1+o c4o+/Lnpy3E3o8xb32kETNyfoCbQ1E3tMzJFtVBm0TYg3KbY1b3kipgexTjRvwZxWSKUn8 rDxfoLuFkQ6q0CdBkyCwpCnjXz+/HNJd3GRXrvCPxTB131LP3JGFIlzlbWgOzPMAoSy1FB gaqrM6pL3G0j9ieyzXbEfBoy1t6qS1BygojltN7EJQ439raGkpSkBMdE8Xajzw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4Zyz335LnNzD8d; Thu, 15 May 2025 18:17:51 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 54FIHpUk090268; Thu, 15 May 2025 18:17:51 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 54FIHpsN090263; Thu, 15 May 2025 18:17:51 GMT (envelope-from git) Date: Thu, 15 May 2025 18:17:51 GMT Message-Id: <202505151817.54FIHpsN090263@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Vladimir Kondratyev Subject: git: 7798b72a9000 - stable/14 - iichid(4): Do not send packets read in interrupt handler to hidbus List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: wulf X-Git-Repository: src X-Git-Refname: refs/heads/stable/14 X-Git-Reftype: branch X-Git-Commit: 7798b72a90004cab0e6790060a18c00b87750341 Auto-Submitted: auto-generated The branch stable/14 has been updated by wulf: URL: https://cgit.FreeBSD.org/src/commit/?id=7798b72a90004cab0e6790060a18c00b87750341 commit 7798b72a90004cab0e6790060a18c00b87750341 Author: Vladimir Kondratyev AuthorDate: 2025-04-28 21:39:28 +0000 Commit: Vladimir Kondratyev CommitDate: 2025-05-15 18:13:41 +0000 iichid(4): Do not send packets read in interrupt handler to hidbus if no hidbus and hidbus clients were attached and opened by users. iichid(4) enables interrupts before hidbus is attached and sending packets to it at this time leads to panic at boot time. Fixes: daa098cc37b9 ("Wait for RESET command response while attaching") Tested by: dch PR: 286045 MFC with: daa098cc37b9 (cherry picked from commit 2abdb305bd0c105226f6a71a8d3dc89698c9ef6b) --- sys/dev/iicbus/iichid.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sys/dev/iicbus/iichid.c b/sys/dev/iicbus/iichid.c index 0e4aa649ff48..fc905ca48b7e 100644 --- a/sys/dev/iicbus/iichid.c +++ b/sys/dev/iicbus/iichid.c @@ -630,7 +630,7 @@ iichid_intr(void *context) error = iichid_cmd_read(sc, sc->intr_buf, sc->intr_bufsize, &actual); THREAD_NO_SLEEPING(); if (error == 0) { - if (sc->power_on) { + if (sc->power_on && sc->open) { if (actual != 0) sc->intr_handler(sc->intr_ctx, sc->intr_buf, actual);