git: 6f8fbb2adfde - main - usb/quirks: Remove overly broad quirks
- Go to: [ bottom of page ] [ top of archives ] [ this month ]
Date: Wed, 07 May 2025 21:37:19 UTC
The branch main has been updated by imp:
URL: https://cgit.FreeBSD.org/src/commit/?id=6f8fbb2adfde9eeb2b13e693e8be19a08e9d0ad4
commit 6f8fbb2adfde9eeb2b13e693e8be19a08e9d0ad4
Author: Warner Losh <imp@FreeBSD.org>
AuthorDate: 2025-05-07 16:08:51 +0000
Commit: Warner Losh <imp@FreeBSD.org>
CommitDate: 2025-05-07 21:36:55 +0000
usb/quirks: Remove overly broad quirks
Now that we have a safe way to detect the vast majority of problems
with SYNCHRONIEZ CACHE, and since I have devices from many of these
vendors that work just fine (one of which will hang if you send it a
SYNCHROMIZE CACHE), I think these should all be reverted. The details
of when they were added are sketchy, the age of the devices in
question means these vendors have many generations of products after
and the general over-quirking of SYNCHRONIZE CACHE all point to just
removing them and adding back specific quirks should any need arise
after trying other means to debug.
The APPLE quirk was added because the autoquirk code would hang an ipod
with RockBox with a reset loop in the firmware. Since it was quirked, it
disabled the autoprobe and started working. Now that we've disabled the
autoprobe, we can remove it for sure.
Sponsored by: Netflix
Differential Revision: https://reviews.freebsd.org/D49478
---
sys/dev/usb/quirk/usb_quirk.c | 10 ----------
1 file changed, 10 deletions(-)
diff --git a/sys/dev/usb/quirk/usb_quirk.c b/sys/dev/usb/quirk/usb_quirk.c
index 653395bbdac9..64396918a3d7 100644
--- a/sys/dev/usb/quirk/usb_quirk.c
+++ b/sys/dev/usb/quirk/usb_quirk.c
@@ -565,16 +565,6 @@ static struct usb_quirk_entry usb_quirks[USB_DEV_QUIRKS_MAX] = {
USB_QUIRK(PLOYTEC, SPL_CRIMSON_1, UQ_CFG_INDEX_1),
USB_QUIRK(ROLAND, UA25EX_AD, UQ_AU_VENDOR_CLASS),
- /*
- * Quirks for manufacturers which USB devices does not respond
- * after issuing non-supported commands:
- */
- USB_QUIRK_VO(ALCOR, UQ_MSC_NO_SYNC_CACHE, UQ_MSC_NO_TEST_UNIT_READY),
- USB_QUIRK_VO(APPLE, UQ_MSC_NO_SYNC_CACHE),
- USB_QUIRK_VO(FEIYA, UQ_MSC_NO_SYNC_CACHE),
- USB_QUIRK_VO(REALTEK, UQ_MSC_NO_SYNC_CACHE),
- USB_QUIRK_VO(INITIO, UQ_MSC_NO_SYNC_CACHE),
-
/* DYMO LabelManager Pnp */
USB_QUIRK(DYMO, LABELMANAGERPNP, UQ_MSC_DYMO_EJECT),