git: 43030e34453b - main - umass: Be more consistent about how we fail bad commands
- Go to: [ bottom of page ] [ top of archives ] [ this month ]
Date: Wed, 07 May 2025 21:37:13 UTC
The branch main has been updated by imp: URL: https://cgit.FreeBSD.org/src/commit/?id=43030e34453bf5cc92c6cd62f1b07c246eeec3ba commit 43030e34453bf5cc92c6cd62f1b07c246eeec3ba Author: Warner Losh <imp@FreeBSD.org> AuthorDate: 2025-05-07 16:07:40 +0000 Commit: Warner Losh <imp@FreeBSD.org> CommitDate: 2025-05-07 21:36:55 +0000 umass: Be more consistent about how we fail bad commands Elsewhere, if we fail a command, we use SCSI code ILLEGAL REQUEST/24/00, but here we were using the CAM code for illegal request. Sponsored by: Netflix Differential Revision: https://reviews.freebsd.org/D49473 --- sys/dev/usb/storage/umass.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/sys/dev/usb/storage/umass.c b/sys/dev/usb/storage/umass.c index a5f1c891a509..04a0157b14ce 100644 --- a/sys/dev/usb/storage/umass.c +++ b/sys/dev/usb/storage/umass.c @@ -2890,10 +2890,7 @@ umass_std_transform(struct umass_softc *sc, union ccb *ccb, } if (sc->sc_transform(sc, cmd, cmd_len)) return (true); /* Execute command */ - - xpt_freeze_devq(ccb->ccb_h.path, 1); - ccb->ccb_h.status = CAM_REQ_INVALID | CAM_DEV_QFRZN; - xpt_done(ccb); + umass_cam_illegal_request(ccb); return (false); /* Already failed -- don't submit */ }