From nobody Mon May 05 13:29:02 2025 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Zrj6h6d2Sz5vWFZ for ; Mon, 05 May 2025 13:29:16 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-pg1-x535.google.com (mail-pg1-x535.google.com [IPv6:2607:f8b0:4864:20::535]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "WR4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Zrj6h0KMQz3tdZ for ; Mon, 05 May 2025 13:29:15 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Authentication-Results: mx1.freebsd.org; none Received: by mail-pg1-x535.google.com with SMTP id 41be03b00d2f7-7fd35b301bdso5290763a12.2 for ; Mon, 05 May 2025 06:29:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20230601.gappssmtp.com; s=20230601; t=1746451755; x=1747056555; darn=freebsd.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=HHftlqA2UFwdJ3edysHrE0hA+iNYug0DSD6mic0LMi0=; b=RA4tv+AtpT3xg0ZjuThHjONP55dYn/rCZR0vh/4biPrw5Ychwb+8jEW59sKoN2amzy VhaaiUT5gF7I5l+3PZzdGse49wYC6V+REJgMDDqwJ9PQChdqAtL2WIdTEiIOycztlyY/ y1/3j67F/4MOqUEUUL2pdx/tubBcS8LKUmAX765nMFzN5S/JI7C0w+2mmQR1c+W3Epfm YKfSHrhaSK6uM2V/KvaFg4fiHDZivAyVblDi2RS75hAgikzULJ8mfGNp2DtT9HuAyT1b WwmZbRMzHqulbXd7nBXJ8WqiqQ5T6C8C4aiV52Tmo7z2ip94pzfxGgwYkFG9zGcgb999 bz7g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1746451755; x=1747056555; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=HHftlqA2UFwdJ3edysHrE0hA+iNYug0DSD6mic0LMi0=; b=tH0y+pNMbDUW7n6aN3cSonL99qo+jp5q3oFVbgWN7s3bqGEqw1P/JoH17Zyaz0piGW /2JAHxeAY+x8RmdbGXFYc/a/+h0e8I7xslg42TCza/JiZj2VqDgysp9eZvJirojYN+zh potB8Rg7FpF4yxKwnEOlffqmARMMGyGb+c3X9CaCD/QqLAPE3NPFHddFi7weah2ebxfI qlF+/8V4+ezffei3ZhpqjeaFUNvmS3nDv0pyf0jSWLPe8WIRzQOuCRK7cOJMxTcn3s6N 6GuiAfJxY4HJmFr3T47lIyKsiWq9Cx9RpAqV3qDI72GOIzDg/IfBF0dwSvsDhcLgF8ro W7FQ== X-Forwarded-Encrypted: i=1; AJvYcCW8u6bI6N4sxMGPpHWAHqZVr0Ago1WI/Z3bvneBV4qfmRcWdCvZAz1Vq92fk8ccRyuiBvvqYaNUlCWfWYF/z6O8K0Vl@freebsd.org X-Gm-Message-State: AOJu0YzaJHexbqgfqFsoNrJ5dRoc5IwNeotgFrsoggsKnnXneLqpaSLS Je6ge1gef6LXRfyndE8DhqcEQbts9/Tjo1NoMZjmIKC31o3wo31DTDfqpgTJaAJokyixvWqvzfU NH19wjTT8n3qDT+HkEGvxUtzmdjdRHstu6bwr5G6hILmIqQmG X-Gm-Gg: ASbGnctKz52jfLFZFbMUCl0NmsGCN9p/FiR8qqMm0yXE1swvpY7VV8VZpFYIMErdpHr 3TqQ9N3uvLKRdpuTDpNs6azo0JM1RfmOINWtGD/UzHWumVdfI6Zn8h8hmqtuCJtdHpE5bW/9+t3 cEMnepqmgckZ9naEA5zpedMYmIx3qxnzk1Kk0qw0XiVhRIDPleft26 X-Google-Smtp-Source: AGHT+IGseVImANxbT/1G6M8buXZCoIa5HCob2DZWVLuguAIT9yAYQpRj1fVyOTuQlCQPKg3g2r2wtYZF1EEtCoQi4Ug= X-Received: by 2002:a17:90b:2dcb:b0:305:2d68:8d57 with SMTP id 98e67ed59e1d1-30a619549c1mr10665826a91.5.1746451754627; Mon, 05 May 2025 06:29:14 -0700 (PDT) List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 References: <202505011951.541JpiQV068751@gitrepo.freebsd.org> <2988597.slGk94SIus@ravel> In-Reply-To: <2988597.slGk94SIus@ravel> From: Warner Losh Date: Mon, 5 May 2025 07:29:02 -0600 X-Gm-Features: ATxdqUHeDAjZw66mi_dilkF-TpxtMrqPolAW_87TV4AU5epZl3SLx4YnX_4zRFo Message-ID: Subject: Re: git: 154ccb0196cd - stable/14 - ps(1): Update some options' conformance/practice comments To: Olivier Certner Cc: "Piotr P. Stefaniak" , src-committers , "" , dev-commits-src-branches@freebsd.org Content-Type: multipart/alternative; boundary="00000000000073c2fb0634637cc4" X-Rspamd-Queue-Id: 4Zrj6h0KMQz3tdZ X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US] X-Spamd-Bar: ---- --00000000000073c2fb0634637cc4 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Mon, May 5, 2025, 6:13=E2=80=AFAM Olivier Certner wro= te: > > >- /*- > > >+ /* > > > > No opinion on which it should be, but the minus character is meaningful > > within the context of indent(1) - it won't reformat "block" comments. > > Thanks for pointing that out, I didn't know. I think removing them was > OK, as these block comments are really nothing special. Actually, I > probably should have reformatted them to eliminate the margin for all but > the first line. > Almost nobody uses indent these days on a regular basis. We can drop it for that reason alone, even if the comments were formatted by hand... we likely need to start tagging those with clang format tags.. Warner --00000000000073c2fb0634637cc4 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


On Mon, May 5, 2025, 6:13=E2=80=AFAM Olivier Certner &= lt;olce@freebsd.org> wrote:
&g= t; >-=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 /*-
> >+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 /*
>
> No opinion on which it should be, but the minus character is meaningfu= l
> within the context of indent(1) - it won't reformat "block&qu= ot; comments.

Thanks for pointing that out, I didn't know.=C2=A0 I think removing the= m was OK, as these block comments are really nothing special.=C2=A0 Actuall= y, I probably should have reformatted them to eliminate the margin for all = but the first line.

Almost nobody uses indent these days on a regular basis.= We can drop it for that reason alone, even if the comments were formatted = by hand... we likely need to start tagging those with clang format tags..

Warner
--00000000000073c2fb0634637cc4--