From nobody Thu Mar 27 23:28:20 2025 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4ZP0Fy0Y1Hz5s4ph; Thu, 27 Mar 2025 23:28:22 +0000 (UTC) (envelope-from brooks@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4ZP0Fx6lHwz3v7j; Thu, 27 Mar 2025 23:28:21 +0000 (UTC) (envelope-from brooks@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1743118102; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=MyxDr1komSpsGkHY3ObYSf8LBjk3JbT6BOmOiwBIwy8=; b=xmtEx96mjDwqdMdUxpyX6bI9dNzoGRpGKD4PvbmfXxjY0bFF/cK91D7pV9Fjgw46xXK33s zyv/347AN69IiFxGLD9ruFEA4Lcle9lv3MIaF2eQHrwOTMhQEQxv8luiFzmUdnXfkL8K8j 0LrA9VkDQvpz0itb0kQL5gMEdjtqdQecccmVcst0DSpHiRfRK/3vISw80/a3Ki0qaAonYX 01QSO8tEbAAHr9gK6VETxpY8loZrhy0o4Ij1AxJ9xDfUcBwqlWxfECt4yxpl+fBWwIIk1B Y62e4iTi7HEJD7Z2mUAPLGsBp/BobfOTAMs274K8EtqYmkQWiD45wCCrSmf1Jw== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1743118102; a=rsa-sha256; cv=none; b=wb99nw9jwnUvjou+rpI1owqxfiZ7GTi+baa/8JzQvst6pV8HOaBtFwLOOHwrFqWFCM7mLS Jh1MkIFVMAPqBFDezlwxPQEnqHS5/elFTK5ZIK4SYFuf0rBZQT3LQa+z2GVAMF4BKQuVpM X9jsthRg+hfEF+a5CSww/sXPk8UsVdX8ii4zn2AFFWQhO1tZlYQs52bSKY+PKrFx3S4bih SLbinx5agEWbCJK3r6NFiopXUp5BNub9JhjnWfvn1NBmt3l5lOhUsM6fXxlh2JSudYy1Hp zzo51EGW3PLayDQ+aFn4MsqxPvJ/AkioTHvMxTBKODEpT8eaorVRtm0Z2Ot3pA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1743118102; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=MyxDr1komSpsGkHY3ObYSf8LBjk3JbT6BOmOiwBIwy8=; b=uFv2XL0ZgK0pL7u3BkS/EjgQQXrBHVb+as7snX+pJdtYLNSeTUDe2KYhvRSWezVy9nezuk r2ZoolhZfhZk+WMJdXqgC3sHQyqZkjswI8oUaTSMc92xQzHDQzgoSqFsHglR3XL9x0tXCZ dAonmTx3DxS3jqpOpWnoSn7G+tntmFG8neQ2FVRpUkCPrIfbeECdEy8BwhoDi64kRHxFMB ehWjsbfOuJnwrOurZGDmVLXYtKElB4+Dd21oO8tHSWatjz1WP9EaM820QNMEFo5vjRK8to iJwdhjbMzLjppZ9MLAKVfYaDEQrdBEqQ88CGFkifmvhAi5RQRC/raSLF/6WDHA== Received: from spindle.one-eyed-alien.net (spindle.one-eyed-alien.net [199.48.129.229]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: brooks/mail) by smtp.freebsd.org (Postfix) with ESMTPSA id 4ZP0Fx5J1bz10Dn; Thu, 27 Mar 2025 23:28:21 +0000 (UTC) (envelope-from brooks@freebsd.org) Received: by spindle.one-eyed-alien.net (Postfix, from userid 3001) id E90CA3C01A0; Thu, 27 Mar 2025 23:28:20 +0000 (UTC) Date: Thu, 27 Mar 2025 23:28:20 +0000 From: Brooks Davis To: Colin Percival Cc: src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: c41ba99779d0 - main - release/vm: partially support NO_ROOT Message-ID: References: <202503122107.52CL746X008573@gitrepo.freebsd.org> <01000195d9c3a499-ccd7c1c1-93d8-4971-acaa-6ba42c4a9a32-000000@email.amazonses.com> List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <01000195d9c3a499-ccd7c1c1-93d8-4971-acaa-6ba42c4a9a32-000000@email.amazonses.com> On Thu, Mar 27, 2025 at 10:40:32PM +0000, Colin Percival wrote: > On 3/12/25 14:07, Brooks Davis wrote: > > commit c41ba99779d0431c37ac06a674e7744d15de8045 > > Author: Brooks Davis > > > > release/vm: partially support NO_ROOT > > --- a/release/Makefile.vm > > +++ b/release/Makefile.vm > > @@ -126,6 +130,7 @@ cw-${_CW:tl}-${_FS}-${_FMT}: ${QEMUTGT} > > env TARGET=${TARGET} TARGET_ARCH=${TARGET_ARCH} SWAPSIZE=${SWAPSIZE} \ > > QEMUSTATIC=${QEMUSTATIC} \ > > WITHOUT_QEMU=${WITHOUT_QEMU:Dtrue} \ > > + NO_ROOT=${NO_ROOT:Dtrue} \ > > ${.CURDIR}/scripts/mk-vmimage.sh \ > > -C ${.CURDIR}/tools/vmimage.subr -d ${.OBJDIR}/${.TARGET} -F ${_FS} \ > > -i ${.OBJDIR}/${_CW:tl}.${_FS}.${_FMT}.img -s ${VMSIZE} -f ${_FMT} \ > > diff --git a/release/tools/basic-ci.conf b/release/tools/basic-ci.conf > > This is broken, since src/Makefile.incl assumes that NO_ROOT being set, > including to an empty string, means we want no-root behaviour. As far > as I can tell this hasn't broken anything except that VM images are > shipping with a /METALOG file inside them, but it could probably cause > worse problems later if it's not fixed before more no-root work happens. Oops, that is indeed the wrong substitution. I've posted a fix in https://reviews.freebsd.org/D49544 -- Brooks