From nobody Mon Mar 24 06:12:24 2025 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4ZLjQ40F3Pz5rSRS; Mon, 24 Mar 2025 06:12:28 +0000 (UTC) (envelope-from glebius@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4ZLjQ36Pjtz3j0d; Mon, 24 Mar 2025 06:12:27 +0000 (UTC) (envelope-from glebius@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1742796747; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=LBW04QgxNWEkXfIN7j747Ma/OHOnhh2c01/Dc4XoggM=; b=MEQYfNP+J4kmjoj0Ze+K+g7nVwadr55qseqRKExS0a9kHlq5IszxCBGkWTzZIRrUxEIA8s szzbhBBmF+IRkEtO3r//wIufFCk8F2xPSonFr6NfVjekIGdQdBpeiKRudShDSbn0RIpRlz ogMOQy0tcdoVdGGUQ1CV8hEZlz4D5n5rIe2QyoF2WpoWO2SEwKds7jDCu0F1/lZwcqT4p3 aFnjPzlVGoUAwdE49SK7euPgBvudqN6TNP/zRy1ka0fnPsXa9b99bPyTSNZs7VWBnQ5X4L dcfene3N6yxUMFlnN6GUSHArSfmW0PEqs6JGB+r4p1BD1hLz+/4T/8tJOxNjiA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1742796747; a=rsa-sha256; cv=none; b=J3PoHfFXH29Ub64Q56Sfpy+11uBkEq7LRbmGCTgdM+qKBU2N4EYYA51xXVqd3s/Bg/6csf DetM5JNpqwDWK2CavFqozSnPhT89RbXoo0mY/GI4RtkeFtIxsOeVn5wV6uSXp7ggFOkhWo MetkEt+MMlT0JWUVIn2AQSvw7IQnfxcXqHC/ePwxmuFJcf21lQvIVWVChpE/SNYDyrUyI0 rcmVRYMSctCTBjSg25QvV7HjatKN+hZyd8kaiuJzF/yW9MLLtUaZYgpFtihcn2h5qyECeE 8THpAmeI6oJt6SeS9QuGc5dk+aNGM945aKpWJQQHA6Ib6M2YKebmJaGCI4tYgQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1742796747; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=LBW04QgxNWEkXfIN7j747Ma/OHOnhh2c01/Dc4XoggM=; b=Iy3zSvUNHHa/4YeaQTjAvyWF2pDAK6w9VkKFI4tiCQT9LRPSbyx/oOxoKETlhqWYxdc13T is2PBznjyjzXhKSWwfaWKqTatOQ5npclAeaCEZisSTDNLBKyG00jZHTRJGsBw/6fIeJLJ9 BV59ZPOqCSGicAQcQuApjE7ffAr9BC/YhxSE8QuB8k83Jq1oMeaMei0AnQJOqXwptDkjXM KommUC3Qh3v4ErWsmFPHeBjUlW2Ua09nb8g5Iaqu62BDOnDvQUsHeIwzj6YYzmoE7Ax2Jp ZITrsNoBH0VGtRfbkeaWakYviwMNToE7fl1LL1dU/aBmRctRFamLFrjg3UAzsA== Received: from cell.glebi.us (glebi.us [162.251.186.162]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: glebius) by smtp.freebsd.org (Postfix) with ESMTPSA id 4ZLjQ31MCqz25G; Mon, 24 Mar 2025 06:12:27 +0000 (UTC) (envelope-from glebius@freebsd.org) Date: Sun, 23 Mar 2025 23:12:24 -0700 From: Gleb Smirnoff To: Kristof Provost , igoro@freebsd.org Cc: src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: 0849f1634a70 - main - tests/netinet: add test for IP_MULTICAST_IF Message-ID: References: <202503222340.52MNekCX071219@gitrepo.freebsd.org> <7440BE85-66E8-4D1A-AC15-8B944F5C2951@FreeBSD.org> List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <7440BE85-66E8-4D1A-AC15-8B944F5C2951@FreeBSD.org> On Mon, Mar 24, 2025 at 11:45:55AM +0900, Kristof Provost wrote: K> > tests/netinet: add test for IP_MULTICAST_IF K> > K> It bugs me a little that we have to jump through hoops to get a C program K> running in a specific jail/network setup. K> It’s somewhat common for that to happen, and I’m sure there’d be more cases K> if it were easier to do (e.g. the getaddrinfo tests you’ve been working on K> could be even more useful with a custom DNS server, so in their own vnet K> jail). It bugs me, too. :) Igor has already pushed changes that allow you to specify in the Makefile: TEST_METADATA.foo+= "execenv="jail" execenv_jail_params="vnet" Then this gets into Kyuafile after build. This is a step forward, but not enough. First problem is that the created jail is empty and doesn't have any interfaces. Second problem is that the specified environment affects all tests inside one test file. Ideally we'd like to have a declarative language to describe jail environment for a test. This is basically what vnet.subr does for shell tests and what atf_python.sys.net.vnet does for python tests, but brought to kyua level and of course agnostic to the language of a test. Igor is thinking in this direction and hopefully will eventually deliver something. K> The downside is that we’re compiling the C test code on every run, but I K> expect test programs to be tiny, so that’s not too much of a cost. K> K> Does this seem useful to you too? That would fail on decreased installation, that has tests, but doesn't have compiler. This is not just a made up problem, this is what many would do in CI, cause you want usually as quick as possible response time from CI, and if your team is not hacking the compiler, you won't add compiler to the CI build. -- Gleb Smirnoff