From nobody Sun Mar 16 03:54:21 2025 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4ZFkkQ1hX6z5qhnX; Sun, 16 Mar 2025 03:54:22 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R10" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4ZFkkP3XkNz3kQQ; Sun, 16 Mar 2025 03:54:21 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1742097261; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=yW4kxk2y0ZtU7SAaPl9pzfFPG+u3crA7DEWER1pHKLk=; b=pvLqaGFLQZtGIhbFmYj4MV1KQ63nlbtJZBzBm2brmDlQyprNnBVzsM1EWoXvHsjoEeVqDi WDEpY++1kVDhY4E57Mqu58RhnfMVrnsJQCbnmdjEXoyjfUr9zCuhnJc/6YKm3f3md1ayKG 0D1ADL0yW9pvmLnfpuK4weva0m8ddiCZSJtR+6feNJTdtXnt0lgmSoY5OxcaWK5yuGDscV iJql4Qp9XJcJWdMqeTz57iEl5mG+Gc8AAV9ytDK5L7hX8AnUiOTdzc5EJ+/WufpTJ4sDyn yE6+XFsFk4eCdAYnuIRWauxTMVrDeQzDic6FoKopiHCedABQfudutCKvWNG4bA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1742097261; a=rsa-sha256; cv=none; b=UnGz8+0dymzJVVDM6fjGm9j/UbbUAWqjUw2aAxw0SbtYdKh8tFjg3GsfYjgse8tcUwIMYk 5bug2E1H3LWYtZkSedr88BUaSkKu6FWdb3lSTIp0sXsidJjtrDS5fQzm+VyRGXbRyVBw0Q TNrKQ5MZU5IfVNv8qsaVkB+dCugR4tAKJrJxGrJAMeYv07kbOKM3TZXUFz48c54Hqrzl/C dHRNWJTtavdIGo4UW0JXuzpb3RtknErdksPsBSe+bDJCOMsDtQxG5pom1Z8HlSSUU7m0V+ XadP/23OjeK1CAGW6tRNh1SDbmgw2Dx2kOnPO3cAYxYHWsbyQqo1UflkCVvfRQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1742097261; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=yW4kxk2y0ZtU7SAaPl9pzfFPG+u3crA7DEWER1pHKLk=; b=FFnx+Les21aGnUt/oW+2BHjwsewOkIkL3GfsPmesCuMryHvvy7S0iogujObmUVAUnoojxT wUrKQSdHfpercymlBrTBK1PCxXvBzeiaCXaqq4txM9cL5IqNvcbxwo1+bVM1JaFm1SIajU TRwRF5p5rqOrZSWyJ12WrSEMDLdvtKj0SimR88Jr9pA0yos5enzWbfS8bKHAOTiZQnc6uj AGHV4h5By6OYlyOSsLnCZ92r4wlDw9hPTB0Ca1hOV9dp8MrXW2XUQ3zZhsOK4YWOHjM4hG LmPrGfD0APLEHJnixgmPC4sQFHLYRGio0s3kw6BB00xXgfO4Il1c3H0GRAiemQ== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4ZFkkP2nSpzl4x; Sun, 16 Mar 2025 03:54:21 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 52G3sLP5077360; Sun, 16 Mar 2025 03:54:21 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 52G3sLZL077357; Sun, 16 Mar 2025 03:54:21 GMT (envelope-from git) Date: Sun, 16 Mar 2025 03:54:21 GMT Message-Id: <202503160354.52G3sLZL077357@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Warner Losh Subject: git: 9ea38ca4a8e6 - main - umass/quirk: Remove useless quirk for Transcend flash List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: imp X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 9ea38ca4a8e650a2eafa07cf0862553718b7f266 Auto-Submitted: auto-generated The branch main has been updated by imp: URL: https://cgit.FreeBSD.org/src/commit/?id=9ea38ca4a8e650a2eafa07cf0862553718b7f266 commit 9ea38ca4a8e650a2eafa07cf0862553718b7f266 Author: Warner Losh AuthorDate: 2025-03-16 03:47:44 +0000 Commit: Warner Losh CommitDate: 2025-03-16 03:47:44 +0000 umass/quirk: Remove useless quirk for Transcend flash I have several of these. They all work without these quirks (either the auto quirk mechanism does the right thing, or a likely soon-to-be-removed vendor catch-all does the right thing, or no probing at all does the right hting). Both PREVENT ALLOW and SYNCHRONIZE CACHE are (a) unimplemented but (b) return the proper asc/ascq code so da just does the right thing, quirk or no. This was a left-over from the days where you'd get scary error messages, but we'd work just fine. Now that the scary error messages are gone (and only a calm one under bootverbose), this can be deleted. Sponsored by: Netflix --- sys/dev/usb/quirk/usb_quirk.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/sys/dev/usb/quirk/usb_quirk.c b/sys/dev/usb/quirk/usb_quirk.c index c0343f2b2ae0..653395bbdac9 100644 --- a/sys/dev/usb/quirk/usb_quirk.c +++ b/sys/dev/usb/quirk/usb_quirk.c @@ -214,8 +214,6 @@ static struct usb_quirk_entry usb_quirks[USB_DEV_QUIRKS_MAX] = { UQ_MSC_FORCE_PROTO_SCSI), USB_QUIRK(ALCOR, UMCR_9361, UQ_MSC_FORCE_WIRE_BBB, UQ_MSC_FORCE_PROTO_SCSI, UQ_MSC_NO_GETMAXLUN), - USB_QUIRK(ALCOR, TRANSCEND, UQ_MSC_NO_GETMAXLUN, UQ_MSC_NO_SYNC_CACHE, - UQ_MSC_NO_TEST_UNIT_READY), USB_QUIRK(APACER, HT202, UQ_MSC_NO_TEST_UNIT_READY, UQ_MSC_NO_SYNC_CACHE), USB_QUIRK(ASAHIOPTICAL, OPTIO230, UQ_MSC_FORCE_WIRE_BBB, UQ_MSC_FORCE_PROTO_SCSI, UQ_MSC_NO_INQUIRY),