From nobody Thu Mar 13 16:03:09 2025 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4ZDC2j3hynz5qrqD; Thu, 13 Mar 2025 16:03:09 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R10" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4ZDC2j34Xtz3QPm; Thu, 13 Mar 2025 16:03:09 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1741881789; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=/SQZ0Bk0LJt/MtRb9nOrUjw+kEwY2peRwK5lVchArTE=; b=vhcqN463gQovM4BxD9ESKFwMurqL9PDMBCNyR1LGW2Q7m6bWhTbiVXRydi36GxbZllhVir FrH7P1vG03AsVV0kJfiQSrRiJofeSQT9CM/nOaPwugPjJgO0TGquUMe68ntqr8qodSmasP UOC60+z59v/qwFzEB9ljThzXMzb7vbhUujr4xuH9mK/+fmKgfBBdygk6c6RV8/o/O0O6IB 9HFEkTlYZs/4JC0g5BHD5UrTAX8qJtWzkK/YT+Ejga771nDfAFhV4zWHJQjJGixFyjHWga Tv98SrPzvL0wGbdPschC6wStKBVH9UIfZyq4JKSunyu1q0hGlf4+UqocvY2PXQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1741881789; a=rsa-sha256; cv=none; b=e9rVKt5Xgp79PiPBq3GAMdK64sWGx9JgIiWDTDmiiVFr3J7zlZqJXGWmdsVYfOL8CzK88s WO8j0DBUuQcbtLndUPMjvKS1kzJWxGV7Vw+bewR+TGPP3Jz+jLC9e4KVLmQuyhs7Um98jx iHMK/dTLecsKvf5e1SPUf/hej2CeiYeBitJGwlZdxAc1kuO+iyw8kveXq+WGzwgK1DQpzX VNFs7LtlXqTOM+qtaW4mWqSyQTyTfqGFF6NyON9tf/6Jxo0ftlfouD7kcwvu5ZWb6M4ldY L8LiXmrprJ6TWPH8iLzpGMQdddYOcKCla7EpxYm3ITkBAzvaGedtkWb44e0SOw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1741881789; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=/SQZ0Bk0LJt/MtRb9nOrUjw+kEwY2peRwK5lVchArTE=; b=SyL0H7kDSaBzRYWLyXzc5bbzIM1hA/Jg5uOpXAZGnNLruGkbOZaQN0OK8a8iL9abSIotuS j/BWbulsS2C6R0RsX7h5AbTc4XFdPeBKk+R4pl7ic0lNUON/w+DGvf8n6wDYSj0De5JIee DWeqtqplP+q0LCFaz3kxdnUESNU9seq+XX1A6daPDSk4t0DaNwEjE2m74o18ZtaEP6Z3aW hTkIFAPjCgv2J43UEZkH1nmzOaVyv8dUhVF3ZzlbJBmgf4TBA4pZWjV2+sHgdyCcAqPMHH Ox8EsRfJOo3P0f56e0iwGw+j24lOYU4Xs7GcSjvArRKc160pdr+Nljgalp4FXw== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4ZDC2j2dHTz14ff; Thu, 13 Mar 2025 16:03:09 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 52DG39Zo048271; Thu, 13 Mar 2025 16:03:09 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 52DG39wH048268; Thu, 13 Mar 2025 16:03:09 GMT (envelope-from git) Date: Thu, 13 Mar 2025 16:03:09 GMT Message-Id: <202503131603.52DG39wH048268@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Konstantin Belousov Subject: git: fcf81de12f27 - main - ip6_cksum.c: generalize in6_cksum_partial() to allow L2 headers in passed mbuf List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: kib X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: fcf81de12f27d34a5c18168fd0c756c371a62076 Auto-Submitted: auto-generated The branch main has been updated by kib: URL: https://cgit.FreeBSD.org/src/commit/?id=fcf81de12f27d34a5c18168fd0c756c371a62076 commit fcf81de12f27d34a5c18168fd0c756c371a62076 Author: Konstantin Belousov AuthorDate: 2025-02-19 12:38:34 +0000 Commit: Konstantin Belousov CommitDate: 2025-03-13 15:56:22 +0000 ip6_cksum.c: generalize in6_cksum_partial() to allow L2 headers in passed mbuf Reviewed by: Ariel Ehrenberg , Slava Shwartsman Sponsored by: NVidia networking MFC after: 1 week --- sys/netinet6/in6.h | 2 ++ sys/netinet6/in6_cksum.c | 25 +++++++++++++++++-------- 2 files changed, 19 insertions(+), 8 deletions(-) diff --git a/sys/netinet6/in6.h b/sys/netinet6/in6.h index effd33787e7e..1ca846ebf514 100644 --- a/sys/netinet6/in6.h +++ b/sys/netinet6/in6.h @@ -664,6 +664,8 @@ struct ip6_hdr; int in6_cksum(struct mbuf *, uint8_t, uint32_t, uint32_t); int in6_cksum_partial(struct mbuf *, uint8_t, uint32_t, uint32_t, uint32_t); +int in6_cksum_partial_l2(struct mbuf *m, uint8_t nxt, uint32_t off_l3, + uint32_t off_l4, uint32_t len, uint32_t cov); int in6_cksum_pseudo(struct ip6_hdr *, uint32_t, uint8_t, uint16_t); int in6_localaddr(struct in6_addr *); diff --git a/sys/netinet6/in6_cksum.c b/sys/netinet6/in6_cksum.c index 2fb532d78013..70a9666a0c05 100644 --- a/sys/netinet6/in6_cksum.c +++ b/sys/netinet6/in6_cksum.c @@ -247,14 +247,15 @@ in6_cksum_partial_one(void *_arg, void *data, u_int len) /* * m MUST contain a contiguous IP6 header. - * off is an offset where TCP/UDP/ICMP6 header starts. + * off_l3 is an offset where ipv6 header starts. + * off_l4 is an offset where TCP/UDP/ICMP6 header starts. * len is a total length of a transport segment. * (e.g. TCP header + TCP payload) * cov is the number of bytes to be taken into account for the checksum */ int -in6_cksum_partial(struct mbuf *m, uint8_t nxt, uint32_t off, uint32_t len, - uint32_t cov) +in6_cksum_partial_l2(struct mbuf *m, uint8_t nxt, uint32_t off_l3, + uint32_t off_l4, uint32_t len, uint32_t cov) { struct in6_cksum_partial_arg arg; union l_util l_util; @@ -272,9 +273,10 @@ in6_cksum_partial(struct mbuf *m, uint8_t nxt, uint32_t off, uint32_t len, } uph; /* Sanity check. */ - KASSERT(m->m_pkthdr.len >= off + len, ("%s: mbuf len (%d) < off(%d)+" - "len(%d)", __func__, m->m_pkthdr.len, off, len)); - KASSERT(m->m_len >= sizeof(*ip6), + KASSERT(m->m_pkthdr.len >= off_l4 + len, + ("%s: mbuf len (%d) < off(%d)+len(%d)", + __func__, m->m_pkthdr.len, off_l4, len)); + KASSERT(m->m_len >= off_l3 + sizeof(*ip6), ("%s: mbuf len %d < sizeof(ip6)", __func__, m->m_len)); /* @@ -288,7 +290,7 @@ in6_cksum_partial(struct mbuf *m, uint8_t nxt, uint32_t off, uint32_t len, sum = uph.phs[0]; sum += uph.phs[1]; sum += uph.phs[2]; sum += uph.phs[3]; - ip6 = mtod(m, struct ip6_hdr *); + ip6 = mtodo(m, off_l3); /* IPv6 source address. */ scope = in6_getscope(&ip6->ip6_src); @@ -312,7 +314,7 @@ in6_cksum_partial(struct mbuf *m, uint8_t nxt, uint32_t off, uint32_t len, */ arg.sum = sum; arg.rlen = 0; - (void)m_apply(m, off, cov, in6_cksum_partial_one, &arg); + (void)m_apply(m, off_l4, cov, in6_cksum_partial_one, &arg); sum = arg.sum; /* @@ -327,6 +329,13 @@ in6_cksum_partial(struct mbuf *m, uint8_t nxt, uint32_t off, uint32_t len, return (~sum & 0xffff); } +int +in6_cksum_partial(struct mbuf *m, uint8_t nxt, uint32_t off, uint32_t len, + uint32_t cov) +{ + return (in6_cksum_partial_l2(m, nxt, 0, off, len, cov)); +} + int in6_cksum(struct mbuf *m, uint8_t nxt, uint32_t off, uint32_t len) {