git: 02d61f27585f - main - hdaa: Don't hold a mutex while creating child devices
- Go to: [ bottom of page ] [ top of archives ] [ this month ]
Date: Mon, 10 Mar 2025 17:35:43 UTC
The branch main has been updated by jhb:
URL: https://cgit.FreeBSD.org/src/commit/?id=02d61f27585f52d422fc1e235ac6226e27145162
commit 02d61f27585f52d422fc1e235ac6226e27145162
Author: John Baldwin <jhb@FreeBSD.org>
AuthorDate: 2025-03-10 17:34:07 +0000
Commit: John Baldwin <jhb@FreeBSD.org>
CommitDate: 2025-03-10 17:34:07 +0000
hdaa: Don't hold a mutex while creating child devices
The lock is already not held while deleting child devices, and the
bus_topo_lock is already held when child devices are created.
Reviewed by: imp
Differential Revision: https://reviews.freebsd.org/D49272
---
sys/dev/sound/pci/hda/hdaa.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/sys/dev/sound/pci/hda/hdaa.c b/sys/dev/sound/pci/hda/hdaa.c
index f53e93a2355b..ac62c04b5374 100644
--- a/sys/dev/sound/pci/hda/hdaa.c
+++ b/sys/dev/sound/pci/hda/hdaa.c
@@ -6200,7 +6200,9 @@ hdaa_configure(device_t dev)
HDA_BOOTHVERBOSE(
device_printf(dev, "Creating PCM devices...\n");
);
+ hdaa_unlock(devinfo);
hdaa_create_pcms(devinfo);
+ hdaa_lock(devinfo);
HDA_BOOTVERBOSE(
if (devinfo->quirks != 0) {