From nobody Fri Mar 07 04:15:12 2025 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Z8Ccd33Rqz5qbdy; Fri, 07 Mar 2025 04:15:13 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R10" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Z8Ccc6zsmz466y; Fri, 07 Mar 2025 04:15:12 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1741320913; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=M0O3XSQtSRwUcHCdzNJeo8ea7r0eGxUTvrum0J1I8fo=; b=pgzVbL8pBfwNLY6UJ5HXuEyEv+9dKu9JnU2U64RHH0ycT6/bZKXVoKUwtOKvDti41Wl/jq eBagWbI7biIWDQ4nxHC2JvPnhcHQbOJy4Q80UK/O+/qq1Ij7TFkvOo8vZ816JCQSQdUgQ4 EvKAnUrDexui0LKlhqsFma7Q6XXBv8vgRLqFJcZhHAtzCdsi5ZnvTp1pHRAV9ebxkQBiQR Vyk7VbreqdDpQH4569baEbQjjuuW322mYUvNDZdjTgh6D4w24GaH2LH/C/rgpFkCBYny6R dlOSZTL1QAls5kNGX6CXf4nMbzv+kMhtTZkWOnM6F73BKO5PgJMGveMCxPfGkg== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1741320913; a=rsa-sha256; cv=none; b=BTigCveHq9t8HKjtdNyiDvr8yZH2zZdI94y36bNmrDiyKrgUJnpJkdriZ1xYjJLrXuODk8 mzIKgOTkFxo6phKhztTMOBhF8P5cu9btholxT+GE1Mwyz1HAdHe3gcG3T4b1iUDfKoMO8A 9d4JaXXP5WGK/8FZ0fXOxqfZ69B+sCl5n/fkm2LuaE1FJeq6Uyk+LyqxEf5sDa4Te6t2w/ NZXx+mP4quIn8T6f3ccy6NMVLVsIvGHZE/vDZ/xSebokakAwwOhPuoOkxYoSudc8ERN35K yMwE32kr20bLS+AtufpnSNgqMf07H9ju1lfUNqiiyf8gfTGcHJqJfv3U8uOK1g== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1741320913; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=M0O3XSQtSRwUcHCdzNJeo8ea7r0eGxUTvrum0J1I8fo=; b=NCI7RQ1KgZdtaxtXJFKmJxPbt+enNDVN+doLFsIpdDkmK8KTiCaODEqndeqlgS5WLvfhqi +YuUVBZi87IDlWGKqLiH/5CpowjmFKQZVHHmieyUxyntel6klfxKknl09JNew23AW71oZQ jcF5s8BZvF5n4UTp5mVedIlo0HPQKmSyx7rrSxqEM+9vMXDPoZI/TJ5gvHY6LNuUkhaBHc 6NLnglbDjEEhob/qRVEN+ZX9SK1xg25fxW1mYPFBJdsgamf2jDGnulKoh5/shzFMe+WjR1 9kHdXcboswNEAqlM/qLvHNgvy1g6Lbz4PZ4zMM8bsNO567hFi6/VN6PJSEYDrA== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4Z8Ccc6Q14z62k; Fri, 07 Mar 2025 04:15:12 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 5274FC2n049679; Fri, 7 Mar 2025 04:15:12 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 5274FCmg049676; Fri, 7 Mar 2025 04:15:12 GMT (envelope-from git) Date: Fri, 7 Mar 2025 04:15:12 GMT Message-Id: <202503070415.5274FCmg049676@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Zhenlei Huang Subject: git: 0e096bb3fcaa - main - netlink: Fix getting route scope of interface's IPv4 addresses List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: zlei X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 0e096bb3fcaaf663df372aa4abb986e8d63c6e68 Auto-Submitted: auto-generated The branch main has been updated by zlei: URL: https://cgit.FreeBSD.org/src/commit/?id=0e096bb3fcaaf663df372aa4abb986e8d63c6e68 commit 0e096bb3fcaaf663df372aa4abb986e8d63c6e68 Author: Zhenlei Huang AuthorDate: 2025-03-07 04:14:44 +0000 Commit: Zhenlei Huang CommitDate: 2025-03-07 04:14:44 +0000 netlink: Fix getting route scope of interface's IPv4 addresses sin_addr of a `struct sockaddr_in` is stored in network byte order, but IN_LOOPBACK() and IN_LINKLOCAL() want the host order. Reviewed by: melifaro, #network Fixes: 7e5bf68495cc netlink: add netlink support MFC after: 3 days Differential Revision: https://reviews.freebsd.org/D49226 --- sys/netlink/route/iface.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/sys/netlink/route/iface.c b/sys/netlink/route/iface.c index 93465e55e6aa..8b871576d0b2 100644 --- a/sys/netlink/route/iface.c +++ b/sys/netlink/route/iface.c @@ -818,9 +818,9 @@ ifa_get_scope(const struct ifaddr *ifa) { struct in_addr addr; addr = ((const struct sockaddr_in *)sa)->sin_addr; - if (IN_LOOPBACK(addr.s_addr)) + if (IN_LOOPBACK(ntohl(addr.s_addr))) addr_scope = RT_SCOPE_HOST; - else if (IN_LINKLOCAL(addr.s_addr)) + else if (IN_LINKLOCAL(ntohl(addr.s_addr))) addr_scope = RT_SCOPE_LINK; break; }