From nobody Tue Mar 04 14:25:40 2025 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Z6dJT17TPz5q8Gl; Tue, 04 Mar 2025 14:25:45 +0000 (UTC) (envelope-from bz@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Z6dJT0DZ2z3H95; Tue, 04 Mar 2025 14:25:45 +0000 (UTC) (envelope-from bz@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1741098345; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=lY6nLzjOi5KGoF4mv5yH3VlNw2s8CzryzXFH+hHcaGY=; b=u9nap6HupjzMAIpG7H2sH1KTZCT1UC7teTS3FfLGDZgmxTtsKiUVnbUF9ZXH9/L1HpA6Zy xK/7IQvQarUcgpt5Dp0aRzAJWntN+j7+lFZlokwMSwRLV9CfQWpJ0ilPV0G91X8zULxvNR zozcHXtijGc3jDlHZYbVOP0WGtvaHpeQaP/3kAdgPY0+cx5XUJepLTWgIOrWR0t4ZMgtF9 73WvpW4GkUyb86C6k9qDhqGhSwo2E7NFiNLLqp1TU8konflibKAIcDvTog4mtHI3mL1bls +ZXjbjyVI/IqUbZRc7gCtOt6WEBk8LAJp7pf+zSrC2RcaTFZwH7j/3EvnwqAIQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1741098345; a=rsa-sha256; cv=none; b=UB7RtaI30RU+6uGyJXDHCE4740MofJvTX1KJFgo7rzTqldPNVJ9TeiGi8B92y3GJt3qWRd tusy11PT/A/VXPkxvAifhjC1M47bRuJmu+Rz7ERRTwC8Ab6V+bhRyslm2pvX+QSqteVhkU ZKA7v5W6MhvMYYt2xeO5fIa6P/1gl+7vAIE09HfXiMHczT5OnNWHpS169AidRBRl4KGb0R Splc1mKourxnNueRKWQZmSklgmyk+UvAe4Z57J8u0EtlGPi3oHn8AAsZM0I6gp9uJGYSOl zjVmwmIa/K1t3w++ErEUb5IXQ0M2uweWy0ljoBut3lin8UQrqeUI7VHhmJE/Dg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1741098345; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=lY6nLzjOi5KGoF4mv5yH3VlNw2s8CzryzXFH+hHcaGY=; b=yrPdYmn35NAQMr5GEA0lX/VsF8b6rO63SdJ9w0A4OV7ay8PlyS47F9McR6T5yAogPGPkKM 6hBpVO1UNNH0sMAaXPttwEoI5pnFfrDglOgWhTU+pLE1k/2idCJWnjMtQsomjFPaYPuCYf LZgghfrt58SOZ693fJle+CF9rXs3OhGjIaItrVPwX9nKZVIM+dbHYgIo95XrGWQYZnR4xC S247NshOrZIhAWEMs3WEg4ptEvEN2TaZiGJtMCaSzklemy6DDX4Q3QdO77RTQG+YFDInFh d+nugpit80lEV0xwl+Seaeb3rx6oXwJuPq23iuqfiAortxm756Z1KrsMnybsog== Received: from mx-01.divo.sbone.de (mx-01.divo.sbone.de [IPv6:2003:a:140a:2200:6:594:fffe:19]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature ECDSA (prime256v1) client-digest SHA256) (Client CN "mx-01.divo.sbone.de", Issuer "E5" (verified OK)) (Authenticated sender: bz/mail) by smtp.freebsd.org (Postfix) with ESMTPSA id 4Z6dJS5qk0z17Dc; Tue, 04 Mar 2025 14:25:44 +0000 (UTC) (envelope-from bz@FreeBSD.org) Received: from mail.sbone.de (mail.sbone.de [IPv6:fde9:577b:c1a9:4902:0:7404:2:1025]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by mx-01.divo.sbone.de (Postfix) with ESMTPS id 45968A64805; Tue, 04 Mar 2025 14:25:41 +0000 (UTC) Received: from content-filter.t4-02.sbone.de (content-filter.t4-02.sbone.de [IPv6:fde9:577b:c1a9:4902:0:7404:2:2742]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mail.sbone.de (Postfix) with ESMTPS id DE35A2D029E0; Tue, 4 Mar 2025 14:25:42 +0000 (UTC) X-Virus-Scanned: amavisd-new at sbone.de Received: from mail.sbone.de ([IPv6:fde9:577b:c1a9:4902:0:7404:2:1025]) by content-filter.t4-02.sbone.de (content-filter.t4-02.sbone.de [IPv6:fde9:577b:c1a9:4902:0:7404:2:2742]) (amavisd-new, port 10024) with ESMTP id UGyPDWbrHWPv; Tue, 4 Mar 2025 14:25:41 +0000 (UTC) Received: from strong-rtwn0.sbone.de (strong-rtwn0.sbone.de [IPv6:fde9:577b:c1a9:4902:da44:89ff:fedd:d5ab]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mail.sbone.de (Postfix) with ESMTPSA id A2C292D029D8; Tue, 4 Mar 2025 14:25:41 +0000 (UTC) Date: Tue, 4 Mar 2025 14:25:40 +0000 (UTC) From: "Bjoern A. Zeeb" To: "Herbert J. Skuhra" cc: Alexander Ziaee , Adrian Chadd , src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org Subject: Re: git: 4262dbc57982 - main - wifi manuals: Mlink + document description consistency In-Reply-To: <87bjugsx7t.wl-herbert@gojira.at> Message-ID: <95401978-p196-n4n8-4458-98qs07n2162n@SerrOFQ.bet> References: <202502272222.51RMM0fg033513@gitrepo.freebsd.org> <87bjugsx7t.wl-herbert@gojira.at> X-OpenPGP-Key-Id: 0x14003F198FEFA3E77207EE8D2B58B8F83CCF1842 List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed On Tue, 4 Mar 2025, Herbert J. Skuhra wrote: > On Thu, 27 Feb 2025 23:22:00 +0100, Alexander Ziaee wrote: >> >> The branch main has been updated by ziaee: >> >> URL: https://cgit.FreeBSD.org/src/commit/?id=4262dbc57982383eb61a8b7806de6dd4b7802da8 >> >> commit 4262dbc57982383eb61a8b7806de6dd4b7802da8 >> Author: Alexander Ziaee >> AuthorDate: 2025-02-19 15:54:27 +0000 >> Commit: Alexander Ziaee >> CommitDate: 2025-02-27 22:20:22 +0000 >> >> wifi manuals: Mlink + document description consistency >> >> Interfaces all have an mlink to if_$foo. Add these for the missing ones >> and remove an incorrect one from rtwn_pci. Wireless network drivers are >> all accessible via `apropos -s4 "wireless network driver", except two >> which are "wireless network device". I actually prefer the latter, but >> make them all consistent upon the more common parlance. Tag SPDX on one >> of the files I touched, while here. >> >> MFC after: 3 days >> Reviewed by: bz, carlavilla, mhorne >> Approved by: carlavilla, mhorne (mentors) >> Differential Revision: https://reviews.freebsd.org/D49063 >> --- >> share/man/man4/Makefile | 4 +++- >> share/man/man4/uath.4 | 4 +++- >> share/man/man4/upgt.4 | 2 +- >> 3 files changed, 7 insertions(+), 3 deletions(-) >> >> diff --git a/share/man/man4/Makefile b/share/man/man4/Makefile >> index 13afc9b8d399..8e0af19eec3d 100644 >> --- a/share/man/man4/Makefile >> +++ b/share/man/man4/Makefile >> @@ -764,7 +764,9 @@ MLINKS+=ptnet.4 if_ptnet.4 >> MLINKS+=ral.4 if_ral.4 >> MLINKS+=re.4 if_re.4 >> MLINKS+=rl.4 if_rl.4 >> -MLINKS+=rtwn_pci.4 if_rtwn_pci.4 >> +MLINKS+=rtw88.4 if_rtw89.4 >> +MLINKS+=rtw89.4 if_rtw89.4 >> +MLINKS+=rtwn.4 if_rtwn.4 > ^^^^^^^^^ > $ grep if_rtwn.4 ObsoleteFiles.inc > OLD_FILES+=usr/share/man/man4/if_rtwn.4.gz In fact that is probably correct but things are confusing. The modules are called if_rtwn_usb.ko and if_rtwn_pci.ko and those should have the man page and links (so contrary to what was done). rtwn.ko is just the common code if I am not mistaken (Adrian should know better). But everyone is just referring to the driver as rtwn and I fear if there is no man page to be found as man rtwn / man if_rtwn people will be confused. I wanted to do the same with rtw88 but was told to keep it all together as one so rtwn is an excemption. That all said, yes, it needs a further cleanup. -- Bjoern A. Zeeb r15:7