Re: git: 4e207e3849d4 - main - exterr: make SET_ERRORX() macros an expression evaluating to the errno
Date: Mon, 16 Jun 2025 21:05:41 UTC
On Mon, Jun 16, 2025 at 02:01:26PM -0700, Gleb Smirnoff wrote: > On Sat, Jun 14, 2025 at 08:59:39AM -0400, Mark Johnston wrote: > M> If your suggestion is implemented, then it would be sensible to use a > M> different name to avoid collisions, maybe SET_EXTERROR() or just > M> EXTERROR(). > > I'd vote for EXTERROR(). But now with the function existing, why would > we recommend to use the macro instead of the function at all? Because there is an option to not bloat the kernel with strings. Also there is a desire to provide more info, like amount of the arguments supplied, automatically. It is already EXTERROR(). See vm/vm_mmap.c for exemplary usage. > IMHO, the > function shall be the right use and that will make any macro collisions > with ZFS or whatever void.