From nobody Fri Jun 13 12:30:39 2025 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4bJdz36QdYz5pvM2; Fri, 13 Jun 2025 12:30:39 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4bJdz35v5Fz3CPs; Fri, 13 Jun 2025 12:30:39 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1749817839; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=3/IDKoMjIcvZwynKOjc0OILywsWT3N/CHHeaLc4dX6w=; b=owAUCLV0Vm9/h/RXlCGqzLpQSOZDmuVFuuMHLr65q9MPewJxHuofD6WiDla9HTaGTwH+Hy 23PnDP0lynW8aOTCKDOVXiS7balNG+lxv+5ag/biwIRGPxkLnKuKOT8ToX2uqhN4j+i3Qe QAPmTisa+eScSQ7UFRo1a+81ED+58e846Zz3pl85S7it5lISCQIoDlCbaoCqqW64OhGHrB s7M89t49S78csydoDONJxagMZCATP+N7Ha2KTJePXRes9oRS0g1LzCL1oy9zqs4yJ1DWi+ 9nrrBQd0FNX4Ch2opFZ0y1TI4Pj2A7TnbXrS/+ErSylCQypw8ODlXUIszMzZvg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1749817839; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=3/IDKoMjIcvZwynKOjc0OILywsWT3N/CHHeaLc4dX6w=; b=iNBQFC0ILrSAO5CQ7ivBVaaQzgBba1xAMkShMxrGTCbnRbecd4RSLH80BOTiLMQlLfx3Ya 5i55cTdh9T49H9ijmQUXBGvUZ+Vxue8h+2wTUB/pFDEBTCredGm13cDD3kzm8JoCizOs49 Y1Uz9iXfMbDNMtvVjIsD+OQPj+EvHnGEuzoQ/tO81iQ7tvEdZrEXb74LGSNjCimGOb148g 9TKgYb5Ljrgbi7rS5QGsDOUqQVOaQOlBhPWE1DStNET7XBAbXbAPR20V2wDK/wuE6Ao3++ 3g5y3KeUv/DlnLTDf4Hzpab2wa1P0Bsb842Ga+RCR7O1qjXeS7Fm8Artwg6XTQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1749817839; a=rsa-sha256; cv=none; b=KcLdW/G/71i2qPUam++KRnTAkqyqezcMRnRxUkT6tznqNDVjezRVUeD4Ate2BcvWF93wfi I9RajACePm/zhKRirZ90VS9S+y5O6pZxbrlc4RRVue+sT2dV2sYWCWtsHUGq+shsdUqjpa au8g7VmImuqKJHfMp3BG74VpkEghFa34Q3Aen4tzD17bBgl9T2xzo2t2dgJpsZJ5W0UKyW 90cCeecPf9goDN0HOMOKRYPdPSaGWXRzBIazUni8hF1H1BlhxSaNShMnj9DnIU20/a3BjH rHyyp3cl9b9CgYd2MpBKT7MrlhbJHyK2jwf8FK8VIbWWDoxAaW0iUJsXixeVPA== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4bJdz35HzGzxYt; Fri, 13 Jun 2025 12:30:39 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 55DCUdFS039165; Fri, 13 Jun 2025 12:30:39 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 55DCUdt3039162; Fri, 13 Jun 2025 12:30:39 GMT (envelope-from git) Date: Fri, 13 Jun 2025 12:30:39 GMT Message-Id: <202506131230.55DCUdt3039162@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Christos Margiolis Subject: git: f482411563d6 - stable/14 - snd_hda: fix attaching to some AMD Radeon GPUs List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: christos X-Git-Repository: src X-Git-Refname: refs/heads/stable/14 X-Git-Reftype: branch X-Git-Commit: f482411563d6c9ef1dfef3e59bb9e7fe3b6b4d91 Auto-Submitted: auto-generated The branch stable/14 has been updated by christos: URL: https://cgit.FreeBSD.org/src/commit/?id=f482411563d6c9ef1dfef3e59bb9e7fe3b6b4d91 commit f482411563d6c9ef1dfef3e59bb9e7fe3b6b4d91 Author: Stefan Eßer AuthorDate: 2025-06-12 07:47:57 +0000 Commit: Christos Margiolis CommitDate: 2025-06-13 12:30:22 +0000 snd_hda: fix attaching to some AMD Radeon GPUs HDMI audio did not work on my older Radeon GPU, the error message during attach was: hdac0: hdac_get_capabilities: Invalid corb size (0) This is fixed by calling hdac_reset() before the HDA device capabilities are retrieved. This solution was proposed by Andriy Gapon in 2010, but apparently did not solve the problem reported at the time. Approved by: christos Differential Revision: https://reviews.freebsd.org/D50737 (cherry picked from commit dab9ef5448682c3c35e34d857b17ac1c23445321) --- sys/dev/sound/pci/hda/hdac.c | 1 + 1 file changed, 1 insertion(+) diff --git a/sys/dev/sound/pci/hda/hdac.c b/sys/dev/sound/pci/hda/hdac.c index be143ccd54c3..89742a0e4ebc 100644 --- a/sys/dev/sound/pci/hda/hdac.c +++ b/sys/dev/sound/pci/hda/hdac.c @@ -1278,6 +1278,7 @@ hdac_attach(device_t dev) goto hdac_attach_fail; /* Get Capabilities */ + hdac_reset(sc, 1); result = hdac_get_capabilities(sc); if (result != 0) goto hdac_attach_fail;