git: 7cbf41ef6022 - main - mmc_da: Queued CCBs need a priority other than CAM_PRIORITY_NONE
- Go to: [ bottom of page ] [ top of archives ] [ this month ]
Date: Tue, 22 Jul 2025 04:00:55 UTC
The branch main has been updated by imp:
URL: https://cgit.FreeBSD.org/src/commit/?id=7cbf41ef60227f2a4eaf01f600fc894ef0d50323
commit 7cbf41ef60227f2a4eaf01f600fc894ef0d50323
Author: Warner Losh <imp@FreeBSD.org>
AuthorDate: 2025-07-22 03:38:55 +0000
Commit: Warner Losh <imp@FreeBSD.org>
CommitDate: 2025-07-22 04:00:53 +0000
mmc_da: Queued CCBs need a priority other than CAM_PRIORITY_NONE
Queued CCBs usually are queued at CAM_PRIORITY_NORMAL, unless they are
doing error recovery, or device enumeration of some kind. They should
never be queued at CAM_PRIORITY_NONE, which should only be used for CCBs
that are immediate. For sdda_start_init_task(), we allocate a ccb,
initialize it then use it to talk to the SD/MMC card to query it,
negotiate the speed and lane sizes, etc. Most of these commands are
queued, so use the normal priority.
Sponsored by: Netflix
---
sys/cam/mmc/mmc_da.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sys/cam/mmc/mmc_da.c b/sys/cam/mmc/mmc_da.c
index 7f8bf3516804..322141a72707 100644
--- a/sys/cam/mmc/mmc_da.c
+++ b/sys/cam/mmc/mmc_da.c
@@ -1081,7 +1081,7 @@ sdda_start_init_task(void *context, int pending)
CAM_DEBUG(periph->path, CAM_DEBUG_TRACE, ("sdda_start_init_task\n"));
new_ccb = xpt_alloc_ccb();
xpt_setup_ccb(&new_ccb->ccb_h, periph->path,
- CAM_PRIORITY_NONE);
+ CAM_PRIORITY_NORMAL);
cam_periph_lock(periph);
cam_periph_hold(periph, PRIBIO|PCATCH);