Re: git: 7e35117eb07f - main - Makefile: Hook MIT KRB5 into the build

In message <aGwv06rGlgW8zmJI@mail.bsd4all.net>, "Herbert J. Skuhra" writes:
> On Mon, Jul 07, 2025 at 10:36:31PM +0300, Dima Panov wrote:
> > Hello!
> > 
> > 
> > BTW, it looks like symlink for libkadm5clnt.so is broken and produced a bad
>  file
> > $ ls -la libkadm5clnt
> > lrwxr-xr-x  1 root wheel 13  7 Jul 20:40 libkadm5clnt -> kadm5clnt_mit
> > 
> > instead of assumed libkadm5clnt.so -> kadm5clnt_mit.so
> > 
> > 
> > Please review:
> > 
> > diff --git a/krb5/lib/kadm5clnt/Makefile b/krb5/lib/kadm5clnt/Makefile
> > index e377f95f5b6e..be09dd3e210e 100644
> > --- a/krb5/lib/kadm5clnt/Makefile
> > +++ b/krb5/lib/kadm5clnt/Makefile
> > @@ -88,7 +88,7 @@ ${CHPASS_UTIL_STRINGS_ERR_C}: ${CHPASS_UTIL_STRINGS_ERR}
> >         rm -f et-c-${.PREFIX}.et et-c-${.PREFIX}.c
> > 
> >  afterinstall:
> > -       ${INSTALL_LIBSYMLINK} ${SHLIB} ${DESTDIR}${LIBDIR}/libkadm5clnt
> > +       ${INSTALL_LIBSYMLINK} ${SHLIB_NAME} ${DESTDIR}${LIBDIR}/libkadm5cln
> t.so
> > 
> >  .include <bsd.lib.mk>
>
> This produces a valid symlink that 'make delete-old' wants to
> remove again:
>
> lrwxr-xr-x  1 root wheel     23 Jul  7 22:26 /usr/lib/libkadm5clnt.so ->
> libkadm5clnt_mit.so.121
>
> # make delete-old
> >>> Removing old files (only deletes safe to delete libs)
> remove /usr/lib/libkadm5clnt.so?

Thanks Dima and Herbert for reporting this. It's been fixed.


-- 
Cheers,
Cy Schubert <Cy.Schubert@cschubert.com>
FreeBSD UNIX:  <cy@FreeBSD.org>   Web:  https://FreeBSD.org
NTP:           <cy@nwtime.org>    Web:  https://nwtime.org

			e**(i*pi)+1=0