Re: git: 71a0af25a535 - main - libopenbsd: Add recallocarray()

Hey Mark,

I've noted a couple things.

On Sun, Jul 06, 2025 at 11:18:43PM +0000, Mark Johnston wrote:
> The branch main has been updated by markj:
> 
> URL: https://cgit.FreeBSD.org/src/commit/?id=71a0af25a5353f929521cb04c73a7266ac5b7b61
> 
> commit 71a0af25a5353f929521cb04c73a7266ac5b7b61
> Author:     Ricardo Branco <rbranco@suse.de>
> AuthorDate: 2025-06-16 21:41:48 +0000
> Commit:     Mark Johnston <markj@FreeBSD.org>
> CommitDate: 2025-07-06 23:09:00 +0000
> 
>     libopenbsd: Add recallocarray()
>     
>     Reviewed by:    kib
>     MFC after:      1 month
>     Pull Request:   https://github.com/freebsd/freebsd-src/pull/1698

That appears to be the PR for POSIX O_CLOFORK.

> ---
>  lib/libopenbsd/Makefile        |  3 +-
>  lib/libopenbsd/recallocarray.c | 82 ++++++++++++++++++++++++++++++++++++++++++
>  2 files changed, 84 insertions(+), 1 deletion(-)

FreeBSD commit 450dfafb1519ae7bb0615368ba45813bcabb9b35 back in 2015
imported a different version of OpenBSD's reallocarray into libc.
Would it make sense to have only one reallocarray implementation? Or
what's the justification for having two implementations of the same
function? What might happen if someone links against both libc and
libopenbsd?

Thanks,

-- 
Shawn Webb
Cofounder / Security Engineer
HardenedBSD

Signal Username:  shawn_webb.74
Tor-ified Signal: +1 303-901-1600 / shawn_webb_opsec.50
https://git.hardenedbsd.org/hardenedbsd/pubkeys/-/raw/master/Shawn_Webb/03A4CBEBB82EA5A67D9F3853FF2E67A277F8E1FA.pub.asc