From nobody Tue Jul 01 14:19:44 2025 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4bWlXd6cvwz60S80; Tue, 01 Jul 2025 14:19:45 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R10" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4bWlXc5LQHz3sDw; Tue, 01 Jul 2025 14:19:44 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1751379584; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=offdHl/dWIuVM+e3Ks0JdWWuC0Oe/g6cjCG6J/8WC/4=; b=v/y+Qde/lfgnNwz0VKURCVeLBbh5T9gNtIHbcaLIUtfICMapU8fWQu44qzxTBpTYXtBd87 pga2s/8pW8aYlSBnAO12MS9p77mcE/HNshNanw8AYDavZaCiE176rPGV+oBXzjZSGj+nzl iEwzc2Ptle+/qjlOnTdTfNXkRkZcLzuNal2Wtikq4yNYu1H42+i064gPbCv3rEkMgJKhWk yWxIiIvV06mfiao1s9TgsuZRNO7mH3ywd5K99EmIbs584Heh4yP1lAKoc600e0D+kWGtOR sRVmIJcjhEWckyStxzZxkjhc/SSl7BwCbOSiy4B34Z7ATtu/fxk6fjn+hpDWWg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1751379584; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=offdHl/dWIuVM+e3Ks0JdWWuC0Oe/g6cjCG6J/8WC/4=; b=kxR5xRaXyT/pBPrhnHWn2LWGvobmxAhYQAd6zM3ewk0GTIqBS6lW7xz40ww++gj+OYHeEb fBKo8ChDzS6J7dPAHcqGQA6sKZCmWIc5IVGGk5YLIQnZbA+CKfxvo7DEr/lQSMYrrYPKRM mTKUG2v6gTDlZmDL5st809HMe/IB3ICEJgk8+YSaJ3V0SGs9X55cMkS/WiQvkJk+QV3mJK Zf1aDarYVuQ8hkH2KWiNYuBvuPxaRs1VgSORCVM147E8FImkG4c6fslqrFHgNUbBeJfuYk GdYo9aIru1w30izHOiLK1BkJ4J1C5OfOtPDSjXBHzv2kX/rC/a5F2db5teO9BQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1751379584; a=rsa-sha256; cv=none; b=FURk02CuIFsgjng4hFUl5CJvpcDX+nkosYRUnQjh3PaaBhHFwmTUigptKBwUEaiTJHa/1p yOPAgp4u7NXlkXKARei8UL3SKTmpWGbJqENyWOiwD2sdbUZ9dJCIbbv26LPKf8zRVoUTos wLpsxTh94uYe1qdMoJax2fmLRp6DFyuTwb8PJaT1Wc1dsavVVGBYJyPuM1vLb86k6PeI4C EBYx7q0bmwxMzUHX6VeDHTV/TJtiF7PrrWaC6083kxqGEiKFUC30HWactZ2sus+SzH7Ajy PfGxYODZC5rLFoLH/Lxa6IweC7sdIPDxt1/4FSJTOBMp3FWId7bBmIfFE8RYZA== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4bWlXc48Gyzdp5; Tue, 01 Jul 2025 14:19:44 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 561EJiZR077364; Tue, 1 Jul 2025 14:19:44 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 561EJirm077361; Tue, 1 Jul 2025 14:19:44 GMT (envelope-from git) Date: Tue, 1 Jul 2025 14:19:44 GMT Message-Id: <202507011419.561EJirm077361@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Eugene Grosbein Subject: git: 6d3bc576abbd - main - libexec/rc: improve performance of pccard_ether script List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: eugen X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 6d3bc576abbd84f736d917f5bfec4e3fe7e6c125 Auto-Submitted: auto-generated The branch main has been updated by eugen: URL: https://cgit.FreeBSD.org/src/commit/?id=6d3bc576abbd84f736d917f5bfec4e3fe7e6c125 commit 6d3bc576abbd84f736d917f5bfec4e3fe7e6c125 Author: Eugene Grosbein AuthorDate: 2025-07-01 14:13:10 +0000 Commit: Eugene Grosbein CommitDate: 2025-07-01 14:13:10 +0000 libexec/rc: improve performance of pccard_ether script Replace "ifconfig -ul" with "ifconfig -n" because netlink-enabled /sbin/ifconfig utility has sub-optimal performance for listing. Combined with the commit b1b17432aa1be670564161232d110461a5dde4ce, these changes mostly eliminate performance regression of the command "service devd start" for a system having hundreds of network interfaces created before devd starts, after FreeBSD 14+ switched /sbin/ifconfig to netlink(4) PR: 287872 MFC-after: 2 weeks --- libexec/rc/network.subr | 20 ++++++++++++++++++++ libexec/rc/pccard_ether | 17 +++++++++-------- 2 files changed, 29 insertions(+), 8 deletions(-) diff --git a/libexec/rc/network.subr b/libexec/rc/network.subr index 931fbec19a60..2113a3f66f0f 100644 --- a/libexec/rc/network.subr +++ b/libexec/rc/network.subr @@ -653,6 +653,26 @@ ifexists() ${IFCONFIG_CMD} -n $1 > /dev/null 2>&1 } +# ifisup if +# Returns 0 if the interface exists and UP, +# returns 1 if the interface exists and not UP, +# returns 2 otherwise. +ifisup() +{ + local _if + + [ -z "$1" ] && return 1 + _if="$1" + + set -- $(${IFCONFIG_CMD} -n ${_if} 2>/dev/null) + case "$1$2" in + ${_if}:*']*) return 0 ;; + ${_if}:*) return 1 ;; + esac + + return 2 +} + # ipv4_up if # add IPv4 addresses to the interface $if ipv4_up() diff --git a/libexec/rc/pccard_ether b/libexec/rc/pccard_ether index 7ca58f210085..957983e55a8e 100755 --- a/libexec/rc/pccard_ether +++ b/libexec/rc/pccard_ether @@ -69,16 +69,17 @@ checkauto() pccard_ether_start() { - ifexists $ifn || exit 1 - - if [ -z "$rc_force" ]; then - for uif in `ifconfig -ul`; do - if [ "${uif}" = "${ifn}" ]; then - # Interface is already up, so ignore it. + ifisup $ifn + case $? in + 0) # Interface is already up, so ignore it. + if [ -z "$rc_force"]; then exit 0 fi - done - fi + ;; + 2) # Interface does not exist. + exit 1 + ;; + esac /etc/rc.d/netif quietstart $ifn