From nobody Thu Jan 30 03:42:39 2025 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Yk4bg4y7rz5n80W; Thu, 30 Jan 2025 03:42:39 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Yk4bg4Gt8z3r5S; Thu, 30 Jan 2025 03:42:39 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1738208559; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=jFbru+CaTd7Hi07KEvIxzEwCHgYKWraMDpX4a/ZZFII=; b=jfL7megcZ7g1QOaKcnxl1iRM2N3KydrMtBetC50lotBSaJP5zo58Jm7g9CvWKgB4p80Gjk NoJGaZiJOETEFrbCE6HZiur6pxb8h4J2zTf0sB3QuuBwXxSRHOcTku4F9GQTBmInZQaC4j zb+BkOQfakb09aPqrmzVRFiaERfe0LgmDhveG3uwPe85QoZ7vRIVfEToXmVCqn+G8SHoDD N/3uXupJVc4paKg8SHy74Q3y6GqnvP5mS0ijZ6jShZMI8QGkPZhcKq28MW47l8APuy1JFW op2WnbLA8YfmAaaWAnIx0eD9LUju9zVNzH62q+tYB/IDF7HHklF6QSTnseeUsA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1738208559; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=jFbru+CaTd7Hi07KEvIxzEwCHgYKWraMDpX4a/ZZFII=; b=esNbjZ0Pp6moDBZ3MhzBIdngH6MZc8fAAyj3txdRN5yHp/xBRl1I2mblEkB2F0AA5kscMu EJ+bhJ6WcsYYJak0Slf9KjNhrqA7/7ckR4F25yk70Seez8yBAgEc/Disc77ALJ4elqU2zA ++lOwJuQpJ8Cr5rqIeGCAvubu3r1nKHFjix+blLkmPFkXjFAbTtPbFxM3dlaTx0kU93Ntj D320QX6rzzNyYhBtOB+3gWSn97sa+oLE7F714VrKieYixQG5sHodrLaKpgJilEznoNvs1H hMCas7720v5mV+O8FEqCmTNiazijRuGVdAUG3y1xipvETXoPv1MZqC6IcdipHQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1738208559; a=rsa-sha256; cv=none; b=D4F3A1GUA3oGGxFfO8RIeWDdNmk3SSFoCebJBKNarSwIApoRWKfjzJMAq1/XAhwtDXomn2 PxMNiFn/d6Kle3Rkso1tTt9eIA9pejTBG85gdRGrDM74CN9SgY/OLvwlVcPwGfFEr0LAhK Y9cIcGCb22NuBZ6h3ztsygsW/YUgtQ/WLx5fxt3O0aQ2W/Ps6BSvPFvZdkMs2F85zQVZA0 TLeZSlElJjR4dPoNt6tUiO3NMVCblfmeH9/XoX5gjSeXNyYMJyPqOOCO0e5xO6ZmrO86Cl OJOxMScwLDl+MNSWqnLY68N/awZWH8ShlchkYJ8yUbrXk86DFsB6yv3U0m9/6w== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4Yk4bg3nBmzVbC; Thu, 30 Jan 2025 03:42:39 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 50U3gdAs056200; Thu, 30 Jan 2025 03:42:39 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 50U3gdjY056197; Thu, 30 Jan 2025 03:42:39 GMT (envelope-from git) Date: Thu, 30 Jan 2025 03:42:39 GMT Message-Id: <202501300342.50U3gdjY056197@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Enji Cooper Subject: git: 36d7d2044b93 - main - mca_log: add missing breaks when handling thresholds List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: ngie X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 36d7d2044b934103ad9254cd03ea61245c16ccda Auto-Submitted: auto-generated The branch main has been updated by ngie: URL: https://cgit.FreeBSD.org/src/commit/?id=36d7d2044b934103ad9254cd03ea61245c16ccda commit 36d7d2044b934103ad9254cd03ea61245c16ccda Author: Enji Cooper AuthorDate: 2025-01-29 21:24:53 +0000 Commit: Enji Cooper CommitDate: 2025-01-30 03:42:18 +0000 mca_log: add missing breaks when handling thresholds Per the "Intel® 64 and IA-32 Architectures Software Developer’s Manual Combined Volumes: Vol. 3B 17-7", the Green and Yellow threshold indicators are mutually exclusive. Add the missing `break` statements so they're treated that way. MFC after: 1 week Reported by: Coverity Differential Revision: https://reviews.freebsd.org/D48722 --- sys/x86/x86/mca.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/sys/x86/x86/mca.c b/sys/x86/x86/mca.c index b293fcedbd84..4ba49469d3a2 100644 --- a/sys/x86/x86/mca.c +++ b/sys/x86/x86/mca.c @@ -453,8 +453,10 @@ mca_log(const struct mca_record *rec) switch ((rec->mr_status & MC_STATUS_TES_STATUS) >> 53) { case 0x1: printf("(Green) "); + break; case 0x2: printf("(Yellow) "); + break; } } }