From nobody Tue Jan 28 20:09:27 2025 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4YjGbD06hFz5m3ys; Tue, 28 Jan 2025 20:09:28 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4YjGbC5t56z3p6q; Tue, 28 Jan 2025 20:09:27 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1738094967; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=BN6kgyn3bIBR/RPD0RgzIND0mXTwk7S3ttv2g60fHP4=; b=Z9LdPh6VX3lK2IRtNwILhmSVacncVzQcLkxssvFl4TVAfaz0RQDHCjgGiFcWftleyQ/E3K tBYpPtk3mBchmbVYNFVYsyEw65xdtqev/NkIbQTDnTxn4f4mraJoRannW/xzpt7Vnks5d6 ZzShbLN0J0dt9K4z5uFtiYh6E3k6I7rLJTv0Uc+F58ChMDpPTOMDldyOQdU1ZgjH/gVCrr p+6zzVfLwrxrKmlzsPtSxOwBdEqE9JrDHiJ1ljrgP3j7o+D6JqZD21rroS5ybUfe3ap8MI DPuC1ruennu1ep8tK/M3txUAMz15+CRPOXgcrB99fGhXFucox8gUlM2FQx8zXA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1738094967; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=BN6kgyn3bIBR/RPD0RgzIND0mXTwk7S3ttv2g60fHP4=; b=wXo+FALYpzUKSnXcjhlj5Fs7iJIcgTqsyYl56k5UXVCqjTGFM7kAMgD5zHe9CdHtzTeSXS ctNFbnpujgDVSeFDoOleWq/MW0x1JxiiPnILTWASwx8u4hI1W3q1vd7mAv+3TbMxtz/NnQ LPnsV7ufaaYj1zmsBoEDIaFVmAGMkzk7C1kk+DUDoRIUCyvBvjlOzZJlmq2LKZMgR8B0nY uO/X51mF4nsG7JpjtuXOmBcm3nV6i5u86wZmbnFLPTdWvSs/CrFeoVu2Qm3j7Im+HOVSN+ TFJ4w/cSYbq5qtcABFcBOX9VFeGh8mlxZ8ZtsAHsogKPEWFmSshiSz56MgDLuQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1738094967; a=rsa-sha256; cv=none; b=iZdUAcDnY0cEHcqh/+I32w0lcnwvgssjj7GDPTq/Oa/W+Qwj/mCGHhk9QcpuqMiujgYtR8 7dMvIxDmuBOVeCZlWodRpL8VwCXrn6A3ihz2/zV4TOEc5/fvnBjxXiCIVKrdGSqJsuWuFA nvaqbltYtDmVb4pygUegu7kSLxdbqTyUm4XMAZdoTbrYKJKmk3/JEXFg8V2LmNVKiFSJ1O AIBjwdKqwSega/vQDEgF1BrBVh9kdwOvEEGQdSSm3C/wRGzmzXWGCIE7k3iO6fWN1MiHsb z+cB5i/M2+1u9BQj/IoQVZqzPVRwtnHYFUSfbrDnCL6o7P01dsabULoLKwijpQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4YjGbC5BTDzTYN; Tue, 28 Jan 2025 20:09:27 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 50SK9RmT003616; Tue, 28 Jan 2025 20:09:27 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 50SK9Rtw003613; Tue, 28 Jan 2025 20:09:27 GMT (envelope-from git) Date: Tue, 28 Jan 2025 20:09:27 GMT Message-Id: <202501282009.50SK9Rtw003613@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Warner Losh Subject: git: c64b3f32a570 - main - umass: Add comment for ASC/ASCQ 24h/00h INVALID FIELD IN CDB List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: imp X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: c64b3f32a570ede5c21a39a6c2ffec1ff41e5ff3 Auto-Submitted: auto-generated The branch main has been updated by imp: URL: https://cgit.FreeBSD.org/src/commit/?id=c64b3f32a570ede5c21a39a6c2ffec1ff41e5ff3 commit c64b3f32a570ede5c21a39a6c2ffec1ff41e5ff3 Author: Warner Losh AuthorDate: 2025-01-28 20:08:51 +0000 Commit: Warner Losh CommitDate: 2025-01-28 20:08:51 +0000 umass: Add comment for ASC/ASCQ 24h/00h INVALID FIELD IN CDB Add a comment for what this asc/ascq combo means. Very few people have this memorized. Sponsored by: Netflix --- sys/dev/usb/storage/umass.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sys/dev/usb/storage/umass.c b/sys/dev/usb/storage/umass.c index e0daada72bdb..ba10a23d2987 100644 --- a/sys/dev/usb/storage/umass.c +++ b/sys/dev/usb/storage/umass.c @@ -2247,7 +2247,7 @@ umass_cam_action(struct cam_sim *sim, union ccb *ccb) /*sense_format*/ SSD_TYPE_NONE, /*current_error*/ 1, /*sense_key*/ SSD_KEY_ILLEGAL_REQUEST, - /*asc*/ 0x24, + /*asc*/ 0x24, /* 24h/00h INVALID FIELD IN CDB */ /*ascq*/ 0x00, /*extra args*/ SSD_ELEM_NONE); ccb->csio.scsi_status = SCSI_STATUS_CHECK_COND;