git: 42a885e6907c - stable/14 - mountd(8): parsecred(): Remove comment on non-existent bug
- Go to: [ bottom of page ] [ top of archives ] [ this month ]
Date: Thu, 16 Jan 2025 18:08:26 UTC
The branch stable/14 has been updated by olce:
URL: https://cgit.FreeBSD.org/src/commit/?id=42a885e6907c44afd0d848c6f5c37f58f108e029
commit 42a885e6907c44afd0d848c6f5c37f58f108e029
Author: Olivier Certner <olce@FreeBSD.org>
AuthorDate: 2024-10-08 09:44:06 +0000
Commit: Olivier Certner <olce@FreeBSD.org>
CommitDate: 2025-01-16 18:06:58 +0000
mountd(8): parsecred(): Remove comment on non-existent bug
'name' can never be NULL, as it is equal to 'names' and 'namelist',
which was passed by do_cred() only if the actual parameter wasn't NULL.
Reviewed by: rmacklem
Approved by: markj (mentor)
MFC after: 2 weeks
Sponsored by: The FreeBSD Foundation
Differential Revision: https://reviews.freebsd.org/D47014
(cherry picked from commit 0b011b5cddb5b17cf5b8f50ff580f3eb4abaeeef)
---
usr.sbin/mountd/mountd.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/usr.sbin/mountd/mountd.c b/usr.sbin/mountd/mountd.c
index 55db501332bf..efc6e0ef6730 100644
--- a/usr.sbin/mountd/mountd.c
+++ b/usr.sbin/mountd/mountd.c
@@ -3634,7 +3634,6 @@ parsecred(char *namelist, struct expcred *cr)
*/
names = namelist;
name = strsep_quote(&names, ":");
- /* Bug? name could be NULL here */
name_ul = strtoul(name, &end, 10);
if (*end != '\0' || end == name)
pw = getpwnam(name);