git: f415b2ef30f7 - main - fusefs: Coverity cleanup in the lseek tests

The branch main has been updated by asomers:

URL: https://cgit.FreeBSD.org/src/commit/?id=f415b2ef30f7bf0db753f09fbba7b0910475b0d2

commit f415b2ef30f7bf0db753f09fbba7b0910475b0d2
Author:     Alan Somers <asomers@FreeBSD.org>
AuthorDate: 2025-01-06 19:21:29 +0000
Commit:     Alan Somers <asomers@FreeBSD.org>
CommitDate: 2025-01-06 19:30:16 +0000

    fusefs: Coverity cleanup in the lseek tests
    
    Always check the return value of open().
    
    Reported by:    Coverity Scan
    CID:            1471118 1471133 1471215 1471896 1471901 1472116 1473799
    CID:            1473879 1473996 1555269 1558044
    MFC after:      2 weeks
    Sponsored by:   ConnectWise
---
 tests/sys/fs/fusefs/lseek.cc | 11 +++++++++++
 1 file changed, 11 insertions(+)

diff --git a/tests/sys/fs/fusefs/lseek.cc b/tests/sys/fs/fusefs/lseek.cc
index 2a1cb198bcce..12d41f7af1b2 100644
--- a/tests/sys/fs/fusefs/lseek.cc
+++ b/tests/sys/fs/fusefs/lseek.cc
@@ -71,6 +71,7 @@ TEST_F(LseekPathconf, already_enosys)
 	).WillOnce(Invoke(ReturnErrno(ENOSYS)));
 
 	fd = open(FULLPATH, O_RDONLY);
+	ASSERT_LE(0, fd);
 
 	EXPECT_EQ(offset_in, lseek(fd, offset_in, SEEK_DATA));
 	EXPECT_EQ(-1, fpathconf(fd, _PC_MIN_HOLE_SIZE));
@@ -105,6 +106,7 @@ TEST_F(LseekPathconf, already_seeked)
 		out.body.lseek.offset = i.body.lseek.offset;
 	})));
 	fd = open(FULLPATH, O_RDONLY);
+	ASSERT_LE(0, fd);
 	EXPECT_EQ(offset, lseek(fd, offset, SEEK_DATA));
 
 	EXPECT_EQ(1, fpathconf(fd, _PC_MIN_HOLE_SIZE));
@@ -171,6 +173,7 @@ TEST_F(LseekPathconf, eio)
 	.WillRepeatedly(Invoke(ReturnErrno(EIO)));
 
 	fd = open(FULLPATH, O_RDONLY);
+	ASSERT_LE(0, fd);
 
 	EXPECT_EQ(-1, fpathconf(fd, _PC_MIN_HOLE_SIZE));
 	EXPECT_EQ(EIO, errno);
@@ -203,6 +206,7 @@ TEST_F(LseekPathconf, enosys_now)
 	).WillOnce(Invoke(ReturnErrno(ENOSYS)));
 
 	fd = open(FULLPATH, O_RDONLY);
+	ASSERT_LE(0, fd);
 
 	EXPECT_EQ(-1, fpathconf(fd, _PC_MIN_HOLE_SIZE));
 	EXPECT_EQ(EINVAL, errno);
@@ -266,6 +270,7 @@ TEST_F(LseekPathconf, seek_now)
 	})));
 
 	fd = open(FULLPATH, O_RDONLY);
+	ASSERT_LE(0, fd);
 	EXPECT_EQ(offset_initial, lseek(fd, offset_initial, SEEK_SET));
 	EXPECT_EQ(1, fpathconf(fd, _PC_MIN_HOLE_SIZE));
 	/* And check that the file pointer hasn't changed */
@@ -299,6 +304,7 @@ TEST_F(LseekPathconf, zerolength)
 	).WillOnce(Invoke(ReturnErrno(ENXIO)));
 
 	fd = open(FULLPATH, O_RDONLY);
+	ASSERT_LE(0, fd);
 	EXPECT_EQ(1, fpathconf(fd, _PC_MIN_HOLE_SIZE));
 	/* Check again, to ensure that the kernel recorded the response */
 	EXPECT_EQ(1, fpathconf(fd, _PC_MIN_HOLE_SIZE));
@@ -327,6 +333,7 @@ TEST_F(LseekPathconf_7_23, already_enosys)
 	).Times(0);
 
 	fd = open(FULLPATH, O_RDONLY);
+	ASSERT_LE(0, fd);
 	EXPECT_EQ(-1, fpathconf(fd, _PC_MIN_HOLE_SIZE));
 	EXPECT_EQ(EINVAL, errno);
 
@@ -391,6 +398,7 @@ TEST_F(LseekSeekData, enosys)
 		_)
 	).WillOnce(Invoke(ReturnErrno(ENOSYS)));
 	fd = open(FULLPATH, O_RDONLY);
+	ASSERT_LE(0, fd);
 
 	/*
 	 * Default behavior: ENXIO if offset is < 0 or >= fsize, offset
@@ -431,6 +439,7 @@ TEST_F(LseekSeekHole, ok)
 		out.body.lseek.offset = offset_out;
 	})));
 	fd = open(FULLPATH, O_RDONLY);
+	ASSERT_LE(0, fd);
 	EXPECT_EQ(offset_out, lseek(fd, offset_in, SEEK_HOLE));
 	EXPECT_EQ(offset_out, lseek(fd, 0, SEEK_CUR));
 
@@ -463,6 +472,7 @@ TEST_F(LseekSeekHole, enosys)
 		_)
 	).WillOnce(Invoke(ReturnErrno(ENOSYS)));
 	fd = open(FULLPATH, O_RDONLY);
+	ASSERT_LE(0, fd);
 
 	/*
 	 * Default behavior: ENXIO if offset is < 0 or >= fsize, fsize
@@ -500,6 +510,7 @@ TEST_F(LseekSeekHole, enxio)
 		_)
 	).WillOnce(Invoke(ReturnErrno(ENXIO)));
 	fd = open(FULLPATH, O_RDONLY);
+	ASSERT_LE(0, fd);
 	EXPECT_EQ(-1, lseek(fd, offset_in, SEEK_HOLE));
 	EXPECT_EQ(ENXIO, errno);