git: 84e894ce1309 - main - TCP RACK: remove variable with is only initialized and not changed
- Go to: [ bottom of page ] [ top of archives ] [ this month ]
Date: Sat, 04 Jan 2025 20:14:02 UTC
The branch main has been updated by tuexen:
URL: https://cgit.FreeBSD.org/src/commit/?id=84e894ce1309b426aa5d1a20ec194401f35dc478
commit 84e894ce1309b426aa5d1a20ec194401f35dc478
Author: Michael Tuexen <tuexen@FreeBSD.org>
AuthorDate: 2025-01-04 20:11:26 +0000
Commit: Michael Tuexen <tuexen@FreeBSD.org>
CommitDate: 2025-01-04 20:11:26 +0000
TCP RACK: remove variable with is only initialized and not changed
minslot is initialized to 0 and never changed. It is not clear to me
under which condition minslot should be set to which value.
Therefore, remove it and the code checking that it is not zero.
No functional change intended.
Reviewed by: rrs
CID: 1523812
MFC after: 1 week
Sponsored by: Netflix, Inc.
Differential Revision: https://reviews.freebsd.org/D48321
---
sys/netinet/tcp_stacks/rack.c | 6 ------
1 file changed, 6 deletions(-)
diff --git a/sys/netinet/tcp_stacks/rack.c b/sys/netinet/tcp_stacks/rack.c
index 6774acb9d5e6..cc0725324760 100644
--- a/sys/netinet/tcp_stacks/rack.c
+++ b/sys/netinet/tcp_stacks/rack.c
@@ -17456,7 +17456,6 @@ rack_get_pacing_delay(struct tcp_rack *rack, struct tcpcb *tp, uint32_t len, str
{
uint64_t srtt;
int32_t slot = 0;
- int32_t minslot = 0;
int can_start_hw_pacing = 1;
int err;
int pace_one;
@@ -17788,11 +17787,6 @@ rack_get_pacing_delay(struct tcp_rack *rack, struct tcpcb *tp, uint32_t len, str
}
}
}
- if (minslot && (minslot > slot)) {
- rack_log_pacing_delay_calc(rack, minslot, slot, rack->r_ctl.crte->rate, bw_est, lentim,
- 98, __LINE__, NULL, 0);
- slot = minslot;
- }
done_w_hdwr:
if (rack_limit_time_with_srtt &&
(rack->use_fixed_rate == 0) &&