git: 97309cec6f31 - main - netinet: Make in_ifhasaddr() return bool
- Go to: [ bottom of page ] [ top of archives ] [ this month ]
Date: Thu, 27 Feb 2025 15:59:20 UTC
The branch main has been updated by zlei:
URL: https://cgit.FreeBSD.org/src/commit/?id=97309cec6f31f1f4f7a76f9ec5c7dd359c56de02
commit 97309cec6f31f1f4f7a76f9ec5c7dd359c56de02
Author: Zhenlei Huang <zlei@FreeBSD.org>
AuthorDate: 2025-02-27 15:58:20 +0000
Commit: Zhenlei Huang <zlei@FreeBSD.org>
CommitDate: 2025-02-27 15:58:20 +0000
netinet: Make in_ifhasaddr() return bool
No functional change intended.
MFC after: 1 week
---
sys/netinet/in.c | 8 ++++----
sys/netinet/in.h | 2 +-
sys/netinet/udp_usrreq.c | 2 +-
3 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/sys/netinet/in.c b/sys/netinet/in.c
index 5a28eecc6945..9a644c60e541 100644
--- a/sys/netinet/in.c
+++ b/sys/netinet/in.c
@@ -185,9 +185,9 @@ in_localip_fib(struct in_addr in, uint16_t fib)
}
/*
- * Return 1 if an internet address is configured on an interface.
+ * Return true if an internet address is configured on an interface.
*/
-int
+bool
in_ifhasaddr(struct ifnet *ifp, struct in_addr in)
{
struct ifaddr *ifa;
@@ -200,10 +200,10 @@ in_ifhasaddr(struct ifnet *ifp, struct in_addr in)
continue;
ia = (struct in_ifaddr *)ifa;
if (ia->ia_addr.sin_addr.s_addr == in.s_addr)
- return (1);
+ return (true);
}
- return (0);
+ return (false);
}
/*
diff --git a/sys/netinet/in.h b/sys/netinet/in.h
index 0ebd238d6638..3d087e5b06d5 100644
--- a/sys/netinet/in.h
+++ b/sys/netinet/in.h
@@ -678,7 +678,7 @@ int in_canforward(struct in_addr);
bool in_localaddr(struct in_addr);
bool in_localip(struct in_addr);
bool in_localip_fib(struct in_addr, uint16_t);
-int in_ifhasaddr(struct ifnet *, struct in_addr);
+bool in_ifhasaddr(struct ifnet *, struct in_addr);
struct in_ifaddr *in_findlocal(uint32_t, bool);
int inet_aton(const char *, struct in_addr *); /* in libkern */
char *inet_ntoa_r(struct in_addr ina, char *buf); /* in libkern */
diff --git a/sys/netinet/udp_usrreq.c b/sys/netinet/udp_usrreq.c
index 131242ce9859..2c68d0880100 100644
--- a/sys/netinet/udp_usrreq.c
+++ b/sys/netinet/udp_usrreq.c
@@ -1072,7 +1072,7 @@ udp_v4mapped_pktinfo(struct cmsghdr *cm, struct sockaddr_in * src,
ifp = NULL;
if (ifp != NULL && !IN6_IS_ADDR_UNSPECIFIED(&pktinfo->ipi6_addr)) {
ia.s_addr = pktinfo->ipi6_addr.s6_addr32[3];
- if (in_ifhasaddr(ifp, ia) == 0)
+ if (!in_ifhasaddr(ifp, ia))
return (EADDRNOTAVAIL);
}