From nobody Fri Feb 21 21:03:39 2025 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Z02fk5973z5pLnc; Fri, 21 Feb 2025 21:03:42 +0000 (UTC) (envelope-from glebius@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R10" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Z02fk4QRMz3C0X; Fri, 21 Feb 2025 21:03:42 +0000 (UTC) (envelope-from glebius@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1740171822; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=II4LCrgt8xfEXA2OZ6KSPkecjlyX25DfUyB9WH793hk=; b=Y4ei4f6+lkMudGzDdW7UnBcbCvrlc2w32Q1Ddd3nBXr5tIrIF7zzKCXOHd1n6pa5ZqjsV+ 5HqSY3WzNZIOr2SnYRJ2XX6WL8ZkwCqtT5JA6aZ6fmVSNRVhFZxn9QRIBfwfs1nqV6oeA3 KW8hQJzsTrEKWov0EUzC6xPRBhcvB3gfP9FP36M6TjgJ0J1n0frx/4iAQMGhEZGfwVMERD VXo8Lq4xdzAEvNzhCq9xeiIldUIK9dF7iK3AQlnXLMv3xXMoCmfnki4pJ1TUKgI1hd6JQ5 +Lzyl5kwvK67TYUzt0/+QbcdUgq42cOvqHK89cIPHHj61bCycVuZleKshQhQoA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1740171822; a=rsa-sha256; cv=none; b=hw989rEtJVhpzp/79iDVPKbkyyeUQx4wj/3/UzvCP0nNKuoorCFnemy1upJ/pgiIjHiDql yz+ONLuiJr0aRfD8/wXwMwk+xspMfcAUfFOvQcYCgbDakKH2nH+pO7ghNljweko1ctOB7b fJ6GtUdrpjcOV3TrTQ12aahMK55lnfy3+3PEiLMfF60J3uCUA0hOlFuTX/lQ51efd3qtZq exqyaqMUW1QLtX3iN6msxF+iK7jY7Dfw4LKhPynE9kAiT9sunNWVi3e/irfXNQWJICcLLN hVCDmH3j6L/Vcyji/SzdqznYJM2WfAoBmm3du6d600/ur7927G/fzA9bl+yBZQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1740171822; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=II4LCrgt8xfEXA2OZ6KSPkecjlyX25DfUyB9WH793hk=; b=QppLxUHUfQ7AfX8dhe5qC6NwX4XYzqddYKDh7QrZ91YBfn9zV6YtiSmlmNlYQXJ3phdS2X zRPbx7zPN46hSTak8wSRslxD7RoAKaYpcrWTOCtEINPosyuafGa38e7YoFcOnuUlDD+ECG ntUVIpUH4PeuRNnB/hvjVPWz7bcv+zs+vnYMw/lnB6uSXsq2JUuQwFOJFqp5r3bY8eXEur 6rrHvyPfa14RzbpZKp+wqSVz/sISdn3WFG8T2RteOFzVECPpdmi42lbzyTcW/+wt6xUHJl jmrdcbnAL8VJpgCVNtwiW2fyjXV/GxkoTEt+GcURJKO2bVEGClLW0QG74tlJHw== Received: from cell.glebi.us (glebi.us [162.251.186.162]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: glebius) by smtp.freebsd.org (Postfix) with ESMTPSA id 4Z02fj6hp5zKbH; Fri, 21 Feb 2025 21:03:41 +0000 (UTC) (envelope-from glebius@freebsd.org) Date: Fri, 21 Feb 2025 13:03:39 -0800 From: Gleb Smirnoff To: Kristof Provost Cc: src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: 8754ba5a5f6e - main - pfctl: Rewrite to void using union sockaddr_union Message-ID: References: <202502210811.51L8Bkhe075894@gitrepo.freebsd.org> List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <202502210811.51L8Bkhe075894@gitrepo.freebsd.org> Kristof, On Fri, Feb 21, 2025 at 08:11:46AM +0000, Kristof Provost wrote: K> commit 8754ba5a5f6ee681de776601110313b69a779067 K> Author: Kristof Provost K> AuthorDate: 2025-02-13 17:30:12 +0000 K> Commit: Kristof Provost K> CommitDate: 2025-02-21 08:11:02 +0000 K> K> pfctl: Rewrite to void using union sockaddr_union K> K> ok mikeb K> K> Obtained from: OpenBSD, deraadt , 8717211fe3 What a nice typo in the commit message! This is how I read it: use void * pointer to sockaddr_union So I was expection to see introduction of sockaddr_union, not removal :) Maybe makes sense to not copy upstream commit messages verbatim, at least in some cases. -- Gleb Smirnoff