From nobody Thu Feb 20 14:59:12 2025 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4YzGcg1rGLz5p0sW; Thu, 20 Feb 2025 14:59:15 +0000 (UTC) (envelope-from meloun.michal@gmail.com) Received: from mail-wm1-x32a.google.com (mail-wm1-x32a.google.com [IPv6:2a00:1450:4864:20::32a]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "WR4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4YzGcf757gz3vDF; Thu, 20 Feb 2025 14:59:14 +0000 (UTC) (envelope-from meloun.michal@gmail.com) Authentication-Results: mx1.freebsd.org; none Received: by mail-wm1-x32a.google.com with SMTP id 5b1f17b1804b1-43690d4605dso6773955e9.0; Thu, 20 Feb 2025 06:59:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1740063554; x=1740668354; darn=freebsd.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:reply-to:user-agent:mime-version:date :message-id:sender:from:to:cc:subject:date:message-id:reply-to; bh=NPLfYekhHUMiBXhtbHkE626Zy4PVjU/s7+j8UODKEAI=; b=OyObOgp3lZyRdwxMHCLSkqIFaza05tex3TB9yM3x8sO/T/bKfluFrV6qGaslvpNQUL l1lfrdhNzyhtJfv4WCffuMPPWJ51ubeEgUH3S2GEN2b2tV1p13lDQhsPyNP+wBLNU+FF +F+pw52y6P3Hmg9Eb4p0/wUGV/LPOsPmZqVc2ymrm6bbMr8/qPMjrdJ6WfWons7D17qP cw9RJfkZsqGeUTKSkmFhcHKwIFCVVck0ibeaQNioq5LFdQ7hes4GdvqnyZIr2M5iftbM TS9zFMFzS/1ChmorVaDmZrr4etcOttCbRPlfdlFBK48LLw55PBKSAj60eoRDFxcpsZuA KuHQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740063554; x=1740668354; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:reply-to:user-agent:mime-version:date :message-id:sender:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=NPLfYekhHUMiBXhtbHkE626Zy4PVjU/s7+j8UODKEAI=; b=VvIr/3K9+C1IRX1+viTLe6cLFyeQzLKJsP/PnDwYvxoYHqiVxj5HrUYVDnpD4etexv +XiA3MiHtLFLsSI0DDdSAUDIMB5urw6oCJaUB221boDPnDMXyak2r8K4zpj7AuGf1met xi+BUVqmxVthYYK6+07XodwK30UroMYjNYyMsYf38EB8hPf2Bl/x3CchSx9GfXuNFsVy GCbl9/iV9BndSRmwbks4tfGNDBxrTkNhPWif/0StXy0KjOWPNRFjL8GHJFAdIlRtcmf7 gLk9RmLK1S8bn+orBw+CjU0oya4KWU0/5BCy5bly0yd5Ia83QDhSUsqXpp5ICeQ1HQBg 9hgw== X-Forwarded-Encrypted: i=1; AJvYcCVxZqdEgPB+uIE/m9pdhFhNRSNr4WhcsEudc09aW3n6SZ2ERLMnRE9jS0qYgYtJG+0qVSlo4F1wgQ==@freebsd.org, AJvYcCWJ47baVHcp51FslfzFoZwUxO6DEJqLAJfjPTlhskOMTUscg+GLZv7Cu2jd10UG3XbnXcc9qxFuDbTx3b7q8Npv2Scj@freebsd.org, AJvYcCWY0cXWd3YbfoZ8Tjw+a8vdQZGlQ3MYtTZVnGt3IelEjAW1VJRO+BcPELDxvzG+yb/b80Th19bQWBF/4Gm99Gfcatsrtx4=@freebsd.org X-Gm-Message-State: AOJu0Yzl8Nm2dBn1pyHm4KW2DGGhl4m6FTLlG9Y7S9kGB5qPixucAStC 2Njc/kuZR2YurpnFMAVQVorPfHOanZhrw2wsj2CGMXaxAL8GbkHExnV077MB X-Gm-Gg: ASbGncuHeqld6k6/D5vN9Dg8f2Furv2UZJ8ruyGSVDnAgGAgoBHEiZZlPoxNI4sADrF I8qPjRIq2Hj9sh8zNILQj80DnM6/3mGqmOBD5KwWgW88oOZFm3ytTJOhLK9vD5Z+pn0SrZQMQ6z vzKhhjpNhcsGzTU7sAL6/aYXLpXtt62PDQls2LxIQWi1ZLl07UqiyL64BHICXDgsYzkmWvFMlhg xifjY5n9BiG1IjMrLT+6e4jYx9DLsmiG5Thf/B7foRwKjDfsj47veopvaTLxPqX2TA3xvpUTqWc U5VUlKXp00rQV8oxsxjBXfN/CiMC1+iCg4FFdquFSFza77EvgsoPlvzbxART9WmUQRxc7TlIJRP q X-Google-Smtp-Source: AGHT+IG5FqOr0MGAGiBU2S3VCLabCPw6nhiX6vXAOCrIbNDnjY5e79UY61dqgS9B6fJ98kxWKF/oMw== X-Received: by 2002:a05:600c:3ba8:b0:439:a138:20 with SMTP id 5b1f17b1804b1-439a1380584mr44268095e9.20.1740063553485; Thu, 20 Feb 2025 06:59:13 -0800 (PST) Received: from ?IPV6:2001:67c:14a0:5fe0:ad43:aa20:cd33:9c46? ([2001:67c:14a0:5fe0:ad43:aa20:cd33:9c46]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-439872b5a46sm111924175e9.32.2025.02.20.06.59.12 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 20 Feb 2025 06:59:13 -0800 (PST) Message-ID: <5678bc5e-eb1b-4ac5-8b34-c7a7bfac5816@gmail.com> Date: Thu, 20 Feb 2025 15:59:12 +0100 List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Reply-To: meloun.michal@gmail.com Subject: Re: git: 61ce42253180 - main - wlanstats: move from tools to usr.sbin To: "Bjoern A. Zeeb" , Gleb Smirnoff Cc: src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org References: <202502190257.51J2vRTI049767@gitrepo.freebsd.org> Content-Language: cs, en-US From: Michal Meloun In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; TAGGED_FROM(0.00)[]; ASN(0.00)[asn:15169, ipnet:2a00:1450::/32, country:US] X-Rspamd-Queue-Id: 4YzGcf757gz3vDF X-Spamd-Bar: ---- On 19.02.2025 18:40, Bjoern A. Zeeb wrote: > On Wed, 19 Feb 2025, Gleb Smirnoff wrote: > >> On Wed, Feb 19, 2025 at 02:57:27AM +0000, Bjoern A. Zeeb wrote: >> B> commit 61ce422531805307d413bf04c9ad1aabd7f3a879 >> B> Author:     Bjoern A. Zeeb >> B> AuthorDate: 2025-02-19 02:50:11 +0000 >> B> Commit:     Bjoern A. Zeeb >> B> CommitDate: 2025-02-19 02:56:59 +0000 >> B> >> B>     wlanstats: move from tools to usr.sbin >> B> >> B>     wlanstats is an incredible tool to get a quick overview of state >> B>     of affairs of wireless by looking at the counters. >> B>     And it makes it simple. >> B> >> B>     Having landed the LinuxKPI HW_CRYPTO bits I was asked by users >> B>     what to check and I realised the answer is in wlanstats. >> B> >> B>     It is annoying even as a developer to manually build it for each >> B>     installation but given it's also useful to users and support >> B>     make it available with the general installation. >> B>     Probably very long overdue. >> B> >> B>     Adjust the Makefile and make build again on main. >> B>     Hook it up to the build conditional on MK_WIRELESS. >> B> >> B>     Discussed with: adrian >> B>     Sponsored by:   The FreeBSD Foundation >> B>     TODO:           man page >> >> Please let's not create a precedent of a new utility without >> a manual page.  Better one with grammar mistakes and terse >> than nothing. > > Better one that #manpage has reviewed than anything else. > >> This takes less than 15 minutes.  Please, fill >> this gap. > > I will; otherwise I wouldn't have mentioned it and just moved on? > > > /bz > Unfortunately, the code contains invalid behaviour. In many places it uses the following construct: struct wlanstatfoo_p *wf = (struct wlanstatfoo_p *) wf0; where wf0 is struct wlanstatfoo type. These types are not compatible and have different alignment requirements, so these are cannot be compiled at least on arm32. Moreover naming looks wrong, because wlanstatfoo_p is not pointer to struct wlanstatfoo, but to different structure. Please revert it and push fixed version. Michal